From ef8fce67f12fd4f7c8d0cdf87d7f9f6f326f6314 Mon Sep 17 00:00:00 2001 From: Mathias Jakobsen Date: Tue, 30 Jun 2026 16:37:13 +0100 Subject: [PATCH] Merge pull request #35033 from overleaf/mj-drop-dark-mode-components-opt-in [web] Remove explicit dark mode component opt-in GitOrigin-RevId: b28603a9989bd046039c247ee2cf9f740c9feac0 --- .../components/file-tree-context-menu.tsx | 7 +----- .../components/pdf-preview-detached-root.tsx | 10 +------- .../components/tabs/tabs-context-menu.tsx | 3 +-- .../stylesheets/components/button.scss | 7 ++---- .../stylesheets/components/dropdown-menu.scss | 9 +------- .../stylesheets/components/footer.scss | 16 ++++++------- .../frontend/stylesheets/components/form.scss | 11 ++++----- .../stylesheets/components/modal.scss | 23 +++++++++++++------ .../stylesheets/components/notifications.scss | 12 +++++----- .../pdf-preview/pdf-logs-entries.spec.tsx | 6 +---- .../pdf-preview/pdf-preview.spec.tsx | 8 +------ 11 files changed, 41 insertions(+), 71 deletions(-) diff --git a/services/web/frontend/js/features/file-tree/components/file-tree-context-menu.tsx b/services/web/frontend/js/features/file-tree/components/file-tree-context-menu.tsx index 072fbc1087..debc2bd083 100644 --- a/services/web/frontend/js/features/file-tree/components/file-tree-context-menu.tsx +++ b/services/web/frontend/js/features/file-tree/components/file-tree-context-menu.tsx @@ -95,12 +95,7 @@ function FileTreeContextMenu() { : 'down' return ReactDOM.createPortal( -
+
- - - ) -} -function EditorRedesignWrapper({ children }: { children: React.ReactNode }) { - // TODO ide-redesign-cleanup: this wrapper should not be required - return
{children}
+ return } export default PdfPreviewDetachedRoot // for testing diff --git a/services/web/frontend/js/features/source-editor/components/tabs/tabs-context-menu.tsx b/services/web/frontend/js/features/source-editor/components/tabs/tabs-context-menu.tsx index 6812895cab..c06e728dc8 100644 --- a/services/web/frontend/js/features/source-editor/components/tabs/tabs-context-menu.tsx +++ b/services/web/frontend/js/features/source-editor/components/tabs/tabs-context-menu.tsx @@ -73,8 +73,7 @@ export function TabsContextMenu() {
', function () { ) } - // TODO: Remove the ide-redesign-main wrapper when dark-mode buttons are rolled - // out globally. const LogsPanel = ({ children }: { children: ReactElement }) => ( -
-
{children}
-
+
{children}
) const logEntries: LogEntry[] = [ diff --git a/services/web/test/frontend/components/pdf-preview/pdf-preview.spec.tsx b/services/web/test/frontend/components/pdf-preview/pdf-preview.spec.tsx index 5d16f97ce5..16389878c0 100644 --- a/services/web/test/frontend/components/pdf-preview/pdf-preview.spec.tsx +++ b/services/web/test/frontend/components/pdf-preview/pdf-preview.spec.tsx @@ -29,13 +29,7 @@ const Layout: FC<{ layout: IdeLayout; view?: IdeView }> = ({ } const PdfViewer = ({ children }: { children: ReactElement }) => { - return ( - // TODO: ide-redesign-cleanup: Remove the .ide-redesign-main wrapper when - // the styles are no longer nested in that. -
-
{children}
-
- ) + return
{children}
} describe('', function () {