Merge pull request #16385 from overleaf/em-typescript-other-services

Add type checking to all services

GitOrigin-RevId: f328a811fca7a783e9aff7d015ea73756acededd

services/contacts/Makefile

@@ -45,7 +45,10 @@ lint:
 lint_fix:
 	$(RUN_LINTING) lint:fix
 
-test: format lint test_unit test_acceptance
+typecheck:
+	$(RUN_LINTING) typecheck
+
+test: format lint typecheck test_unit test_acceptance
 
 test_unit:
 ifneq (,$(wildcard test/unit))

services/contacts/package.json

@@ -34,6 +34,7 @@
     "esmock": "^2.1.0",
     "mocha": "^10.2.0",
     "sinon": "~9.0.1",
-    "sinon-chai": "^3.7.0"
+    "sinon-chai": "^3.7.0",
+    "typescript": "^5.0.4"
   }
 }

services/contacts/tsconfig.json

@@ -0,0 +1,9 @@
+{
+  "extends": "../../tsconfig.backend.json",
+  "include": [
+    "app.js",
+    "app/src/**/*",
+    "scripts/**/*",
+    "test/**/*"
+  ]
+}