From f1c3ddb7c25432e769d19e7e84a1dfd5c969e1bd Mon Sep 17 00:00:00 2001
From: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
Date: Wed, 11 Dec 2024 10:52:02 +0100
Subject: [PATCH] Use isReviewerRoleEnabled meta tag (#22437)

GitOrigin-RevId: e2f2529f09936a53087393d8f02968bdb5ea1acc
---
 .../components/review-panel-header.tsx                 | 10 +++++-----
 .../review-panel-resolved-threads-button.tsx           |  6 ++----
 .../review-panel-new/hooks/use-review-panel-styles.ts  |  7 ++++---
 .../features/review-panel-new/utils/position-items.ts  |  4 ++--
 .../restricted-link-sharing/add-collaborators.jsx      |  4 ++--
 5 files changed, 15 insertions(+), 16 deletions(-)

diff --git a/services/web/frontend/js/features/review-panel-new/components/review-panel-header.tsx b/services/web/frontend/js/features/review-panel-new/components/review-panel-header.tsx
index 68e5909b6f..6525eac211 100644
--- a/services/web/frontend/js/features/review-panel-new/components/review-panel-header.tsx
+++ b/services/web/frontend/js/features/review-panel-new/components/review-panel-header.tsx
@@ -6,7 +6,9 @@ import MaterialIcon from '@/shared/components/material-icon'
 import { useLayoutContext } from '@/shared/context/layout-context'
 import SplitTestBadge from '@/shared/components/split-test-badge'
 import { useTranslation } from 'react-i18next'
-import { useFeatureFlag } from '@/shared/context/split-test-context'
+import getMeta from '@/utils/meta'
+
+const isReviewerRoleEnabled = getMeta('ol-isReviewerRoleEnabled')
 
 const ReviewPanelHeader: FC = () => {
   const [trackChangesMenuExpanded, setTrackChangesMenuExpanded] =
@@ -14,8 +16,6 @@ const ReviewPanelHeader: FC = () => {
   const { setReviewPanelOpen } = useLayoutContext()
   const { t } = useTranslation()
 
-  const enableReviewerRole = useFeatureFlag('reviewer-role')
-
   return (
     <div className="review-panel-header">
       <div className="review-panel-heading">
@@ -28,7 +28,7 @@ const ReviewPanelHeader: FC = () => {
             />
           </span>
         </div>
-        {enableReviewerRole && <ReviewPanelResolvedThreadsButton />}
+        {isReviewerRoleEnabled && <ReviewPanelResolvedThreadsButton />}
         <button
           type="button"
           className="btn review-panel-close-button"
@@ -37,7 +37,7 @@ const ReviewPanelHeader: FC = () => {
           <MaterialIcon type="close" />
         </button>
       </div>
-      {!enableReviewerRole && (
+      {!isReviewerRoleEnabled && (
         <div className="review-panel-tools">
           <ReviewPanelResolvedThreadsButton />
           <ReviewPanelTrackChangesMenuButton
diff --git a/services/web/frontend/js/features/review-panel-new/components/review-panel-resolved-threads-button.tsx b/services/web/frontend/js/features/review-panel-new/components/review-panel-resolved-threads-button.tsx
index 7ae3e20d1c..90d1558a83 100644
--- a/services/web/frontend/js/features/review-panel-new/components/review-panel-resolved-threads-button.tsx
+++ b/services/web/frontend/js/features/review-panel-new/components/review-panel-resolved-threads-button.tsx
@@ -7,15 +7,13 @@ import { ReviewPanelResolvedThreadsMenu } from './review-panel-resolved-threads-
 import { useTranslation } from 'react-i18next'
 import BootstrapVersionSwitcher from '@/features/ui/components/bootstrap-5/bootstrap-version-switcher'
 import MaterialIcon from '@/shared/components/material-icon'
-import { useFeatureFlag } from '@/shared/context/split-test-context'
+import getMeta from '@/utils/meta'
 
 export const ReviewPanelResolvedThreadsButton: FC = () => {
   const [expanded, setExpanded] = useState(false)
   const buttonRef = useRef<HTMLButtonElement>(null)
   const { t } = useTranslation()
 
-  const enableReviewerRole = useFeatureFlag('reviewer-role')
-
   return (
     <>
       <OLTooltip
@@ -25,7 +23,7 @@ export const ReviewPanelResolvedThreadsButton: FC = () => {
       >
         <button
           className={
-            enableReviewerRole
+            getMeta('ol-isReviewerRoleEnabled')
               ? 'review-panel-resolved-comments-toggle-reviewer-role'
               : 'review-panel-resolved-comments-toggle'
           }
diff --git a/services/web/frontend/js/features/review-panel-new/hooks/use-review-panel-styles.ts b/services/web/frontend/js/features/review-panel-new/hooks/use-review-panel-styles.ts
index bdfc26013a..f40e42e9a5 100644
--- a/services/web/frontend/js/features/review-panel-new/hooks/use-review-panel-styles.ts
+++ b/services/web/frontend/js/features/review-panel-new/hooks/use-review-panel-styles.ts
@@ -1,13 +1,14 @@
 import { CSSProperties, useCallback, useEffect, useState } from 'react'
 import { useCodeMirrorViewContext } from '@/features/source-editor/components/codemirror-context'
-import { useFeatureFlag } from '@/shared/context/split-test-context'
+import getMeta from '@/utils/meta'
 
 export const useReviewPanelStyles = (mini: boolean) => {
   const view = useCodeMirrorViewContext()
-  const enableReviewerRole = useFeatureFlag('reviewer-role')
 
   const [styles, setStyles] = useState<CSSProperties>({
-    '--review-panel-header-height': enableReviewerRole ? '36px' : '69px',
+    '--review-panel-header-height': getMeta('ol-isReviewerRoleEnabled')
+      ? '36px'
+      : '69px',
   } as CSSProperties)
 
   const updateScrollDomVariables = useCallback((element: HTMLDivElement) => {
diff --git a/services/web/frontend/js/features/review-panel-new/utils/position-items.ts b/services/web/frontend/js/features/review-panel-new/utils/position-items.ts
index 3f57a8970e..e5e66ac8bd 100644
--- a/services/web/frontend/js/features/review-panel-new/utils/position-items.ts
+++ b/services/web/frontend/js/features/review-panel-new/utils/position-items.ts
@@ -1,7 +1,7 @@
-import { isSplitTestEnabled } from '@/utils/splitTestUtils'
+import getMeta from '@/utils/meta'
 import { debounce } from 'lodash'
 
-const COLLAPSED_HEADER_HEIGHT = isSplitTestEnabled('reviewer-role') ? 42 : 75
+const COLLAPSED_HEADER_HEIGHT = getMeta('ol-isReviewerRoleEnabled') ? 42 : 75
 const OFFSET_FOR_ENTRIES_ABOVE = 70
 const GAP_BETWEEN_ENTRIES = 4
 
diff --git a/services/web/frontend/js/features/share-project-modal/components/restricted-link-sharing/add-collaborators.jsx b/services/web/frontend/js/features/share-project-modal/components/restricted-link-sharing/add-collaborators.jsx
index 0b64e9143b..eea0e7af94 100644
--- a/services/web/frontend/js/features/share-project-modal/components/restricted-link-sharing/add-collaborators.jsx
+++ b/services/web/frontend/js/features/share-project-modal/components/restricted-link-sharing/add-collaborators.jsx
@@ -14,7 +14,7 @@ import OLForm from '@/features/ui/components/ol/ol-form'
 import OLFormGroup from '@/features/ui/components/ol/ol-form-group'
 import OLFormSelect from '@/features/ui/components/ol/ol-form-select'
 import OLButton from '@/features/ui/components/ol/ol-button'
-import { isSplitTestEnabled } from '@/utils/splitTestUtils'
+import getMeta from '@/utils/meta'
 
 export default function AddCollaborators({ readOnly }) {
   const [privileges, setPrivileges] = useState('readAndWrite')
@@ -174,7 +174,7 @@ export default function AddCollaborators({ readOnly }) {
               {t('can_edit')}
             </option>
             <option value="readOnly">{t('can_view')}</option>
-            {isSplitTestEnabled('reviewer-role') && (
+            {getMeta('ol-isReviewerRoleEnabled') && (
               <option value="review">{t('can_review')}</option>
             )}
           </OLFormSelect>