From f2b0b77907ffb1455ce02cccc1fede4b1d29f5dd Mon Sep 17 00:00:00 2001 From: Jakob Ackermann Date: Thu, 11 Aug 2022 10:19:26 +0100 Subject: [PATCH] [web] bring back compileTimeServerE2E in client side compile metrics (#9203) GitOrigin-RevId: f10ee837869b102aab25695c676d0e6adafa80c1 --- .../frontend/js/features/pdf-preview/util/metrics.js | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/services/web/frontend/js/features/pdf-preview/util/metrics.js b/services/web/frontend/js/features/pdf-preview/util/metrics.js index fa67918b63..c8e26560a5 100644 --- a/services/web/frontend/js/features/pdf-preview/util/metrics.js +++ b/services/web/frontend/js/features/pdf-preview/util/metrics.js @@ -4,7 +4,7 @@ import { trackPdfDownloadEnabled } from './pdf-caching-flags' // VERSION should get incremented when making changes to caching behavior or // adjusting metrics collection. -const VERSION = 5 +const VERSION = 6 // editing session id const EDITOR_SESSION_ID = uuid() @@ -33,8 +33,7 @@ export function trackPdfDownload(response, compileTimeClientE2E, t0) { if (!isFirstRender) return isFirstRender = false - const totalDeliveryTime = Math.ceil(performance.now() - t0) - deliveryLatencies.totalDeliveryTime = totalDeliveryTime + deliveryLatencies.totalDeliveryTime = Math.ceil(performance.now() - t0) deliveryLatencies.latencyFetch = latencyFetch if (latencyRender) { deliveryLatencies.latencyRender = latencyRender @@ -42,10 +41,7 @@ export function trackPdfDownload(response, compileTimeClientE2E, t0) { if (trackPdfDownloadEnabled) { // Submit latency along with compile context. submitCompileMetrics({ - totalDeliveryTime, - latencyFetch, - latencyRender, - compileTimeClientE2E, + ...deliveryLatencies, ...pdfCachingMetrics, }) }