Merge pull request #33149 from overleaf/ar-ja-remove-i18next-additional-packages

[web] remove i18next additional libraries

GitOrigin-RevId: 98fc17b409090db32b02bb66953f1c2e6efee608

services/web/test/unit/src/infrastructure/Translations.test.mjs

@@ -1,19 +1,18 @@
 import { describe, expect, it, vi } from 'vitest'
+import express from 'express'
 
 const MODULE_PATH = '../../../../app/src/infrastructure/Translations.mjs'
 
 describe('Translations', function () {
   let req, res, translations
-  async function runMiddlewares(cb) {
+  async function runMiddlewares() {
     return await new Promise((resolve, reject) =>
-      translations.i18nMiddleware(req, res, () => {
-        translations.setLangBasedOnDomainMiddleware(req, res, (err, result) => {
-          if (err) {
-            reject(err)
-          } else {
-            resolve(result)
-          }
-        })
+      translations.setLangBasedOnDomainMiddleware(req, res, (err, result) => {
+        if (err) {
+          reject(err)
+        } else {
+          resolve(result)
+        }
       })
     )
   }
@@ -39,6 +38,7 @@ describe('Translations', function () {
       headers: {
         'accept-language': '',
       },
+      acceptsLanguage: express.request.acceptsLanguages,
     }
     res = {
       locals: {},
@@ -59,6 +59,15 @@ describe('Translations', function () {
     it('has translate alias', function () {
       expect(req.i18n.translate('give_feedback')).to.equal('Give feedback')
     })
+
+    it('does not persist across different languages', function () {
+      expect([
+        req.i18n.translate('log_in', { lng: 'fr' }),
+        req.i18n.translate('log_in', { lng: 'en' }),
+        req.i18n.translate('log_in', { lng: 'da' }),
+        req.i18n.translate('log_in'),
+      ]).to.deep.equal(['Se connecter', 'Log in', 'Log ind', 'Log in'])
+    })
   })
 
   describe('interpolation', function () {