agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-11-15 06:33:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Improve copy for single errors or warnings"

Browse Source 
This reverts commit 1fdd270d4148abd0385e4258bb634cf769cce8c5.

GitOrigin-RevId: f01e0726b9a0119bc7f8bda3a98c2c0df5026e51
This commit is contained in:
Paulo Jorge Reis
2021-06-29 02:05:52 +00:00
committed by Copybot
parent 1e43dd3495
commit f4822e4407
6 changed files with 16 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/test/frontend/features/preview/components/preview-logs-toggle-button.test.js
+3 -22
View File
@@ -68,21 +68,12 @@ describe('<PreviewLogsToggleButton />', function () {
screen.getByText('Code check failed')
})
it('should render an error status message without a count when there is a single error', function () {
it('should render an error status message when there are errors', function () {
const logsState = {
nErrors: 1,
nWarnings: 0,
}
renderPreviewLogsToggleButton(logsState, onToggleLogs, showLogs)
screen.getByText('This project has an error')
})
it('should render an error status message with a count when there are multiple errors', function () {
const logsState = {
nErrors: 10,
nWarnings: 0,
}
renderPreviewLogsToggleButton(logsState, onToggleLogs, showLogs)
screen.getByText(`This project has errors (${logsState.nErrors})`)
})
@@ -92,24 +83,15 @@ describe('<PreviewLogsToggleButton />', function () {
nWarnings: 1,
}
renderPreviewLogsToggleButton(logsState, onToggleLogs, showLogs)
screen.getByText('This project has an error')
screen.getByText(`This project has errors (${logsState.nErrors})`)
})
it('should render a warning status message without a count when there is a single warning and no errors', function () {
it('should render a warning status message when there are warnings but no errors', function () {
const logsState = {
nErrors: 0,
nWarnings: 1,
}
renderPreviewLogsToggleButton(logsState, onToggleLogs, showLogs)
screen.getByText('View warning')
})
it('should render a warning status message with a count when there are multiple warnings and no errors', function () {
const logsState = {
nErrors: 0,
nWarnings: 10,
}
renderPreviewLogsToggleButton(logsState, onToggleLogs, showLogs)
screen.getByText(`View warnings (${logsState.nWarnings})`)
})
@@ -121,7 +103,6 @@ describe('<PreviewLogsToggleButton />', function () {
renderPreviewLogsToggleButton(logsState, onToggleLogs, showLogs)
screen.getByText('This project has errors (99+)')
})
it('should show the button text when prop showText=true', function () {
const logsState = {
nErrors: 0,