From f5343499915cd108dbb6cb16c3c9c372f5951370 Mon Sep 17 00:00:00 2001 From: Malik Glossop Date: Thu, 13 Aug 2026 13:04:29 +0200 Subject: [PATCH] Merge pull request #36490 from overleaf/copilot/fix-flaky-test-sends-invites Stabilize flaky ShareProjectModal invite JSDOM test GitOrigin-RevId: c91abb89f1d16c0347de11287ee26f1c885edba8 --- .../components/share-project-modal.test.tsx | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/services/web/test/frontend/features/share-project-modal/components/share-project-modal.test.tsx b/services/web/test/frontend/features/share-project-modal/components/share-project-modal.test.tsx index 3d695dfcea..6ad69aaf0b 100644 --- a/services/web/test/frontend/features/share-project-modal/components/share-project-modal.test.tsx +++ b/services/web/test/frontend/features/share-project-modal/components/share-project-modal.test.tsx @@ -647,10 +647,10 @@ describe('', function () { const user = userEvent.setup() await user.click(screen.getByTestId('add-collaborator-select')) - await user.click(screen.getByText('Viewer')) + await user.click(await screen.findByRole('option', { name: 'Viewer' })) const submitButton = screen.getByRole('button', { name: 'Invite' }) - await userEvent.click(submitButton) + await user.click(submitButton) let calls: CallLog[] = [] await waitFor( @@ -704,9 +704,9 @@ describe('', function () { const user = userEvent.setup() await user.click(screen.getByTestId('add-collaborator-select')) - const editorOption = screen.getByText('Editor').closest('button') - const reviewerOption = screen.getByText('Reviewer').closest('button') - const viewerOption = screen.getByText('Viewer').closest('button') + const editorOption = await screen.findByRole('option', { name: 'Editor' }) + const reviewerOption = screen.getByRole('option', { name: /Reviewer/ }) + const viewerOption = screen.getByRole('option', { name: 'Viewer' }) expect(editorOption?.classList.contains('disabled')).to.be.true expect(reviewerOption?.classList.contains('disabled')).to.be.true @@ -742,9 +742,9 @@ describe('', function () { const user = userEvent.setup() await user.click(screen.getByTestId('add-collaborator-select')) - const editorOption = screen.getByText('Editor').closest('button') - const reviewerOption = screen.getByText('Reviewer').closest('button') - const viewerOption = screen.getByText('Viewer').closest('button') + const editorOption = await screen.findByRole('option', { name: 'Editor' }) + const reviewerOption = screen.getByRole('option', { name: /Reviewer/ }) + const viewerOption = screen.getByRole('option', { name: 'Viewer' }) expect(editorOption?.classList.contains('disabled')).to.be.true expect(reviewerOption?.classList.contains('disabled')).to.be.true