From f57355f23bef80b79051d9104cff13090c2b1b17 Mon Sep 17 00:00:00 2001
From: Alf Eaton <alf.eaton@overleaf.com>
Date: Mon, 29 Jul 2024 13:29:43 +0100
Subject: [PATCH] Avoid loading ranges twice for overview panel (#19554)

GitOrigin-RevId: da8cc295fe672a97e76b93cc7e88dc1f6d3d044d
---
 .../hooks/use-review-panel-state.ts           | 22 +++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/services/web/frontend/js/features/ide-react/context/review-panel/hooks/use-review-panel-state.ts b/services/web/frontend/js/features/ide-react/context/review-panel/hooks/use-review-panel-state.ts
index 1bf99d62ce..3c066d8d21 100644
--- a/services/web/frontend/js/features/ide-react/context/review-panel/hooks/use-review-panel-state.ts
+++ b/services/web/frontend/js/features/ide-react/context/review-panel/hooks/use-review-panel-state.ts
@@ -1497,17 +1497,6 @@ function useReviewPanelState(): ReviewPanel.ReviewPanelState {
   }, [reviewPanelOpen])
 
   const canRefreshRanges = useRef(false)
-  useEffect(() => {
-    if (subView === 'overview' && canRefreshRanges.current) {
-      canRefreshRanges.current = false
-
-      setIsOverviewLoading(true)
-      refreshRanges().finally(() => {
-        setIsOverviewLoading(false)
-      })
-    }
-  }, [subView, refreshRanges])
-
   const prevSubView = useRef(subView)
   const initializedPrevSubView = useRef(false)
   useEffect(() => {
@@ -1521,6 +1510,17 @@ function useReviewPanelState(): ReviewPanel.ReviewPanelState {
     canRefreshRanges.current = true
   }, [subView])
 
+  useEffect(() => {
+    if (subView === 'overview' && canRefreshRanges.current) {
+      canRefreshRanges.current = false
+
+      setIsOverviewLoading(true)
+      refreshRanges().finally(() => {
+        setIsOverviewLoading(false)
+      })
+    }
+  }, [subView, refreshRanges])
+
   useEffect(() => {
     if (subView === 'cur_file' && prevSubView.current === 'overview') {
       dispatchReviewPanelEvent('overview-closed', subView)