From f59d5d836d7f52d60ec16274201559e70c466de1 Mon Sep 17 00:00:00 2001 From: Shane Kilkelly Date: Wed, 31 Aug 2016 10:18:53 +0100 Subject: [PATCH] Check plan, return error if not valid. This prevents a crash later when we refer to properties of the plan object, which can end up being `null` when the `planCode` is either missing, or not a valid code. --- .../Features/Subscription/SubscriptionViewModelBuilder.coffee | 3 +++ 1 file changed, 3 insertions(+) diff --git a/services/web/app/coffee/Features/Subscription/SubscriptionViewModelBuilder.coffee b/services/web/app/coffee/Features/Subscription/SubscriptionViewModelBuilder.coffee index e239a779b9..fa3bda3385 100644 --- a/services/web/app/coffee/Features/Subscription/SubscriptionViewModelBuilder.coffee +++ b/services/web/app/coffee/Features/Subscription/SubscriptionViewModelBuilder.coffee @@ -16,6 +16,9 @@ module.exports = if subscription? return callback(error) if error? plan = PlansLocator.findLocalPlanInSettings(subscription.planCode) + if !plan? + err = new Error('No plan found for planCode "#{subscription.planCode}"') + return callback(err) RecurlyWrapper.getSubscription subscription.recurlySubscription_id, (err, recurlySubscription)-> tax = recurlySubscription?.tax_in_cents || 0 callback null, {