From f5b452a819e262f59bfa062471d0ace6f4c4ecd0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timoth=C3=A9e=20Alby?= Date: Tue, 30 Nov 2021 15:53:59 +0100 Subject: [PATCH] Merge pull request #5902 from overleaf/ta-layout-local-storage Fix pdf.layout value in local storage GitOrigin-RevId: 1ff6ab51f51d2895b6e7305a36af57fb205c0fa3 --- .../web/frontend/js/shared/context/layout-context.js | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/services/web/frontend/js/shared/context/layout-context.js b/services/web/frontend/js/shared/context/layout-context.js index 69390822a5..a83639a429 100644 --- a/services/web/frontend/js/shared/context/layout-context.js +++ b/services/web/frontend/js/shared/context/layout-context.js @@ -28,6 +28,13 @@ LayoutContext.Provider.propTypes = { }).isRequired, } +function setLayoutInLocalStorage(pdfLayout) { + localStorage.setItem( + 'pdf.layout', + pdfLayout === 'sideBySide' ? 'split' : 'flat' + ) +} + export function LayoutProvider({ children }) { const { $scope } = useIdeContext() @@ -68,7 +75,7 @@ export function LayoutProvider({ children }) { const newLayout = layout === 'sideBySide' ? 'flat' : 'sideBySide' setView(newLayout === 'sideBySide' ? 'editor' : 'pdf') setPdfLayout(newLayout) - localStorage.setItem('pdf.layout', newLayout) + setLayoutInLocalStorage(newLayout) }) }, [setPdfLayout, setView]) @@ -76,7 +83,7 @@ export function LayoutProvider({ children }) { (newLayout, newView) => { setPdfLayout(newLayout) setView(newLayout === 'sideBySide' ? 'editor' : newView) - localStorage.setItem('pdf.layout', newLayout) + setLayoutInLocalStorage(newLayout) }, [setPdfLayout, setView] )