agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-11-14 22:23:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #35534 from overleaf/cd-share-sidenav-bar-with-library

Browse Source 
[web] Share the dashboard sidebar with the library page

GitOrigin-RevId: 5595746fef6698bee6a35ee7fc8be15743e2c620
This commit is contained in:
Chris Dryden
2026-09-17 11:37:57 +00:00
committed by Copybot
parent 6af1d79cd6
commit f81a7b2ff2
13 changed files with 177 additions and 274 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/test/frontend/shared/components/sidebar/ds-nav-page-switcher.spec.tsx
-114
View File
@@ -1,114 +0,0 @@
import { DsNavPageSwitcher } from '../../../../../frontend/js/shared/components/sidebar/ds-nav-page-switcher'
import { SplitTestProvider } from '@/shared/context/split-test-context'
import { UserSettingsProvider } from '@/shared/context/user-settings-context'
function mountDsNavPageSwitcher(
props: React.ComponentProps<typeof DsNavPageSwitcher>
) {
cy.mount(
<SplitTestProvider>
<UserSettingsProvider>
<DsNavPageSwitcher {...props} />
</UserSettingsProvider>
</SplitTestProvider>
)
}
describe('<DsNavPageSwitcher />', function () {
describe('activePage="library"', function () {
beforeEach(function () {
mountDsNavPageSwitcher({ activePage: 'library' })
})
it('marks the Library link as active', function () {
cy.findByRole('link', { name: /library/i }).should('have.class', 'active')
})
it('does not mark the Projects link as active', function () {
cy.findByRole('link', { name: /projects/i }).should(
'not.have.class',
'active'
)
})
it('sets aria-current on the Library link', function () {
cy.findByRole('link', { name: /library/i }).should(
'have.attr',
'aria-current',
'page'
)
})
it('does not set aria-current on the Projects link', function () {
cy.findByRole('link', { name: /projects/i }).should(
'not.have.attr',
'aria-current'
)
})
it('renders the logo', function () {
cy.get('.ds-nav-page-switcher-logo img').should('exist')
})
})
describe('activePage="projects"', function () {
beforeEach(function () {
mountDsNavPageSwitcher({ activePage: 'projects' })
})
it('marks the Projects link as active', function () {
cy.findByRole('link', { name: /projects/i }).should(
'have.class',
'active'
)
})
it('does not mark the Library link as active', function () {
cy.findByRole('link', { name: /library/i }).should(
'not.have.class',
'active'
)
})
it('renders the logo', function () {
cy.get('.ds-nav-page-switcher-logo img').should('exist')
})
})
describe('link hrefs', function () {
beforeEach(function () {
mountDsNavPageSwitcher({ activePage: 'library' })
})
it('Library link points to /library', function () {
cy.findByRole('link', { name: /library/i }).should(
'have.attr',
'href',
'/library'
)
})
it('Projects link points to /project', function () {
cy.findByRole('link', { name: /projects/i }).should(
'have.attr',
'href',
'/project'
)
})
})
describe('showLogo={false}', function () {
beforeEach(function () {
mountDsNavPageSwitcher({ activePage: 'projects', showLogo: false })
})
it('does not render the logo', function () {
cy.get('.ds-nav-page-switcher-logo').should('not.exist')
})
it('still renders both nav links', function () {
cy.findByRole('link', { name: /library/i }).should('exist')
cy.findByRole('link', { name: /projects/i }).should('exist')
})
})
})