agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-11-15 14:43:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

remove null check on mailchimp at top of file

Browse Source 
I didn't like the if statment being after the require, mailchimp
could also be null and called elsewhere by acident
This commit is contained in:
Henry Oswald
2018-08-06 12:37:18 +01:00
parent 17a63258c6
commit fa37caef58
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/app/coffee/Features/Newsletter/NewsletterManager.coffee
+2 -1
View File
@@ -3,7 +3,6 @@ logger = require 'logger-sharelatex'
Settings = require 'settings-sharelatex' Settings = require 'settings-sharelatex'
crypto = require('crypto') crypto = require('crypto')
Mailchimp = require('mailchimp-api-v3') Mailchimp = require('mailchimp-api-v3')
mailchimp = new Mailchimp(Settings.mailchimp?.api_key) if Settings.mailchimp?
module.exports = module.exports =
subscribe: (user, callback = () ->)-> subscribe: (user, callback = () ->)->
@@ -12,6 +11,7 @@ module.exports =
return callback() return callback()
options = buildOptions(user, true) options = buildOptions(user, true)
logger.log options:options, user:user, email:user.email, "trying to subscribe user to the mailing list" logger.log options:options, user:user, email:user.email, "trying to subscribe user to the mailing list"
mailchimp = new Mailchimp(Settings.mailchimp?.api_key)
mailchimp.request options, (err)-> mailchimp.request options, (err)->
if err? if err?
logger.err err:err, "error subscribing person to newsletter" logger.err err:err, "error subscribing person to newsletter"
@@ -25,6 +25,7 @@ module.exports =
return callback() return callback()
logger.log user:user, email:user.email, "trying to unsubscribe user to the mailing list" logger.log user:user, email:user.email, "trying to unsubscribe user to the mailing list"
options = buildOptions(user, false) options = buildOptions(user, false)
mailchimp = new Mailchimp(Settings.mailchimp?.api_key)
mailchimp.request options, (err)-> mailchimp.request options, (err)->
if err? if err?
logger.err err:err, "error unsubscribing person to newsletter" logger.err err:err, "error unsubscribing person to newsletter"