From fba8f776a1558acab3868a382718651d588f880a Mon Sep 17 00:00:00 2001 From: Jakob Ackermann Date: Fri, 9 May 2025 10:13:33 +0200 Subject: [PATCH] [web] avoid trying to fetch synctex.gz from clsi-cache in free projects (#25445) * [web] avoid trying to fetch synctex.gz from clsi-cache in free projects * [clsi] parse boolean query parameter GitOrigin-RevId: 99c98aac8147a626b704e9a888b7fc660cc5ab17 --- services/clsi/app/js/CompileController.js | 6 ++++-- services/web/app/src/Features/Compile/CompileController.js | 6 ++++++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/services/clsi/app/js/CompileController.js b/services/clsi/app/js/CompileController.js index e102b19dad..4c411a54cf 100644 --- a/services/clsi/app/js/CompileController.js +++ b/services/clsi/app/js/CompileController.js @@ -191,7 +191,8 @@ function clearCache(req, res, next) { } function syncFromCode(req, res, next) { - const { file, editorId, buildId, compileFromClsiCache } = req.query + const { file, editorId, buildId } = req.query + const compileFromClsiCache = req.query.compileFromClsiCache === 'true' const line = parseInt(req.query.line, 10) const column = parseInt(req.query.column, 10) const { imageName } = req.query @@ -220,7 +221,8 @@ function syncFromPdf(req, res, next) { const page = parseInt(req.query.page, 10) const h = parseFloat(req.query.h) const v = parseFloat(req.query.v) - const { imageName, editorId, buildId, compileFromClsiCache } = req.query + const { imageName, editorId, buildId } = req.query + const compileFromClsiCache = req.query.compileFromClsiCache === 'true' const projectId = req.params.project_id const userId = req.params.user_id CompileManager.syncFromPdf( diff --git a/services/web/app/src/Features/Compile/CompileController.js b/services/web/app/src/Features/Compile/CompileController.js index 34d92a4e59..25f8190374 100644 --- a/services/web/app/src/Features/Compile/CompileController.js +++ b/services/web/app/src/Features/Compile/CompileController.js @@ -553,6 +553,12 @@ const _CompileController = { async _proxyToClsi(projectId, action, url, qs, req, res) { const limits = await CompileManager.promises.getProjectCompileLimits(projectId) + if ( + qs?.compileFromClsiCache && + !['alpha', 'priority'].includes(limits.compileGroup) + ) { + qs.compileFromClsiCache = false + } return CompileController._proxyToClsiWithLimits( projectId, action,