agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-11-15 06:33:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add an endpoint to remove a notification by its key alone

Browse Source
This commit is contained in:
Shane Kilkelly
2016-08-11 10:01:21 +01:00
parent 197ee9f4d9
commit fc78bfe86c
5 changed files with 51 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/notifications/test/unit/coffee/NotificationsControllerTest.coffee
+15 -5
View File
@@ -24,7 +24,7 @@ describe 'Notifications Controller', ->
describe "getUserNotifications", ->
it 'should ask the notifications for the users notifications', (done)->
@notifications.getUserNotifications = sinon.stub().callsArgWith(1, null, @stubbedNotification)
req =
req =
params:
user_id: user_id
@controller.getUserNotifications req, json:(result)=>
@@ -35,7 +35,7 @@ describe 'Notifications Controller', ->
describe "addNotification", ->
it "should tell the notifications to add the notification for the user", (done)->
@notifications.addNotification = sinon.stub().callsArgWith(2)
req =
req =
params:
user_id: user_id
body: @stubbedNotification
@@ -46,7 +46,7 @@ describe 'Notifications Controller', ->
describe "removeNotificationId", ->
it "should tell the notifications to mark the notification Id as read", (done)->
@notifications.removeNotificationId = sinon.stub().callsArgWith(2)
req =
req =
params:
user_id: user_id
notification_id: notification_id
@@ -57,10 +57,20 @@ describe 'Notifications Controller', ->
describe "removeNotificationKey", ->
it "should tell the notifications to mark the notification Key as read", (done)->
@notifications.removeNotificationKey = sinon.stub().callsArgWith(2)
req =
req =
params:
user_id: user_id
body: {key: notification_key}
@controller.removeNotificationKey req, send:(result)=>
@notifications.removeNotificationKey.calledWith(user_id, notification_key).should.equal true
done()
done()
describe "removeNotificationByKeyOnly", ->
it "should tell the notifications to mark the notification Key as read", (done)->
@notifications.removeNotificationByKeyOnly = sinon.stub().callsArgWith(1)
req =
params:
key: notification_key
@controller.removeNotificationByKeyOnly req, send:(result)=>
@notifications.removeNotificationByKeyOnly.calledWith(notification_key).should.equal true
done()
services/notifications/test/unit/coffee/NotificationsTests.coffee
+16 -4
View File
@@ -65,10 +65,10 @@ describe 'Notifications Tests', ->
@updateStub.callsArgWith(2, null)
@notifications.removeNotificationId user_id, notification_id, (err)=>
searchOps =
searchOps =
user_id:ObjectId(user_id)
_id:ObjectId(notification_id)
updateOperation =
updateOperation =
"$unset": {templateKey:true, messageOpts:true}
@updateStub.calledWith(searchOps, updateOperation).should.equal true
done()
@@ -78,10 +78,22 @@ describe 'Notifications Tests', ->
@updateStub.callsArgWith(2, null)
@notifications.removeNotificationKey user_id, notification_key, (err)=>
searchOps =
searchOps =
user_id:ObjectId(user_id)
key: notification_key
updateOperation =
updateOperation =
"$unset": {templateKey:true}
@updateStub.calledWith(searchOps, updateOperation).should.equal true
done()
describe 'removeNotificationByKeyOnly', ->
it 'should mark the notification key as read', (done)->
@updateStub.callsArgWith(2, null)
@notifications.removeNotificationByKeyOnly notification_key, (err)=>
searchOps =
key: notification_key
updateOperation =
"$unset": {templateKey:true}
@updateStub.calledWith(searchOps, updateOperation).should.equal true
done()