From fcd5758a7e5373a997033a0d187c396f4c4f0d45 Mon Sep 17 00:00:00 2001 From: Alf Eaton Date: Fri, 26 Jan 2024 09:41:46 +0000 Subject: [PATCH] Remove setSavedAt from detach compile context (#16742) GitOrigin-RevId: 2a85b4a0cd6b73c0240b64beddd8cd6ab5a48b2f --- .../pdf-preview/hooks/use-compile-triggers.js | 6 +----- .../js/shared/context/detach-compile-context.tsx | 11 +---------- .../js/shared/context/local-compile-context.tsx | 1 - 3 files changed, 2 insertions(+), 16 deletions(-) diff --git a/services/web/frontend/js/features/pdf-preview/hooks/use-compile-triggers.js b/services/web/frontend/js/features/pdf-preview/hooks/use-compile-triggers.js index fc88dea159..f75e9ee2b4 100644 --- a/services/web/frontend/js/features/pdf-preview/hooks/use-compile-triggers.js +++ b/services/web/frontend/js/features/pdf-preview/hooks/use-compile-triggers.js @@ -30,11 +30,7 @@ export const startCompileKeypress = event => { } } -export default function useCompileTriggers( - startCompile, - setChangedAt, - setSavedAt -) { +export default function useCompileTriggers(startCompile, setChangedAt) { const handleKeyDown = useCallback( event => { if (startCompileKeypress(event)) { diff --git a/services/web/frontend/js/shared/context/detach-compile-context.tsx b/services/web/frontend/js/shared/context/detach-compile-context.tsx index eaa73754ba..c63a23e29e 100644 --- a/services/web/frontend/js/shared/context/detach-compile-context.tsx +++ b/services/web/frontend/js/shared/context/detach-compile-context.tsx @@ -66,7 +66,6 @@ export const DetachCompileProvider: FC = ({ children }) => { startCompile: _startCompile, stopCompile: _stopCompile, setChangedAt: _setChangedAt, - setSavedAt: _setSavedAt, clearCache: _clearCache, syncToEntry: _syncToEntry, } = localCompileContext @@ -356,12 +355,6 @@ export const DetachCompileProvider: FC = ({ children }) => { 'detached', 'detacher' ) - const setSavedAt = useDetachAction( - 'setSavedAt', - _setSavedAt, - 'detached', - 'detacher' - ) const clearCache = useDetachAction( 'clearCache', _clearCache, @@ -376,7 +369,7 @@ export const DetachCompileProvider: FC = ({ children }) => { 'detacher' ) - useCompileTriggers(startCompile, setChangedAt, setSavedAt) + useCompileTriggers(startCompile, setChangedAt) const value = useMemo( () => ({ @@ -431,7 +424,6 @@ export const DetachCompileProvider: FC = ({ children }) => { validationIssues, firstRenderDone, setChangedAt, - setSavedAt, cleanupCompileResult, syncToEntry, }), @@ -485,7 +477,6 @@ export const DetachCompileProvider: FC = ({ children }) => { validationIssues, firstRenderDone, setChangedAt, - setSavedAt, cleanupCompileResult, syncToEntry, ] diff --git a/services/web/frontend/js/shared/context/local-compile-context.tsx b/services/web/frontend/js/shared/context/local-compile-context.tsx index 79a46a838e..25a94b29de 100644 --- a/services/web/frontend/js/shared/context/local-compile-context.tsx +++ b/services/web/frontend/js/shared/context/local-compile-context.tsx @@ -90,7 +90,6 @@ export type CompileContext = { startCompile: (options?: any) => void stopCompile: () => void setChangedAt: (value: any) => void - setSavedAt: (value: any) => void clearCache: () => void syncToEntry: (value: any) => void }