From fd7eb8681256a7c8c1baba126277c240ba5c05af Mon Sep 17 00:00:00 2001 From: Alf Eaton Date: Mon, 4 Jul 2022 14:10:40 +0100 Subject: [PATCH] Merge pull request #8703 from overleaf/ae-threads-loaded Ensure that the loaded_threads event isn't dispatched for read-only link sharing users GitOrigin-RevId: e03581f29f1a0aff122c3c16f4f6a3b70293c301 --- .../controllers/ReviewPanelController.js | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js b/services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js index c692b41328..74383832c1 100644 --- a/services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js +++ b/services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js @@ -488,15 +488,14 @@ export default App.controller( } } - if ( - rangesTracker.comments.length > 0 && - !window.isRestrictedTokenMember - ) { - ensureThreadsAreLoaded() - } else { - // ensure that tracked changes are highlighted even if no comments are loaded - ide.$scope.loadingThreads = false - dispatchReviewPanelEvent('loaded_threads') + if (!window.isRestrictedTokenMember) { + if (rangesTracker.comments.length > 0) { + ensureThreadsAreLoaded() + } else { + // ensure that tracked changes are highlighted even if no comments are loaded + ide.$scope.loadingThreads = false + dispatchReviewPanelEvent('loaded_threads') + } } for (const comment of Array.from(rangesTracker.comments)) {