From fd8bd62f5469fd77949a7ebcefbb1edfee88046b Mon Sep 17 00:00:00 2001 From: Eric Mc Sween Date: Tue, 17 May 2022 08:14:21 -0400 Subject: [PATCH] Merge pull request #7933 from overleaf/em-analytics-failed-jobs-headroom Increase the number of retained failed jobs in analytics queues GitOrigin-RevId: 384a70b46d4eef5e07216664d6f5b94d52ca3152 --- services/web/app/src/infrastructure/Queues.js | 24 ++++++++++++++----- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/services/web/app/src/infrastructure/Queues.js b/services/web/app/src/infrastructure/Queues.js index 8b20940fa2..5f5674fe94 100644 --- a/services/web/app/src/infrastructure/Queues.js +++ b/services/web/app/src/infrastructure/Queues.js @@ -6,17 +6,30 @@ const Settings = require('@overleaf/settings') // uses the completed job records to report on job duration. const MAX_COMPLETED_JOBS_RETAINED = 10000 const MAX_FAILED_JOBS_RETAINED = 50000 +const MAX_FAILED_JOBS_RETAINED_ANALYTICS = 3000000 const QUEUES_JOB_OPTIONS = { - 'analytics-events': {}, - 'analytics-editing-sessions': {}, - 'analytics-user-properties': {}, + 'analytics-events': { + removeOnFail: MAX_FAILED_JOBS_RETAINED_ANALYTICS, + }, + 'analytics-editing-sessions': { + removeOnFail: MAX_FAILED_JOBS_RETAINED_ANALYTICS, + }, + 'analytics-user-properties': { + removeOnFail: MAX_FAILED_JOBS_RETAINED_ANALYTICS, + }, 'refresh-features': { + removeOnFail: MAX_FAILED_JOBS_RETAINED, attempts: 3, }, - 'emails-onboarding': {}, - 'post-registration-analytics': {}, + 'emails-onboarding': { + removeOnFail: MAX_FAILED_JOBS_RETAINED, + }, + 'post-registration-analytics': { + removeOnFail: MAX_FAILED_JOBS_RETAINED_ANALYTICS, + }, 'scheduled-jobs': { + removeOnFail: MAX_FAILED_JOBS_RETAINED, attempts: 1, }, } @@ -42,7 +55,6 @@ function getQueue(queueName) { redis: redisOptions, defaultJobOptions: { removeOnComplete: MAX_COMPLETED_JOBS_RETAINED, - removeOnFail: MAX_FAILED_JOBS_RETAINED, attempts: 11, backoff: { type: 'exponential',