Add shellcheck to web, server-pro, server-ce (#23823)

* Update shellcheck files to include non ".sh" files having the sh shebang

* Add shellcheck to root Makefile

* `make shellcheck_fix`

* Add shellcheck to server-ce and server-pro

* Exclude SC1091 (Not following) in SP/CE

* Fix errors in SP

* Fix errors in CE

* Update root shellcheck to ignore all failing rules. We can later remove rules one by one.

* Add shellcheck to web

* Add shellcheck step for server-ce and server-pro in cloudbuild.yaml

* Revert "Add shellcheck to root Makefile"

This reverts commit e0fa56f2

* Revert "`make shellcheck_fix`"

This reverts commit eb179245c109a9e742a7fdeeb75a4bdd03963587.

* `make shellcheck_fix` in server-ce

* Fix: Use $(...) notation instead of legacy backticked

```
In init_scripts/100_set_docker_host_ipaddress.sh line 5:
echo "`route -n | awk '/UG[ \t]/{print $2}'` dockerhost" >> /etc/hosts
      ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
echo "$(route -n | awk '/UG[ \t]/{print $2}') dockerhost" >> /etc/hosts

For more information:
  https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of le...
```

* `make shellcheck_fix` in web

* Manual corrections on autofix

* Update SHELLCHECK_FILES to Perl regex so it matches at start of file

GitOrigin-RevId: 815d53f319a3792efa22703beb75570de5977450

services/web/bin/cdn_upload_batch

@@ -20,6 +20,7 @@ fi
 # -x              Python regex for excluding files from the sync
 if [[ "$text_extension" == "-" || $(find /tmp/public -type f -name "*$text_extension" | wc -l) != "0" ]]; then
   # Potentially skip upload of non-compressed .js/.css files.
+  # shellcheck disable=SC2086
   gsutil \
     -h "Cache-Control:public, max-age=31536000" \
     ${content_type_options} \
@@ -31,6 +32,8 @@ if [[ "$text_extension" == "-" || $(find /tmp/public -type f -name "*$text_exten
     "/tmp/public/" \
     "${bucket}/public/"
 fi
+
+# shellcheck disable=SC2086
 gsutil \
   -h "Cache-Control:public, max-age=31536000" \
   -h "Content-Encoding:gzip" \

services/web/bin/check_extracted_translations

@@ -4,7 +4,7 @@ set -e
 
 # Ensure all locales used in the frontend are tracked
 OUTPUT=data/dumpFolder/i18next-scanner
-trap "rm -rf $OUTPUT" EXIT
+trap 'rm -rf "$OUTPUT"' EXIT
 npx i18next-scanner --output "$OUTPUT"
 ACTUAL=frontend/extracted-translations.json
 EXPECTED="$OUTPUT/frontend/extracted-translations.json"

services/web/bin/push-translations-changes.sh

@@ -7,7 +7,7 @@ WEB_DIR=$(dirname "$SCRIPT_DIR")
 
 cd "$WEB_DIR"
 
-if [[ `git status --porcelain=2 locales/` ]]; then
+if [[ $(git status --porcelain=2 locales/) ]]; then
   git add locales/*
   git commit -m "auto update translation"
   # Switch the cloudbuild clone from https to ssh authentication.

services/web/bin/run

@@ -1,8 +1,8 @@
 #!/bin/bash
 
 pushd ..
-bin/run $*
+bin/run "$*"
 RV=$?
-popd
+popd || exit 1
 
 exit $RV