From ffc5c66e4358d555fed0384bf9126bafce0acb25 Mon Sep 17 00:00:00 2001 From: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com> Date: Tue, 8 Jul 2025 15:21:51 +0300 Subject: [PATCH] Merge pull request #26634 from overleaf/ii-join-group-copy-improvement [web] Copy change on the consent screen when joining a managed group GitOrigin-RevId: e888673778e42b8db2a857a58df89b06c4b38cdb --- .../app/src/Features/Subscription/SubscriptionLocator.js | 7 +++++-- services/web/frontend/extracted-translations.json | 2 +- services/web/locales/en.json | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/services/web/app/src/Features/Subscription/SubscriptionLocator.js b/services/web/app/src/Features/Subscription/SubscriptionLocator.js index c0c107eecf..d9956e42cb 100644 --- a/services/web/app/src/Features/Subscription/SubscriptionLocator.js +++ b/services/web/app/src/Features/Subscription/SubscriptionLocator.js @@ -4,6 +4,7 @@ const { callbackifyAll } = require('@overleaf/promise-utils') const { Subscription } = require('../../models/Subscription') +const SubscriptionHelper = require('./SubscriptionHelper') const { DeletedSubscription } = require('../../models/DeletedSubscription') const logger = require('@overleaf/logger') const { @@ -175,7 +176,8 @@ const SubscriptionLocator = { const hasActiveGroupSubscription = memberSubscriptions.some( subscription => - subscription.recurlyStatus?.state === 'active' && subscription.groupPlan + subscription.groupPlan && + SubscriptionHelper.getPaidSubscriptionState(subscription) === 'active' ) if (hasActiveGroupSubscription) { // Member of a group plan @@ -187,7 +189,8 @@ const SubscriptionLocator = { if (personalSubscription) { const hasActivePersonalSubscription = - personalSubscription.recurlyStatus?.state === 'active' + SubscriptionHelper.getPaidSubscriptionState(personalSubscription) === + 'active' if (hasActivePersonalSubscription) { if (personalSubscription.groupPlan) { // Owner of a group plan diff --git a/services/web/frontend/extracted-translations.json b/services/web/frontend/extracted-translations.json index 44eedad104..264b6098e3 100644 --- a/services/web/frontend/extracted-translations.json +++ b/services/web/frontend/extracted-translations.json @@ -1147,10 +1147,10 @@ "on_free_plan_upgrade_to_access_features": "", "one_step_away_from_professional_features": "", "only_group_admin_or_managers_can_delete_your_account_1": "", + "only_group_admin_or_managers_can_delete_your_account_10": "", "only_group_admin_or_managers_can_delete_your_account_3": "", "only_group_admin_or_managers_can_delete_your_account_6": "", "only_group_admin_or_managers_can_delete_your_account_7": "", - "only_group_admin_or_managers_can_delete_your_account_8": "", "only_group_admin_or_managers_can_delete_your_account_9": "", "only_importer_can_refresh": "", "open_action_menu": "", diff --git a/services/web/locales/en.json b/services/web/locales/en.json index 34865477e4..6d6774dd05 100644 --- a/services/web/locales/en.json +++ b/services/web/locales/en.json @@ -1505,10 +1505,10 @@ "ongoing_experiments": "Ongoing experiments", "online_latex_editor": "Online LaTeX Editor", "only_group_admin_or_managers_can_delete_your_account_1": "By becoming a managed user, your organization will have admin rights over your account and control over your stuff, including the right to close your account and access, delete and share your stuff. As a result:", + "only_group_admin_or_managers_can_delete_your_account_10": "If you have an individual subscription, we’ll automatically terminate it and cancel its renewal when your account becomes managed. To request a pro-rata refund for the remainder, please contact Support.", "only_group_admin_or_managers_can_delete_your_account_3": "Your group admin and group managers will be able to reassign ownership of your projects to another group member.", "only_group_admin_or_managers_can_delete_your_account_6": "Only your group admin or group managers will be able to delete your account or change your account back into an unmanaged account.", "only_group_admin_or_managers_can_delete_your_account_7": "Only your group admin or group managers will be able to delete your account or change your account into an unmanaged account.", - "only_group_admin_or_managers_can_delete_your_account_8": "We’ll cancel the renewal of your subscription, reach out to Support to request a pro-rata refund. Your individual subscription will be terminated when your account becomes managed.", "only_group_admin_or_managers_can_delete_your_account_9": "Once you have become a managed user, <0>you yourself cannot change it back to an unmanaged account. <1>Learn more about managed Overleaf accounts.", "only_importer_can_refresh": "Only the person who originally imported this __provider__ file can refresh it.", "open_action_menu": "Open __name__ action menu",