Commit Graph

51 Commits

Author SHA1 Message Date
Antoine Clausse
b901bb6c75 [web] Update fetch-mock to version 12 (#24837)
* Update fetch-mock to version 12

* Replace `fetchMock.done` by `fetchMock.callHistory.done`

* Replace `…Mock.called` by `…Mock.callHistory.called`

* Replace `fetchMock.reset` by `fetchMock.hardReset`

* Replace `fetchMock.restore` by `fetchMock.hardReset`

* Replace `fetchMock.resetHistory` by `fetchMock.clearHistory`

* Replace `fetchMock.calls` by `fetchMock.callHistory.calls`

* Replace `fetchMock.flush` by `fetchMock.callHistory.flush`

* Update tests for fetch-mock version 12

See https://www.wheresrhys.co.uk/fetch-mock/docs/Usage/upgrade-guide

* Update stories for fetch-mock version 12

* Remove `overwriteRoutes` option

* Add `fetchMock.spyGlobal()` to storybook

* Remove deprecated `sendAsJson` param

* Replace `fetchMock.hardReset()` by `fetchMock.removeRoutes().clearHistory()`

* Fixup fetch-mock in storybook:

Call `mockGlobal` inside the hook, call `removeRoutes` and `unmockGlobal` on cleanup

Behaviour can be tested by navigating between

https://storybook.dev-overleaf.com/main/?path=/story/editor-ai-error-assistant-compile-log-entries--first-log-entry
https://storybook.dev-overleaf.com/main/?path=/story/editor-ai-error-assistant-compile-log-entries--rate-limited

https://storybook.dev-overleaf.com/main/?path=/story/project-list-notifications--project-invite
https://storybook.dev-overleaf.com/main/?path=/story/project-list-notifications--project-invite-network-error

And clicking the buttons

GitOrigin-RevId: 35611b4430259e4c21c3d819ad18b2e6dab66242
2025-04-17 08:06:24 +00:00
Rebeka Dekany
562ef81389 Cleanup Bootstrap 3 code in the Account settings page (#24058)
* Remove the Bootstrap 5 version utilities

* Remove Account settings LESS stylesheet and unused styles

* Prefer using the OLFormText wrapper component instead of FormText

* Remove the Bootstrap 3 version stories

* Replace Font Awesome icons to Material icons

* Fix the heading hierarchy

* Cleanup unused translation

* Restore ellipsis to the text of two loading spinners

* Add loading button tests back and add some button loading labels

---------

Co-authored-by: Tim Down <158919+timdown@users.noreply.github.com>
GitOrigin-RevId: 283a9167c8c78bf0fe5062840ded6917dcd6263b
2025-03-24 10:49:33 +00:00
Tim Down
c2da12939e Merge pull request #24313 from overleaf/td-ac-bs5-frontend-tests
Update front-end tests to use Bootstrap 5

GitOrigin-RevId: abaa09f8c0639d64d6ade97468ab16204e5de97b
2025-03-24 10:48:20 +00:00
Antoine Clausse
c4e6dfbbbd [web] Use 6-digits code to confirm existing email in Account Settings (#23931)
* Rename `checkSecondaryEmailConfirmationCode` to `checkAddSecondaryEmailConfirmationCode`

* Create function `sendCodeAndStoreInSession`

* Create function `sendExistingSecondaryEmailConfirmationCode`

* Create function `_checkConfirmationCode`

* Create function `checkExistingEmailConfirmationCode`

* Rename `resendSecondaryEmailConfirmationCode` to `resendAddSecondaryEmailConfirmationCode`

* Create function `_resendConfirmationCode`

* Create function `resendExistingSecondaryEmailConfirmationCode`

* Add `ResendConfirmationCodeModal`

* Remove `ResendConfirmationEmailButton`

* `bin/run web npm run extract-translations`

* Update frontend test

* Fix: don't throw on render when send-confirmation-code fails!

* Update phrasing in the UI

Per https://docs.google.com/document/d/1PE1vlZWQN--PjmXpyHR9rV2YPd7OIPIsUbnZaHj0cDI/edit?usp=sharing

* Add unit test

* Don't share the "send-confirmation" and "resend-confirmation" rate-limits

* Update frontend test after copy change

* Rename `checkAddSecondaryEmailConfirmationCode` to `checkNewSecondaryEmailConfirmationCode` and `resendAddSecondaryEmailConfirmationCode` to `resendNewSecondaryEmailConfirmationCode`

* Rename `cb` to `beforeConfirmEmail`

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>

* Return `422` on missing session data

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>

* Add `userId` to log

* Replace `isSecondary` param by `welcomeUser`

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>

* Rename `resend-confirm-email-code`'s `existingEmail` to `email`

* Remove "secondary" from rate-limiters

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>

* Remove unnecessary `userId` check behind `AuthenticationController.requireLogin()`

* Only open the modal if the code was sent successfully

---------

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
GitOrigin-RevId: df892064641d9f722785699777383b2d863124e1
2025-03-07 09:06:50 +00:00
Antoine Clausse
34cac93f9a [web] When switching primary email, delete the old primary if it's unconfirmed (#23688)
* Add note to ConfirmModal: unconfirmed primary will be deleted

* Change confirm button copy

* Promisify `UserEmailsController.setDefault`

* Update tests after promisification

* Delete unconfirmed primary when swapped

* Fixup apostrophe in translation

* `npm run extract-translations`

* Add unit tests

* Add acceptance tests

* Fix frontend tests

* Make email address bold

* Add "We removed the previous primary..." to the email

GitOrigin-RevId: c971e219e36e509f9963e1720acdd44f562a05b5
2025-02-21 09:05:44 +00:00
Antoine Clausse
4738961f51 [web] Update secondary email addition: confirm with 6 digits code (#22851)
* Remove `Interstitial` from `ConfirmEmailForm`

* Allow adding `affiliationOptions` in `addWithConfirmationCode`

* Add confirmationStep in add-email.tsx

* Call `getEmails` once a secondary email is added

* Fix tests

* Lint fix

* Style confirm-email-form

Figma: https://www.figma.com/design/TWyeImDSZHhkl9akYaGmeb/24.5-Secondary-email-reconfirmation?node-id=1-449&p=f&m=dev

* Remove unnecessary `successMessage` and `successButtonText` from hidden ConfirmEmailForm

* Remove icon padding

* Rename file to confirm-email-form.tsx

* Use `OLButton`

* Add Cancel button

* Update loading states

* Remove redundant `className` with variants

GitOrigin-RevId: 62b1729cf2299da38f20fa3946273ad0193c7d54
2025-01-31 09:05:23 +00:00
Alf Eaton
4898b15dea Add eslint-plugin-testing-library (#23017)
* Add eslint-plugin-testing-library

* Update .eslintrc.js

* Only import from @testing-library/react

* Fix issues

GitOrigin-RevId: c225f1f70020d4431866119423cd839ce1ee5ed2
2025-01-24 09:04:59 +00:00
roo hutton
ad096f82bf Merge pull request #21905 from overleaf/rh-pause-sub
Add support for pausing subscription

GitOrigin-RevId: f939ea4e7f3c2b1fa16dcb8aff1b2460d091d4e2
2025-01-23 09:06:04 +00:00
Jimmy Domagala-Tang
5b73f08703 Merge pull request #20435 from overleaf/jdt-hide-wf-promo-from-wf-commons
Hide Writefull Promo From Writefull Commons Users

GitOrigin-RevId: 7adcb8f6e71c9c5b27da248e025b14a51fab703b
2024-09-18 08:05:00 +00:00
Jimmy Domagala-Tang
d41e069c69 Merge pull request #20404 from overleaf/revert-20389-jdt-add-writefull-commons-to-v1
Revert "Add writefull commons to v1"

GitOrigin-RevId: 703e2873cb64059f6a3881d6fc7f3c475caf5abd
2024-09-17 08:05:41 +00:00
Jimmy Domagala-Tang
aca9466c49 Merge pull request #20389 from overleaf/jdt-add-writefull-commons-to-v1
Add writefull commons to v1

GitOrigin-RevId: 36d1022f41b4db3701c6b8fa2120b035b05b38ba
2024-09-17 08:05:37 +00:00
Jakob Ackermann
aa480a2663 Merge pull request #18898 from overleaf/jpa-no-window
[web] migrate from window attributes to getMeta

GitOrigin-RevId: 3dcf1ab6b01155e5e4abeb3e78d0fa9053e055bc
2024-06-19 08:04:21 +00:00
ilkin-overleaf
482bd7fb9c Merge pull request #18103 from overleaf/ii-bs5-forms
[web] Bootstrap 5 form elements

GitOrigin-RevId: 7d031bed07007d0aa00a43f06d25bfb7384dee87
2024-05-15 08:05:11 +00:00
Alf Eaton
9729befe59 Merge pull request #18170 from overleaf/ae-token-access-page
Convert token access page to React

GitOrigin-RevId: d7434f0de395c47a95d00767727fbe9d43f9abca
2024-05-03 08:05:01 +00:00
ilkin-overleaf
1e7053cb8e Merge pull request #17921 from overleaf/ii-bs5-alert-continue
[web] Replace all alerts with notifications in settings page

GitOrigin-RevId: a05755c39d2e54b3f57ffa589885e3e96aee00dc
2024-04-24 08:04:35 +00:00
Jimmy Domagala-Tang
e47c3e67c1 Merge pull request #15296 from overleaf/jdt-reword-send
Update wording in make primary email action

GitOrigin-RevId: df82ebcbec2ea101182f154673fd1c0fb4acbeaa
2023-10-24 08:03:43 +00:00
Mathias Jakobsen
af76768eb7 Merge pull request #13372 from overleaf/mj-captcha-add-email
[web] Add recaptcha to add-email

GitOrigin-RevId: 0540e0dbc3103dcaac87dd7fabeedbc5892c371c
2023-07-17 10:40:08 +00:00
Miguel Serrano
51223315e4 Merge pull request #13164 from overleaf/msm-email-limit
[web] limit user email addresses to 10

GitOrigin-RevId: 038214cc921d86a407391e6c82fa9cd16a7f9646
2023-05-29 08:04:04 +00:00
Alf Eaton
929e383ed5 Merge pull request #13151 from overleaf/ae-testing-library-upgrades
Upgrade @testing-library dependencies

GitOrigin-RevId: d1be1cf58eccb5acdbac68ab48a31ab960ad72bc
2023-05-25 08:05:15 +00:00
ilkin-overleaf
122d2310e6 Merge pull request #12278 from overleaf/ii-change-email-confirmation
[web] Show confirmation modal when making an email primary

GitOrigin-RevId: eb67fc37c18a5ecd59973baa27ee9ef8e4b67423
2023-03-21 09:04:23 +00:00
Alf Eaton
f375362894 Always use mockable location methods (#11929)
* Always use mockable location methods
* Add eslint rules for window.location calls/assignment
* Add useLocation hook
* Update tests

GitOrigin-RevId: eafb846db89f884a7a9a8570cce7745be605152c
2023-03-17 09:05:21 +00:00
Jakob Ackermann
223b8aa9d8 Merge pull request #12250 from overleaf/ii-add-new-email-blocklist
[web] Prevent Blocklisted domains from appearing as suggestion

GitOrigin-RevId: b02bebe3e043cb264fbdbffce3f783b3af483e95
2023-03-17 09:04:33 +00:00
Brian Gough
95bb5ca4e4 Merge pull request #11002 from overleaf/msm-fix-email-suggestion
[web] Fix clearing suggestions in email input

GitOrigin-RevId: c821114e2112bf066f4ee5f01304321db983bc4e
2023-01-17 09:04:43 +00:00
Tim Down
188e8c99a7 Merge pull request #9790 from overleaf/ds-bug-fix-fetchmock
Bug fix- added a missing fetchMock in a test

GitOrigin-RevId: c0bb97f6874afa125ea0e966ff819b6fa7e245c9
2022-10-04 08:03:22 +00:00
Timothée Alby
1fe424631f Merge pull request #8291 from overleaf/ta-email-emails-ui-tweaks
[SettingsPage] Emails UI Tweaks

GitOrigin-RevId: 352d52badb234ed27ae48c39c4367c633ac83424
2022-06-07 08:02:29 +00:00
Thomas
e1fb5431db Merge pull request #8249 from overleaf/jel-reconfirmation-settings-email
[web] Reconfirmations via emails

GitOrigin-RevId: 90c992cfeea785d56ff38e007f1c70188d280aed
2022-06-06 08:04:01 +00:00
Timothée Alby
666c2c3b47 Merge pull request #8178 from overleaf/ta-settings-reconfirmation
[SettingsPage] Add Reconfirmation Prompt

GitOrigin-RevId: 2e03ba7f459b32faf6d66f21ba692ca54f62a320
2022-06-01 08:03:53 +00:00
ilkin-overleaf
e41315364d Merge pull request #8226 from overleaf/ae-remaining-types
[web] Fix remaining strict type checks

GitOrigin-RevId: 69881c37938f88c7ea4a630f362712a804085bc8
2022-06-01 08:03:29 +00:00
Miguel Serrano
0e782d3fb6 [Settings] "Start by adding your email address" hint (#8173)
* [Settings] "Start by adding your email address" hint

GitOrigin-RevId: 19d432c70b173752ee7c6d8978dd6be16b042921
2022-05-31 08:04:50 +00:00
Miguel Serrano
bce645b0f1 Merge pull request #8164 from overleaf/msm-add-disabled-state-link-accounts
[Settings] Disable "Link Account" buttons after click

GitOrigin-RevId: 528acdebe4812f1bf81fa70f1d9ce810ce5170c3
2022-05-31 08:04:46 +00:00
Timothée Alby
d2d01f6b7d Merge pull request #8186 from overleaf/msm-test-university-autocomplete
[Settings] Add test for University autocomplete

GitOrigin-RevId: 8f890a74f12bd5e349df815a662c1a3be9ba189e
2022-05-31 08:04:33 +00:00
Alf Eaton
c138e43b64 Merge pull request #8179 from overleaf/ii-settings-make-primary-btn-tooltip
Fix make primary button states

GitOrigin-RevId: a3c6fef4fd7c40f0308605f5bed4a91447838bef
2022-05-30 08:03:39 +00:00
Miguel Serrano
adc88dc5ae Merge pull request #8110 from overleaf/msm-emails-row-test
[Settings] `<EmailsRow/>` test

GitOrigin-RevId: d12d5a5f369f2abb6b296d200b04b8f85124175c
2022-05-27 08:03:30 +00:00
Timothée Alby
4d44d9b417 Merge pull request #8022 from overleaf/msm-user-email-context-tests
[Settings] `user-email-context` unit test

GitOrigin-RevId: 55e3ec6a99f1714a27d698a60fcf64711066ab6c
2022-05-24 08:05:12 +00:00
Timothée Alby
3580ec6db3 Merge pull request #8029 from overleaf/ta-settings-fix-7
[SettingsPage] Small Fixes 7

GitOrigin-RevId: 2716fe13af3f5f6b56d6bba47505fad75ba1adbf
2022-05-24 08:04:47 +00:00
Timothée Alby
7c243c6c50 Merge pull request #7975 from overleaf/ta-settings-fixes-6
[SettingsPage] Small Fixes 6

GitOrigin-RevId: 19ad9a195a401909ac3dcc2be79d380cb61078da
2022-05-19 08:03:54 +00:00
Timothée Alby
afe9e486ae Merge pull request #7930 from overleaf/fix-tsc-typings
Fix typescript errors

GitOrigin-RevId: b49235a3d9d6277e7c2de5bc7a79b7cafae75e2e
2022-05-17 08:03:54 +00:00
Timothée Alby
8c611a8f49 Merge pull request #7946 from overleaf/msm-settings-domain-blocklist
[Settings] domain blocklist for email autocompletion

GitOrigin-RevId: 62444f0f903ce3feae585c84c9f01164eac42a1f
2022-05-17 08:03:48 +00:00
Timothée Alby
920a5921c7 Merge pull request #7883 from overleaf/ii-institution-autocomplete
Institution autocomplete

GitOrigin-RevId: f0a42794ce9071ec7c0c5c2c4d499e8a027811f8
2022-05-17 08:03:42 +00:00
Timothée Alby
426aaa8b4b Merge pull request #7833 from overleaf/ta-settings-fixes-5
[SettingsPage] Small Fixes 5

GitOrigin-RevId: a0d02be246ff5128fa382bd7a9723f01377855b9
2022-05-17 08:03:36 +00:00
ilkin-overleaf
c807bedb65 Merge pull request #7841 from overleaf/ii-refactor-add-email
Refactor add email section

GitOrigin-RevId: 41de440caaf3baf43673c4a5f07a18b990f28c7b
2022-05-12 08:03:29 +00:00
ilkin-overleaf
1def576973 Merge pull request #7808 from overleaf/ii-settings-fixes-1
[SettingsPage] UI Fixes 1

GitOrigin-RevId: 0e0f605191218af4db70a801ff1e50b47f6e0b01
2022-05-02 08:03:48 +00:00
ilkin-overleaf
85f731110c Merge pull request #7786 from overleaf/ii-departments-override
Override default departments

GitOrigin-RevId: 23061bc8c083bb8099ca62bd0cdb3c796e49979d
2022-05-02 08:03:43 +00:00
Miguel Serrano
23d1bfd11e [Settings] Link SSO email (#7778)
* [Settings] Link SSO email

GitOrigin-RevId: c46ed1709ceedd74df52e02a87f22614d024afea
2022-04-28 08:04:43 +00:00
Timothée Alby
e5051bcd1d Merge pull request #7765 from overleaf/ii-add-email-ui-affiliating-with-existing-institution
Add email with existing and non existing institution

GitOrigin-RevId: 331bc06f0ea289a82b403a910491e233f4eda4bb
2022-04-28 08:03:16 +00:00
Miguel Serrano
5ed9987345 [Settings] Autocomplete input for Add Email Form (#7747)
* [Settings] Autocomplete input for Add Email Form

* Applied PR Feedback

GitOrigin-RevId: 27d2ef97deb836e92283e89675dfa3866f44904f
2022-04-27 08:04:10 +00:00
Timothée Alby
d3dc83b776 Merge pull request #7722 from overleaf/ii-add-email-ui-without-affiliations
Add emails without affiliations

GitOrigin-RevId: 13d53b604f8d7cf0f36b2c5caea85ecc15cfc6d5
2022-04-26 08:04:12 +00:00
Timothée Alby
bb59627db3 Merge pull request #7697 from overleaf/msm-sso-flow-alerts
[Settings] SSO Flow Alerts

GitOrigin-RevId: fc89c86a6681b27e86bb6bf12f8bee51eb25aa8d
2022-04-26 08:04:05 +00:00
Timothée Alby
cf2dfc6bf1 Merge pull request #7593 from overleaf/ta-settings-migration
[SettingsPage] Integration Branch

GitOrigin-RevId: 5a3c26b2a02d716c4ae3981e3f08b811ae307725
2022-04-25 08:05:12 +00:00
Tim Down
e0d5cf4b42 Merge pull request #7509 from overleaf/ii-7155-display-institution
Display the institution and role if applicable

GitOrigin-RevId: e00b07f0118e7f3ab8ec0b0f01b2b3e52fcc1cd2
2022-04-15 08:03:17 +00:00