Commit Graph

1572 Commits

Author SHA1 Message Date
M Fahru
a6d2cf8474 Merge pull request #16805 from overleaf/tm-website-redesign-ios-video-tweaks
Website redesign - video autoplay tweaks primarily to fix playback on iOS

GitOrigin-RevId: ba2844b8af64627512470d0f27ec450ee2d86b09
2024-01-30 16:49:37 +00:00
M Fahru
aec25f7732 [website-redesign] Set autoplay video configuration according to specification (#16683)
* Set autoplay video configuration according to specification:

- Do not autoplay video initially
- If the video is visible on the viewport (with a threshold of 80% of the video is visible), autoplay video, and everytime it autoplays, set the video starting point to 0
- If the video is not visible on the viewport (with a threshold of 80% of the video is not visible), pause the video
- If user screen stops at video that's currently in autoplay, the autoplay will stop after it endedand replay every 15 seconds.
- For user with reduced motion preference, show video controls.

* Add a comment explaining error in firefox if user is pressing the seek bar relatively fast.

It seems to be a bug specific to firefox.

* Reduce the threshold to 70% of the visible video on the screen.

0.7 value will make the video autoplays instantly for the `new-design-registration` variant since the video on that variant will not be shown fully on the screen at initial homepage load (in desktop screen).

* Set attribute without empty string, fix video that lacked data attribute

* Remove duplicated autoplay video setup on homepage

* Remove autoplay pause/reset on scroll away, don't play if not visible

Refactors the autoplay-video code and removes the pause/reset on scroll
away while also keeping track of the video elements visibility so that
the video doesn't immediately start playing after 15s if not visible.

We also prevent trying to call .play() before the video is in a
"canplay" state. If the video is not ready, then add an event listener
for the "canplay" event and only play() once this is fired. We only do
this once to avoid adding duplicate listeners.

We also check that the video is not playing before calling play(),
because it could still be in playback if we scroll out of view and then
back into view.

* Refactor autoplay-video to match style of similar JS enhancement implementations

* Move autoplay-video from shared/utils to features/

---------

Co-authored-by: Thomas Mees <thomas.mees@overleaf.com>
Co-authored-by: Thomas <thomas-@users.noreply.github.com>
GitOrigin-RevId: 13011af04baaeba4b8053478a09e3e4d7c960d5c
2024-01-29 09:03:51 +00:00
Alf Eaton
fcd5758a7e Remove setSavedAt from detach compile context (#16742)
GitOrigin-RevId: 2a85b4a0cd6b73c0240b64beddd8cd6ab5a48b2f
2024-01-29 09:03:31 +00:00
Alf Eaton
7e718b2a98 Improve handling of upload to deleted folder (#16738)
GitOrigin-RevId: 2ad2890f8fe51f3c7c7a8ac0834059ea9cb0557b
2024-01-29 09:03:23 +00:00
Alf Eaton
eb3204c2cb [ide-react] Preserve scope value update watchers on watcher add (#16729)
GitOrigin-RevId: 1168577364fef6e13a58d7d96afdf4ba685fc342
2024-01-29 09:03:20 +00:00
Alf Eaton
006ebbc293 Remove savedAt from compiler (#16642)
GitOrigin-RevId: 526d26d731da99b40c253a4dc0a774a896641c8e
2024-01-29 09:03:13 +00:00
Alf Eaton
0f3002d34c Store selected project ids separately (#15598)
GitOrigin-RevId: 56a833fb1524362ff6617afa9be4cb7b6c1984c7
2024-01-29 09:03:07 +00:00
Alf Eaton
27172c32b3 Merge pull request #14709 from overleaf/ae-context-typescript
Convert React context providers to TypeScript [don't squash!]

GitOrigin-RevId: d92a91798286978410956ab791d73c17c5086d86
2024-01-29 09:03:04 +00:00
ilkin-overleaf
c67b8a73eb Merge pull request #16662 from overleaf/ii-share-modal-click-2
[web] Share modal select contact

GitOrigin-RevId: e43575cd97ad8e4bca249967bdf0cfc587213cc4
2024-01-26 09:03:42 +00:00
Alf Eaton
590f7fd53b Fix stripe alignment on Recompile button (#16643)
GitOrigin-RevId: 504bc90889e89c62727777eedc81dfa192094e75
2024-01-24 09:04:11 +00:00
Alf Eaton
8ccc55995b Use renderMessage (#16628)
GitOrigin-RevId: 9f627a31d0f8ffce841f04f5a9bfa09f6abcd0a3
2024-01-24 09:04:08 +00:00
Alf Eaton
4e42390ce3 Add event tracking for counts of matched compile log entries (#16615)
GitOrigin-RevId: 65f0efde77db5130cf8a709bb899d3231c3bdec4
2024-01-24 09:04:05 +00:00
David
ba423e8f0f Merge pull request #16608 from overleaf/jpa-writefull-double-loaded
[web] add event for Writefull extension and Overleaf integration enabled

GitOrigin-RevId: d8e65c2f5a868a3221e2dc1765d8ea9986ceff43
2024-01-24 09:03:47 +00:00
Alf Eaton
da6de7bbb2 Add event tracking for log entry source link click (#16600)
GitOrigin-RevId: a4b4a3f5cf4cbf6ac93ef9a8637028726f6cf161
2024-01-24 09:03:31 +00:00
Alf Eaton
3c18c1c3e4 Dispatch 'UNSTABLE_editor:extensions' event on 'editor:extension-loaded' (#16611)
GitOrigin-RevId: a1d93330a7633c6d5870e2c368ab45a4a586db35
2024-01-24 09:03:28 +00:00
M Fahru
befe439eaf Merge pull request #16575 from overleaf/mf-fix-captcha-homepage-website-registration
[web] Attach aborted captcha event handler to body instead of '.content' to fix register flow on homepage website-redesign

GitOrigin-RevId: f3e5b67476fb2584b7b6eec26114f2cc6e00bfdb
2024-01-23 09:03:24 +00:00
David
3f0607a3a3 Merge pull request #16545 from overleaf/dp-project-owner-delete-labels
Allow project owners to delete history labels

GitOrigin-RevId: 16111337681ac4085db2cf48e9d4c2fa87993b77
2024-01-23 09:03:08 +00:00
ilkin-overleaf
9ec16779bb Merge pull request #16509 from overleaf/ii-rp-update-entry-positions
[web] Review panel entry positions and long user names

GitOrigin-RevId: 3a596bd90bab2c87b2efae5eb812ffc5e5a1580f
2024-01-19 09:05:28 +00:00
Alf Eaton
508341bbac Merge pull request #16511 from overleaf/ae-upgrade-uppy
Upgrade Uppy to v3

GitOrigin-RevId: ca3e366a20ac651a98aafe12bf319b1968ac6ec1
2024-01-19 09:05:05 +00:00
Alf Eaton
f54855c47b Add estimated height to some block widget decorations (#16485)
GitOrigin-RevId: f59da18228e038b1295ccc0128a33acd2de4f9f9
2024-01-19 09:05:01 +00:00
Alf Eaton
d611aab777 Extend the size limits of some panels (#16543)
GitOrigin-RevId: 4c25e93effc08c6bf62cdca7e95b31ca36ac154f
2024-01-19 09:04:56 +00:00
Alf Eaton
2cf2aa6fb2 Move Writefull toolbar loading/initialisation into a React component (#16546)
GitOrigin-RevId: 1cb6efa7cab2babb33800fef9469fca3addbdaf5
2024-01-19 09:04:52 +00:00
Mathias Jakobsen
b6e8030a00 Merge pull request #16588 from overleaf/mj-usepackage-fix
[web] Copy single backslash in column width modal

GitOrigin-RevId: ee3e3eadac067dac1d955adc04709e8ab3121a59
2024-01-19 09:04:37 +00:00
Mathias Jakobsen
b02e16e8a6 Merge pull request #16522 from overleaf/mj-table-generator-cypress-tests
[web] Add cypress tests for table generator

GitOrigin-RevId: c77454763cfc83e4869e75ba247369e6255a0553
2024-01-19 09:04:33 +00:00
Mathias Jakobsen
209cb9b57e Merge pull request #16048 from overleaf/mj-table-column-width
[visual] Allow setting column widths in table generator

GitOrigin-RevId: 3bd4bb05dd3b29d0bd62fbc41da45eda282fecf4
2024-01-19 09:04:28 +00:00
Tim Down
77f257c8fa Merge pull request #16569 from overleaf/td-ieee-collabratec-disable-notification
Temporarily remove IEEE Collabratec notification

GitOrigin-RevId: 0b329687240c2169fa51a1244010d71ad864a708
2024-01-18 09:04:57 +00:00
Tim Down
a6277c1950 Merge pull request #16521 from overleaf/td-ieee-collabratec-notification
Add notification and script for IEEE Collabratec users

GitOrigin-RevId: 7f463baa172514d9f1d37f99a02b311b8f925cd8
2024-01-18 09:04:44 +00:00
David
6e1338a533 Merge pull request #16523 from overleaf/dp-editable-file-extensions-2
Make cfg, ltx, Rnw and inc files editable in the editor

GitOrigin-RevId: 1999c29ea451aa3f362ffa09f6f4d5889beaf404
2024-01-17 09:03:53 +00:00
ilkin-overleaf
03cb24776f Merge pull request #16493 from overleaf/ii-rp-mini-page-load
[web] Prevent opening and closing of the mini review panel

GitOrigin-RevId: 25297a24ddfb2654b00efa8d33b825620f859147
2024-01-17 09:03:17 +00:00
David
1424b35e52 Merge pull request #16456 from overleaf/dp-trask-project-link
Update help article links for archiving and trashing projects

GitOrigin-RevId: 3be4e3bdab89e8f85182ad421d9641222f3eb99e
2024-01-16 09:04:29 +00:00
Thomas
5d203b5788 Merge pull request #15710 from overleaf/tm-no-constant-binary-expressions
Add no-constant-binary-expression, fix existing expressions that have no effect

GitOrigin-RevId: 6691e87181331ecbb5dabfda0be89839a0a4884b
2024-01-16 09:04:09 +00:00
Domagoj Kriskovic
292f6fa7aa Wait for "doc:saved" event before compiling (#16153)
* wait doc:saved before compiling

* Refactor DocumentCompiler class to handle pending operations before compilation

* add timeout for pending op

* Increase PENDING_OP_MAX_WAIT to 10000 milliseconds

* check if currentDoc exists

* check doc id on doc:saved

* Fix conditional statement

* Refactor to add and remove event listeners for doc:saved event

* check if getPendingOp exists

* typeof getPendingOp

* forgot to push updates

* add flush-changes event

* use promise for handling pending operations

* Remove console.logs

* add isAwaitingBufferedOps

* Revert "add isAwaitingBufferedOps"

This reverts commit 56b0bbc13caf6375d1cf50e8f65f599e7263c404.

* move _awaitBufferedOps in try block

* dont check for matching doc id

* add a todo comment

GitOrigin-RevId: 9225e7d1a7a69385dc1a26bf7663f89f59db6a8a
2024-01-16 09:04:05 +00:00
Domagoj Kriskovic
3be3212129 [visual] Skip moving cursor inside argument if there is no decoration (#16365)
* [visual] Skip moving cursor inside argument if there is no decoration

* Refactor skipAtomicRanges function

* rangeSet outside the loop, continue rather than return

* use rangeSet.between

* prettier

GitOrigin-RevId: 85ef817e09ea7eb854cec43cb7866f61b4bfbc21
2024-01-16 09:03:59 +00:00
Alf Eaton
28e2c9c422 Allow Shift-click to select a range of items in the file tree (#15147)
GitOrigin-RevId: 4651b5d094c45fb8a7447d1f3439c2f6b3578403
2024-01-15 09:04:36 +00:00
ilkin-overleaf
be8c01361d Merge pull request #16453 from overleaf/ii-review-panel-dismiss-bulk-actions
[web] Fix bulk actions in review panel

GitOrigin-RevId: c78c99b0a3b005a0a4490ce393eb5d540f23ebc2
2024-01-15 09:04:31 +00:00
Alf Eaton
f02bc7dc1b Update the CodeMirror language when the current file is renamed (#16342)
GitOrigin-RevId: 8b51df0d1acfeeb8b0323cebf6de78572c8cb95c
2024-01-15 09:04:27 +00:00
Alf Eaton
2e7bc74faa [visual] Decorate \ce command (#16459)
GitOrigin-RevId: 0eab030489f97e43874e41d6d4895dc4de46521a
2024-01-15 09:04:08 +00:00
David
b5b62b4b41 Merge pull request #16437 from overleaf/dp-remove-visual-editor-feedback-icon
Remove visual editor feedback badge

GitOrigin-RevId: c84cc7b6630642853848fad46695bff6ae2a990a
2024-01-12 09:03:19 +00:00
Davinder Singh
f562420bf1 Spacing fix on welcome page (#16382)
* adding a margin of 0

* adding a padding bottom to the welcome page component

* adding a padding bottom of 25px to project-list-welcome-wrapper

* adding container class to fix two issues together

* adding px-0

* adding mx-0

GitOrigin-RevId: 043173d93d705acd92ad1ebe47bda0f3552ded1a
2024-01-11 09:04:40 +00:00
Alf Eaton
fd4b9a6c67 Fix React scope event listener (#16434)
GitOrigin-RevId: 1846ad511f915ff48f2f20a8b8a7f1174bb21525
2024-01-10 09:03:05 +00:00
Miguel Serrano
a2a7686347 Merge pull request #15946 from overleaf/msm-new-notification-others
[web] new notification style for dashboard alerts

GitOrigin-RevId: cf5bea32a89f35d63ca4bdc2df2619352d421ff3
2024-01-09 09:03:55 +00:00
Alf Eaton
e559a64ac2 Throttle PDF.js resize listener (#16402)
GitOrigin-RevId: 5c1498d21197b09865930e1b2deff049022d2d17
2024-01-09 09:03:49 +00:00
Alf Eaton
6d5972584f Expose ScopeValueStore via window.overleaf.unstable.store (#16404)
GitOrigin-RevId: 4b251639296405c0a9487f063e8b049687860004
2024-01-09 09:03:46 +00:00
Alf Eaton
4fd63fa7cb Fix load metadata (#16417)
GitOrigin-RevId: 26505e08ca9074238253dba08d0380422ae859be
2024-01-09 09:03:43 +00:00
Domagoj Kriskovic
510fdb1f39 Show argument completions even if it has more than 245 chars (#16352)
* Show argument completions even if it has more than 255 chars

* use tokenBefore for existingKeys

* use 'ShortArg' token so braces are escaped

* refactor argument completion logic

* remove extra filter

* Add makeMultipleArgumentCompletionSource for arguments with multiple keys

* revert makeArgumentCompletionSource

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: f5aa70fe5e58e04efe0c4e8668957f61a7fa7911
2024-01-09 09:03:40 +00:00
David
a7ce744de0 Merge pull request #16409 from overleaf/dp-fix-group-pricing-after-back-button-pressed
Update group plan pricing modal after the page has fully loaded

GitOrigin-RevId: 03e2ea642b38d6e2e208683b0cb68a817a5873c8
2024-01-09 09:03:33 +00:00
Jimmy Domagala-Tang
a5e7bc6791 Merge pull request #16419 from overleaf/jdt-fix-grammarly-offer-link
fix the grammarly offer id

GitOrigin-RevId: 996501ebb50b64bd8f9bd46305ba47baa37fee88
2024-01-08 09:05:45 +00:00
Jimmy Domagala-Tang
e771254081 Merge pull request #16319 from overleaf/jdt-grammarly-ad-redesign
Grammarly Ad redesign

GitOrigin-RevId: 28d0ae871b6303b31aadb59abc80b625d529cc9b
2024-01-08 09:05:40 +00:00
Alf Eaton
0087dce832 Replace strict-event-emitter with EventTarget (#16374)
GitOrigin-RevId: 3b0afc3cd7bf3d11f35a3de23cb94061d2d6c69b
2024-01-08 09:05:22 +00:00
Alf Eaton
8588d15426 Recalculate toolbar overflow when buttons change (#16350)
GitOrigin-RevId: 70ab356172bc57630b6032a6400fb08e8fd33464
2024-01-08 09:05:17 +00:00