Commit Graph

693 Commits

Author SHA1 Message Date
Jessica Lawshe fb4e5684a3 Merge pull request #11132 from overleaf/jel-btn-info
[web] Use new button style for download button in file view in editor

GitOrigin-RevId: 33e8c1aeb21a6ba083a5b9ada3d3135916e64e26
2023-01-12 09:03:43 +00:00
M Fahru 2e37df1515 perform null check on the old value instead of the new one since to follow the non-react version behaviour
GitOrigin-RevId: 33ef74e1b1da41db8a86fc79ae04fbe49ed194df
2023-01-11 09:10:00 +00:00
M Fahru 235e6e4d6e Log error in a promise catch block
GitOrigin-RevId: 09756d52bd6351c55051a74f22f38c450af9a275
2023-01-11 09:09:51 +00:00
M Fahru b1b22b8f5b Refactor project-wide settings:
- Change api function argument (readability)
- create a new wrapper hooks for saving the project to both server-side and angular scope
- Implement the new save project settings hooks on project-wide settings update
- On spell check language update function, add new comment to give more context about the decision

GitOrigin-RevId: 93d558d1e1d4db265a943eeb4366842430900c43
2023-01-11 09:09:40 +00:00
M Fahru daf5cdd079 Refactor saveUserSettings: Move sendMB inside the function and change function from supporting multiple settings to only support single key/value pair.
GitOrigin-RevId: 77b9d8fd5cdcbc78f38fd42329b74cf592615638
2023-01-11 09:09:32 +00:00
M Fahru 53d74045bb fix tsc error by re-creating request body object instead of directly assigning it from function argument
GitOrigin-RevId: b17697c7b52c991a06efcbffa0227b6021c5bc8d
2023-01-11 09:09:25 +00:00
M Fahru f9eab58bc8 Remove scope suffix from variable name in react-related files since it's an angular-specific concept
GitOrigin-RevId: b8eea8c8113a977f6cbe07649e1338eea8281841
2023-01-11 09:09:18 +00:00
M Fahru 1f1bfe297a Remove _csrf in request body since fetchJSON already have X-Csrf-Token set in request header
GitOrigin-RevId: 9dd2389c47ce3537fc4bb22bd8b6b0b83862c5f4
2023-01-11 09:09:11 +00:00
M Fahru b06087d700 standardize the naming for rootDocId.
- Remove the `scope` variable suffix
- change `rootDoc_id` to `rootDocId`

GitOrigin-RevId: d8e646ef5f99ba0dbce84ff63c588e63b956a4ec
2023-01-11 09:09:04 +00:00
M Fahru a0e3a13c2e Change import to import type for type imports
GitOrigin-RevId: 2061bafeca58d063f83a96650403e5741b863c05
2023-01-11 09:08:57 +00:00
M Fahru 0723822151 Fix linter error because of wrong variable name and camel case issue
GitOrigin-RevId: a5ea8d6c8332133303fcd8e410cc76ac06c5bb97
2023-01-11 09:08:49 +00:00
M Fahru 77f157a241 Remove multiple source of type imports; add type on type imports.
GitOrigin-RevId: a6630bb284c456bfbe61901f7331cdd3c13c7f8b
2023-01-11 09:08:42 +00:00
M Fahru 3a0ec888e9 Simplify function by removing generic
GitOrigin-RevId: 7732b6782cd1e0130eb56f6b674c03548b8e8315
2023-01-11 09:08:35 +00:00
M Fahru 14068b977f Fix wrong hook name
GitOrigin-RevId: 58f98b508cf650a6ecab38772faf9ecd38c9a7bc
2023-01-11 09:08:28 +00:00
M Fahru 304d73a0c0 Refactor type by reusing type declaration and avoid multiple source of the same type
GitOrigin-RevId: 492a9a524e566cf70b53158b4e5cc6ad57cb6093
2023-01-11 09:08:21 +00:00
M Fahru c7f65fb7d7 Remove disabling update while listening on socket (ignoreUpdates state) since the logic is more complicated that was originally thought and it will be tested/revisited on a different PR
GitOrigin-RevId: 70cee2f0fc565aaebfb3ead2dd1a58fc5371c816
2023-01-11 09:08:13 +00:00
M Fahru afb179b286 Disable updating project-wide settings while socket is currently listening to update project-wide settings in a project.
This may happen if the project is being used by multiple people, and we want to avoid race condition on the update since it's possible for multiple people to update setting value at the same time.

GitOrigin-RevId: cdad6a6456e2d9e4ef1812ebfd6f6ef59f23747f
2023-01-11 09:08:06 +00:00
M Fahru 9ee7282139 refactor function by simplifying function argument (from two arguments to a single object)
GitOrigin-RevId: e4244a07a4ca196afa226e3fac9de74d30f7d4ea
2023-01-11 09:07:59 +00:00
M Fahru 12eb9aa22c Don't send spellCheckLanguage request if the old value is the same as the new one
GitOrigin-RevId: 4ef34be7563ff707b6abd44dc8034293c88d2f72
2023-01-11 09:07:52 +00:00
M Fahru a0a97a40a7 Add 'setting-changed' tracking when user changes user-wide settings
GitOrigin-RevId: 04ed66dcdff7fa04e783fe4028505d981a39b37b
2023-01-11 09:07:45 +00:00
M Fahru 197c69f687 Apply prettier
GitOrigin-RevId: 34c7e3b95d061c270c77337c7c82502af289b556
2023-01-11 09:07:38 +00:00
M Fahru 03a8227ac8 Add a comment explaining why user settings may be undefined
GitOrigin-RevId: 4460d4184cde5639d326da07121b2728d444c782
2023-01-11 09:07:30 +00:00
M Fahru 9f7ca368dd Fix numerous test fails because of unitialized user settings scope on the test environment
GitOrigin-RevId: a27454285b0c89c6abef560f05c52d35f81fa570
2023-01-11 09:07:23 +00:00
M Fahru 53bb3c490e Save spellCheckLanguage to both project-wide and user-wide setting
GitOrigin-RevId: 059cc64d0fe2e955814a7192f82d4ff8ea4e2572
2023-01-11 09:07:16 +00:00
M Fahru 9ed84016eb Fix tsc lint error by restricting the generic type
GitOrigin-RevId: 11ef7ab4111c7b312b283283829e9b28a80c475c
2023-01-11 09:07:09 +00:00
M Fahru bdb6007c0c Add socket listener for compiler, imageName, and spellCheckLanguage
GitOrigin-RevId: b12644152387e479e433a014e1a1041ebae36f12
2023-01-11 09:07:02 +00:00
M Fahru 1b9de46f37 Rename "rootDoc_id" to "rootDocId" before sending it to server
GitOrigin-RevId: fc29e152ffd3bf97c00ee817abb07086f6cdfe17
2023-01-11 09:06:54 +00:00
M Fahru b1068e5dec Add _csrf to request body
GitOrigin-RevId: 87b5a7299fbb795618143421df79375b41f8f921
2023-01-11 09:06:47 +00:00
M Fahru 0d5f5ed59f replace save project setting hooks with common function and implement set root doc id change
GitOrigin-RevId: e5b204cd93fc188288def529cb22018b3d4f89b6
2023-01-11 09:06:40 +00:00
M Fahru 5962b13ac7 apply prettier
GitOrigin-RevId: dd750756d2bfc625817760510e9bdbade186aef3
2023-01-11 09:06:33 +00:00
M Fahru 97f93ab9d5 Change variable declaration location + apply prettier
GitOrigin-RevId: 3237a417c23d5c66c47385e55f8d3cb68bdfc3ca
2023-01-11 09:06:26 +00:00
M Fahru f183848bbb Reduce save/setScope user setting duplication by introducing a new shared hooks
GitOrigin-RevId: 6054143eb042e4ff336b1f325a8cef693ae8c4bd
2023-01-11 09:06:19 +00:00
M Fahru eec3b11f34 Migrate updating overallTheme to react
GitOrigin-RevId: 024ceb3c32c8d90ac0067fbb72d6e7d327b869f0
2023-01-11 09:06:12 +00:00
M Fahru 132c5e956d migrate user-wide settings post request from angular controller to react
GitOrigin-RevId: b5440178a11b82c5a5840eb310416f1519f85bae
2023-01-11 09:05:57 +00:00
M Fahru c6e25d85f7 Migrate editor settings controller to react (this commit includes project-wide settings)
GitOrigin-RevId: 8c47a2699a2f11fda7fd60c5173bf2e29858e37a
2023-01-11 09:05:50 +00:00
M Fahru 8668e81c3f Fix firefox bug where user can't focus on input while renaming file on editor file tree (#11134)
GitOrigin-RevId: daebbe6df4a3fef41cbf25444a31015d306901b3
2023-01-11 09:05:43 +00:00
M Fahru 32e0411456 Conform with new design system by changing btn-default to btn-secondary (#10972)
GitOrigin-RevId: 1fac39d3b1e7e68e6feffe467ac21b4cb3253353
2023-01-11 09:05:36 +00:00
Jessica Lawshe c146c12d5c Merge pull request #11078 from overleaf/jel-features-page-analytics
[web] Add analytics to React dash features link

GitOrigin-RevId: 5f62af1af3854b1443734cda6b97334e6eb42711
2023-01-10 09:06:43 +00:00
Jessica Lawshe c0eb059a05 Merge pull request #10958 from overleaf/jel-features-page-link
[web] Update features page link on dash for split test

GitOrigin-RevId: 5b51700a8a4ca89920288b54e08caf88f29dec96
2023-01-10 09:06:36 +00:00
Jessica Lawshe f4962a807a Merge pull request #11092 from overleaf/jel-recompile-btn
[web] Add `data-ol-loading` button style

GitOrigin-RevId: 75230fee0e4c1183f389d08b0253402e4fc375b0
2023-01-10 09:06:28 +00:00
ilkin-overleaf 0b4d469354 Merge pull request #9536 from overleaf/ii-adjustable-project-dashboard-panel
[web] Adjustable project dashboard sidebar

GitOrigin-RevId: 1007ecb896bbe215af28fa92d295201b2457aeef
2023-01-10 09:05:44 +00:00
ilkin-overleaf 4f9f845b57 Merge pull request #11074 from overleaf/ii-tagged-trashed-projects
[web] Project dashboard archived and trashed projects appearing not hiding

GitOrigin-RevId: b323be2a1104af54d3af9c9610b584fc0ab24c10
2023-01-10 09:05:28 +00:00
Mathias Jakobsen b7c6cb51f6 Merge pull request #11016 from overleaf/ii-dashboard-wrong-action-buttons
[web] Project dashboard wrong action buttons

GitOrigin-RevId: d76c64616a34c63b60bc499b96c6507c1196e666
2023-01-05 09:04:45 +00:00
Mathias Jakobsen 0dc67a7ed9 Merge pull request #10793 from overleaf/mj-split-test-cleanup
Split test clean-up

GitOrigin-RevId: 7dd6178487022cbefcbc85797dacc3f3fbfa17e2
2022-12-21 09:04:04 +00:00
Davinder Singh c4d784f6e7 Merge pull request #10922 from overleaf/ds-remove-classNames
Removing `classNames` function from setting page widgets component

GitOrigin-RevId: df15640996d0b2dea691cab07ebbfc687b8e3f3f
2022-12-19 09:04:25 +00:00
Davinder Singh 331884824f Merge pull request #10844 from overleaf/ds-editor-btn-info-to-secondary
Replacing `btn-info` with `btn-secondary-info btn-secondary` in the editor

GitOrigin-RevId: 1e348b0b09bfd08508a3dbee7df882f41fdc16eb
2022-12-19 09:04:17 +00:00
M Fahru 6117f08501 Implement groups & enterprise awareness banner on project dashboard (#10818)
- Implement the banner on both react and non-react project dashboard
- Use split test with 4 different variants, `save`, `empower`, `did-you-know`, and `default`, each variant has a different copy, except the `default` which won't show the banner to users

GitOrigin-RevId: ee76769dfd38b8e52de8cc0f201c24e41905d016
2022-12-13 09:05:08 +00:00
Alf Eaton 0ae1a8facc Add rich-text mode to CM6 (#10775)
Co-Authored-By: Mathias Jakobsen <3295293+hrjakobsen@users.noreply.github.com>
GitOrigin-RevId: 00e015cb216bb8a52d083e71b34dbe91a7cd6cc5
2022-12-13 09:03:54 +00:00
June Kelly 60fa598617 Merge pull request #10675 from overleaf/mj-wiki-search-submit
[web] Ignore submit event on wiki search form

GitOrigin-RevId: aa1bc4898b9656bed9e2aeb4c0deef7e4a36383f
2022-12-12 09:03:38 +00:00
June Kelly 3cbf1159f4 Merge pull request #10821 from overleaf/jk-fix-pdfjs-comments
[web] Fix pdfJS `imageResourcesPath`, missing `/` at end of URL

GitOrigin-RevId: a2488f90d89b7693f0ecdd688835e9cac028cc34
2022-12-12 09:03:31 +00:00