Jakob Ackermann
6cbacc8cb7
[web] fetch project once for joinProject ( #25667 )
...
* [web] fetch project once for joinProject
* [web] await all the nested helpers for getting privilege levels
Co-authored-by: Mathias Jakobsen <mathias.jakobsen@overleaf.com >
---------
Co-authored-by: Mathias Jakobsen <mathias.jakobsen@overleaf.com >
GitOrigin-RevId: f0280c36ef995b417ccdab15014f05954e18c5f0
2025-06-03 08:06:13 +00:00
Miguel Serrano
8ff8e7a4bf
Merge pull request #23006 from overleaf/msm-chat-capabilities-poc-2
...
[web] Add option to disable chat for subscription
GitOrigin-RevId: 0052d060c74c39400496f7f9f54c820398d60012
2025-01-31 09:05:18 +00:00
Domagoj Kriskovic
ff9ee2f5a9
Use "can write or review project content" authorization middleware ( #23111 )
...
GitOrigin-RevId: c5d1cb955e5833347f7e0c3610c5b8d768026478
2025-01-29 09:05:33 +00:00
Domagoj Kriskovic
09195a9b5d
Allow reviewers to reopen comment threads ( #23075 )
...
GitOrigin-RevId: 065acf5931213c288dbdcb3bc06da988b094a1f4
2025-01-27 09:05:10 +00:00
Domagoj Kriskovic
7e5a0a9bea
Delete unused canUserReviewProjectContent function ( #23073 )
...
GitOrigin-RevId: 5c2e17a44623916e494a24bf18dbff4e846734d3
2025-01-27 09:05:02 +00:00
Domagoj Kriskovic
48d08f5b28
Allow reviewers to delete their own comment threads ( #23044 )
...
GitOrigin-RevId: 2165e0f549c9df923fb1c124a7622a49d579c2e3
2025-01-24 09:05:35 +00:00
Domagoj Kriskovic
741b65d0eb
Add ensureUserCanSendComment authorization middleware ( #22959 )
...
* Add ensureUserCanSendComment authorization middleware
* added tests
GitOrigin-RevId: d1f58bd6bc63275456e5280ccb8c99aaa02c4e5f
2025-01-21 09:05:53 +00:00
Domagoj Kriskovic
30ebad91b7
Allow reviewers to resolve their own comments ( #22582 )
...
* Allow reviewers to resolve their own comments
* check if reviewer is comment author
* add missing translation
* add CommentsController tests
* added DocumentManagerTests
* added HttpControllerTests
* Add AuthorizationManagerTests
* added AuthorizationMiddlewareTests
* added DocumentUpdaterHandler test
* fix test descriptions
* remove returns from CommentsControllerTests
* use ensureUserCanResolveThread in authorizationMiddleware
* move canResolveThread to AuthorizationManager
* commentId as param in NotFoundError
* refactor canUserResolveThread
GitOrigin-RevId: 131c3d1eb9ac916eaaa9221d351a92bc07b80cdc
2025-01-14 09:05:11 +00:00
Domagoj Kriskovic
f39ca200b9
Support for adding reviewer role ( #22314 )
...
* Support for adding reviewer role
* added collaboratorsGetter tests
* emit toggle-track-changes when reviewer is added
GitOrigin-RevId: 5b831102d561f5dbc4b23ab9f6dc63e3a87ea103
2024-12-10 09:04:47 +00:00
Domagoj Kriskovic
511fe60a9c
Revert "Support for adding reviewer role ( #22137 )" ( #22293 )
...
This reverts commit 54064a7f961fe06f188ab449cd469cdaaf01b20a.
GitOrigin-RevId: 1dabc635756aff465d2fe9aa0d18121b081df3b0
2024-12-04 09:05:12 +00:00
Domagoj Kriskovic
f676eca2b8
Support for adding reviewer role ( #22137 )
...
* Support for adding reviewer role
* show reviewer in track changes user list
* added "review" in assertClientCanViewProject
* test if reviewer can read project
* added collaboratorsGetter tests
* eit toggle-track-changes when track changes changes
* Support for changing privilege to reviewers for invited users (#22159 )
* Add reviewer in change privilege level handler
* added reviewer translation
* added acceptance tests
* fix tests
* Set track changes state permissions for reviewer role (#22167 )
* Add reviewer in change privilege level handler
* added reviewer translation
* added acceptance tests
* fix tests
* Set track changes state permissions for reviewer role
* added authorization helper tests
* added ensureUserCanReviewProjectContent middleware
* allow changing track changes only with write permissions
* removed canUserReviewProjectContent
* List projects where user is added as a reviewer (#22249 )
* List projects where user is added as reviewer
* list projects in /user/projects
* fix tests
GitOrigin-RevId: 54064a7f961fe06f188ab449cd469cdaaf01b20a
2024-12-04 09:05:00 +00:00
andrew rumble
032deaf05c
Switch to mongodb-legacy
...
GitOrigin-RevId: 11e09528c153de6b7766d18c3c90d94962190371
2024-08-21 08:04:24 +00:00
Jimmy Domagala-Tang
918c3e7e33
Merge pull request #19301 from overleaf/jdt-collaborator-ai-usage
...
Prevent AI usage on projects where collaborators have a blocking policy
GitOrigin-RevId: 93bdd9c5accff51a14f0585249e13ed7f1fa4e53
2024-07-26 08:04:35 +00:00
Liangjun Song
f4a7b1f298
bypass linking sharing admin redirect for internal projects ( #19314 )
...
* disable linking sharing admin redirect
* address comments
* remove ignoreSiteAdmin
* load admin domains from settings
* add acceptance test
* more tests
* fix tests and restore admin domain
* use adminDomains as array
GitOrigin-RevId: 5acb62e1b6ada0aaeceab6db6a6635f82e30833f
2024-07-16 08:04:35 +00:00
Jimmy Domagala-Tang
f77894c427
Merge pull request #19238 from overleaf/jdt-use-ai-project-fix
...
feat: matching rename to checkPermissions within projectController
GitOrigin-RevId: ea05800c145858237fb0b236f9a19837c6c4a9a2
2024-07-03 08:04:36 +00:00
Jimmy Domagala-Tang
007cc42477
Merge pull request #19152 from overleaf/jdt-project-permissions
...
Allow checking permissions for all users on a project and rename checkPermissions -> AssertPermissions
GitOrigin-RevId: 511356cf2fe68367e284347e68e59f6116bd0f80
2024-07-03 08:04:19 +00:00
Jimmy Domagala-Tang
271700893a
Merge pull request #18784 from overleaf/bg-allow-combined-group-policies
...
allow combined group policies
GitOrigin-RevId: b23fb0454f794e9094e8e15e732b4322a48ac1ee
2024-06-24 12:04:13 +00:00
Antoine Clausse
36f0a3e01a
[web] Promisify ProjectController ( #18477 )
...
* Create `promiseAuto` util to replace `async.auto`
* Promisify `BrandVariationsHandler.getBrandVariationById`
* Promisify `updateProjectSettings`
* Promisify `updateProjectAdminSettings`
* Promisify `newProject`
* Promisify `deleteProject`
* Promisify `loadEditor`
* Fix brandVariation loading in promise auto
* Promisify `_refreshFeatures`
* Promisify `_injectProjectUsers`
* Fix `no-inner-declarations`
* Promisify `cloneProject`
* Promisify `userProjectsJson`
* Promisify `projectEntitiesJson`
* Promisify `restoreProject`
* Promisify `renameProject`
* Additional warning fix
* Update unit tests
* Fixup `updateProjectSettings`: call jobs inside the Promise.all
* Use `expressify(...)` instead of manually call `next(err)`
https://github.com/overleaf/internal/pull/18477#discussion_r1613611987
https://github.com/overleaf/internal/pull/18477#discussion_r1613621146
https://github.com/overleaf/internal/pull/18477#discussion_r1613634000
...
* Replace Promise.all by sequencial awaits
https://github.com/overleaf/internal/pull/18477#discussion_r1613852746
https://github.com/overleaf/internal/pull/18477#discussion_r1613611987
* Remove manual throws of 500. Let the generic error handler catch them.
https://github.com/overleaf/internal/pull/18477#discussion_r1613623446
https://github.com/overleaf/internal/pull/18477#discussion_r1613628955
* Promisify `untrashProject`
https://github.com/overleaf/internal/pull/18477#discussion_r1613627783
* Promisify `expireDeletedProjectsAfterDuration`
* Promisify `archiveProject`
* Promisify `unarchiveProject`
* Promisify `trashProject`
* Promisify `expireDeletedProject`
* Use async `setTimeout` from `timers/promise`
https://github.com/overleaf/internal/pull/18477#discussion_r1613843085
* Remove unused `_injectProjectUsers`
https://github.com/overleaf/internal/pull/18477#discussion_r1613855766
* Add missing exec in queries (?)
Not sure if that makes a real difference but it's more consistent with the rest of the code
* Catch floating promises
https://github.com/overleaf/internal/pull/18477#discussion_r1613868876
* Replace custom `promiseAuto` by `p-props` from NPM
https://github.com/overleaf/internal/pull/18477#discussion_r1613393294
* Downgrade `p-props` to v4. Later versions require ESM
* Simplify code around `splitTestAssignments`
GitOrigin-RevId: 84d37f7aa9227b5b9acf9eeb5db1b78afc01b6ee
2024-05-30 08:04:36 +00:00
Miguel Serrano
02d890ef18
Merge pull request #17426 from overleaf/msm-expressify-controllers
...
[web] Expressify controller methods
GitOrigin-RevId: 9784176b53a89beed09f9b38915872a6e7fae465
2024-03-12 09:03:26 +00:00
Jessica Lawshe
cb3f70f7ab
Merge pull request #17289 from overleaf/jel-permissions-controller
...
[web] Move user permissions check to manager
GitOrigin-RevId: 8c59d053da3d8d452cd424b04baa05f5d7d9057a
2024-02-29 09:04:37 +00:00
Brian Gough
ec923c2144
Merge pull request #16194 from overleaf/bg-group-sso-fix-default-permission-check
...
fix default permission check for group sso
GitOrigin-RevId: b78c3dd26d852822f06c44c2aef79daea36fc2bd
2023-12-14 09:03:16 +00:00
Brian Gough
1ff830027f
Merge pull request #15726 from overleaf/ab-managed-users-module-cleanup
...
[web] Managed users / Group SSO module cleanup
GitOrigin-RevId: a24d3278667059248d9563afe44cafca5f87a7c0
2023-11-21 09:03:54 +00:00
Alexandre Bourdin
e322f4a31f
Merge pull request #15418 from overleaf/ds-managedUsersEnabled
...
Managed users - Adding a managedUsersEnabled flag on subscription model
GitOrigin-RevId: a03dd169ba71255dd1bec5f7bee8ce9609d95a2f
2023-11-03 09:00:26 +00:00
Eric Mc Sween
680ebae30b
Merge pull request #15172 from overleaf/em-promise-utils
...
Move util/promises from web into a shared library
GitOrigin-RevId: fe1980dc57b9dc8ce86fa1fad6a8a817e9505b3d
2023-10-20 08:04:05 +00:00
Brian Gough
d2f470450e
Merge pull request #13933 from overleaf/bg-managed-users-add-missing-jsdoc-param
...
refactor getUserValidationStatus in PermissionsManager
GitOrigin-RevId: 80ef8142d3556e47e1d6cb323148f1f1042057aa
2023-07-21 08:04:40 +00:00
Brian Gough
f3ac016566
Merge pull request #13907 from overleaf/bg-managed-users-allow-cancelled-subscriptions
...
allow cancelled subscriptions for managed users
GitOrigin-RevId: 56262ce4bd4cc93d4e5ea92222c76a874d6cad1e
2023-07-20 08:05:08 +00:00
June Kelly
bf92436e6f
Merge pull request #13505 from overleaf/bg-group-policy-meta-tags
...
hide restricted elements for managed users on settings page
GitOrigin-RevId: be8679957eb5185d8b91d29e5a787c837684c314
2023-07-17 11:10:46 +00:00
Brian Gough
f80100fba1
Merge pull request #13662 from overleaf/bg-managed-users-fix-subscription-validator
...
fix subscription validator for managed users
GitOrigin-RevId: 765c1c11850090f57327fc8b4255d41a16514472
2023-07-17 11:01:27 +00:00
Davinder Singh
9e8e124113
Merge pull request #13591 from overleaf/ab-account-enrollment
...
[web] Managed users - account enrollment
GitOrigin-RevId: 6fc9ef8c44394eb92d3afd2022433b0b6d508503
2023-07-17 10:59:02 +00:00
Brian Gough
bc3d6c3636
Merge pull request #13717 from overleaf/bg-managed-users-block-affiliations-fix
...
fix for block affiliations for managed users
GitOrigin-RevId: cac54288592323ea3f1cd7655d4e2b89ee301002
2023-07-17 10:58:38 +00:00
Brian Gough
a68518dd35
Merge pull request #13694 from overleaf/revert-13584-bg-managed-users-block-delete-own-account
...
Revert "block account deletion by managed users"
GitOrigin-RevId: ece8024b2fac16066abd36af9a9670ba483b3628
2023-07-17 10:52:53 +00:00
Brian Gough
48947f5e8a
Merge pull request #13584 from overleaf/bg-managed-users-block-delete-own-account
...
block account deletion by managed users
GitOrigin-RevId: 895e5e31951bf60cfade4cf7acc3ef330df214e6
2023-07-17 10:52:44 +00:00
Brian Gough
f0420000c5
Merge pull request #13583 from overleaf/bg-add-permissions-middleware
...
add permissions middleware for managed users
GitOrigin-RevId: debd2398a3b75ce71023463ad3c0781750983b53
2023-07-17 10:51:52 +00:00
Brian Gough
8cca5d3316
Merge pull request #13366 from overleaf/bg-group-policy
...
Add permission system for managed users
GitOrigin-RevId: 9d7b38c594cc77204dbee22c92263d002fc8778f
2023-07-17 10:39:38 +00:00
Jakob Ackermann
915914840a
Merge pull request #13083 from overleaf/ds-jpa-project-ownership-change
...
[web] let invited admins transfer ownership of projects
GitOrigin-RevId: 49da7d42bec089f2278bde8942a63e5538fb5401
2023-05-16 08:05:22 +00:00
June Kelly
ac83dd9bb3
Merge pull request #11353 from overleaf/jk-remove-deprecated-public-access-levels
...
[web] Disallow deprecated access levels from being set
GitOrigin-RevId: cf276e849692be210a2dc7d896820579efc46952
2023-02-02 09:02:59 +00:00
Mathias Jakobsen
b5e2604041
[web] Upgrade restricted user access if they are invited members ( #9401 )
...
* [web] Upgrade restricted user access if they are invited members
Previously, if a user joined a project via a read-only link and later on
joined the project via an invite, we would still treat them as
restricted users, disabling chat and commenting. This patch changes
that, so that we do *not* consider an invited user restricted.
GitOrigin-RevId: e2acdfd29cc0687cb7276310a9c96d697087b21a
2022-09-28 08:06:44 +00:00
Timothée Alby
7f722a006c
Merge pull request #8571 from overleaf/ta-token-access-page
...
Require User Interaction on Token Access Page
GitOrigin-RevId: 2f4c00ba75ebd6bd87d3e770ec8223d736344f5b
2022-07-29 08:03:39 +00:00
Eric Mc Sween
e0d91eaa26
Merge pull request #7906 from overleaf/em-downgrade-logs
...
Downgrade all INFO logs to DEBUG
GitOrigin-RevId: 05ed582ef0721fcada059f0ad158565f50feca27
2022-05-17 08:05:26 +00:00
Jakob Ackermann
4d18dcb377
Merge pull request #7210 from overleaf/jpa-switch-to-admin
...
[web] add a button for switching to the admin domain from www.
GitOrigin-RevId: 7e14b9c1415ef6cad5f369d77530599bac3148e7
2022-04-05 12:19:00 +00:00
Jakob Ackermann
c8866bbda0
Merge pull request #7094 from overleaf/jpa-redirect-admin-requests
...
[web] redirect admin users from admin endpoints to the admin domain
GitOrigin-RevId: a4bd7d4f998615efcb46ae9866868af9489c94f5
2022-04-05 12:18:51 +00:00
Jakob Ackermann
e82a053c85
Merge pull request #6614 from overleaf/jpa-msm-separate-admin-app
...
[misc] move admin capability from www. to admin. subdomain
GitOrigin-RevId: e0daeacf3c06b856ffb9fd35dce76e71f14e8459
2022-04-05 12:18:24 +00:00
Alf Eaton
50df230846
[web] Upgrade Prettier to match version in monorepo root ( #6231 )
...
GitOrigin-RevId: 02f97af1b9704782eee77a0b7dfc477ada23e34d
2022-01-11 09:03:23 +00:00
Eric Mc Sween
5fc6d7dcb3
Merge pull request #5740 from overleaf/em-gcp-logging-web
...
Improve GCP logging for web
GitOrigin-RevId: b304c87a3fe46c29189f665eb3daf22c23d6eb8f
2021-11-11 09:03:09 +00:00
Eric Mc Sween
e5676a9643
Merge pull request #5648 from overleaf/em-revert-gcp-logging-web
...
Revert "Improve GCP logging for web"
GitOrigin-RevId: 92d446baf62108da1df92146eec12a2fe69d30ee
2021-11-02 09:03:29 +00:00
Eric Mc Sween
641b10cceb
Merge pull request #5632 from overleaf/em-gcp-logging-web
...
Improve GCP logging for web
GitOrigin-RevId: 1198fab2e821a55563058171cfa435605216e337
2021-11-02 09:03:22 +00:00
Eric Mc Sween
a10c042e20
Merge pull request #4947 from overleaf/em-project-rename-for-owners-only
...
Prevent collaborators from renaming a project
GitOrigin-RevId: 94d12e25592fea55b84427aeae78f7bb2a544a58
2021-09-14 08:03:38 +00:00
Alexandre Bourdin
9468e5cb4f
Merge pull request #4338 from overleaf/ab-session-manager
...
Extract functions from AuthenticationController to SessionManager
GitOrigin-RevId: 86870ce03a762e1a837dcf493759e8851e759883
2021-07-28 12:36:22 +00:00
Alf Eaton
1be43911b4
Merge pull request #3942 from overleaf/prettier-trailing-comma
...
Set Prettier's "trailingComma" setting to "es5"
GitOrigin-RevId: 9f14150511929a855b27467ad17be6ab262fe5d5
2021-04-28 02:10:01 +00:00
Alf Eaton
1ebc8a79cb
Merge pull request #3495 from overleaf/ae-prettier-2
...
Upgrade Prettier to v2
GitOrigin-RevId: 85aa3fa1acb6332c4f58c46165a43d1a51471f33
2021-04-15 02:05:22 +00:00