Commit Graph

366 Commits

Author SHA1 Message Date
David 05cdd28790 Merge pull request #18435 from overleaf/dp-ae-pdf-viewer-controls
Update PDF viewer controls

GitOrigin-RevId: 4e15b7cbd34e878d0175be635369b8d620188203
2024-05-30 08:05:06 +00:00
Antoine Clausse 9f29f3109a [web] Promisify ProjectController (#18477)
* Create `promiseAuto` util to replace `async.auto`

* Promisify `BrandVariationsHandler.getBrandVariationById`

* Promisify `updateProjectSettings`

* Promisify `updateProjectAdminSettings`

* Promisify `newProject`

* Promisify `deleteProject`

* Promisify `loadEditor`

* Fix brandVariation loading in promise auto

* Promisify `_refreshFeatures`

* Promisify `_injectProjectUsers`

* Fix `no-inner-declarations`

* Promisify `cloneProject`

* Promisify `userProjectsJson`

* Promisify `projectEntitiesJson`

* Promisify `restoreProject`

* Promisify `renameProject`

* Additional warning fix

* Update unit tests

* Fixup `updateProjectSettings`: call jobs inside the Promise.all

* Use `expressify(...)` instead of manually call `next(err)`

https://github.com/overleaf/internal/pull/18477#discussion_r1613611987
https://github.com/overleaf/internal/pull/18477#discussion_r1613621146
https://github.com/overleaf/internal/pull/18477#discussion_r1613634000
...

* Replace Promise.all by sequencial awaits

https://github.com/overleaf/internal/pull/18477#discussion_r1613852746
https://github.com/overleaf/internal/pull/18477#discussion_r1613611987

* Remove manual throws of 500. Let the generic error handler catch them.

https://github.com/overleaf/internal/pull/18477#discussion_r1613623446
https://github.com/overleaf/internal/pull/18477#discussion_r1613628955

* Promisify `untrashProject`

https://github.com/overleaf/internal/pull/18477#discussion_r1613627783

* Promisify `expireDeletedProjectsAfterDuration`

* Promisify `archiveProject`

* Promisify `unarchiveProject`

* Promisify `trashProject`

* Promisify `expireDeletedProject`

* Use async `setTimeout` from `timers/promise`

https://github.com/overleaf/internal/pull/18477#discussion_r1613843085

* Remove unused `_injectProjectUsers`

https://github.com/overleaf/internal/pull/18477#discussion_r1613855766

* Add missing exec in queries (?)

Not sure if that makes a real difference but it's more consistent with the rest of the code

* Catch floating promises

https://github.com/overleaf/internal/pull/18477#discussion_r1613868876

* Replace custom `promiseAuto` by `p-props` from NPM

https://github.com/overleaf/internal/pull/18477#discussion_r1613393294

* Downgrade `p-props` to v4. Later versions require ESM

* Simplify code around `splitTestAssignments`

GitOrigin-RevId: 84d37f7aa9227b5b9acf9eeb5db1b78afc01b6ee
2024-05-30 08:04:36 +00:00
Jimmy Domagala-Tang 63d3cfa112 Merge pull request #18175 from overleaf/jdt-new-bib-file-prompt
[Web] Add opportunistic prompts for third party references

GitOrigin-RevId: d794df16781d0db707423f23ab12f40a13604907
2024-05-27 10:23:41 +00:00
Eric Mc Sween 01e2a29766 Merge pull request #18225 from overleaf/em-typescript-eslint
Add typescript-eslint rule: no-floating-promises

GitOrigin-RevId: 8c3decdff537c885f5bfeb5250b7805480bc6602
2024-05-27 10:22:20 +00:00
David 1fa0ddd63c Merge pull request #18077 from overleaf/dp-teardown-share-modal-paywall-split-test
Tear down project-share-modal-paywall split test

GitOrigin-RevId: b85e6cdf2243a76d071607e55a33f9909f704b76
2024-04-25 08:04:21 +00:00
Alf Eaton 0c53c3816e Remove latex-log-parser split test (#17999)
GitOrigin-RevId: 5accb0e5fc4c1ecce563f1d6f991de8c8633308b
2024-04-23 08:05:16 +00:00
Alexandre Bourdin e075611632 Merge pull request #17907 from overleaf/ab-split-test-assignments-optim-pt1
[web] Read anonymous split test assignments in session from both old&new fields

GitOrigin-RevId: 5235bb3e7d72d5ff9e89c6543b70fb80e9f1213c
2024-04-19 08:04:11 +00:00
Domagoj Kriskovic 2200d9d1bc [web] add Revert File button behind a feature flag (#17975)
* [web] add Revert File button behind a feature flag

* improve error message

* use constant for timeout

GitOrigin-RevId: 047c35d22e948351c52d469e48b869719f44ec4f
2024-04-19 08:04:06 +00:00
Antoine Clausse b54ffbe6a1 [web] Paywall CTA split-test (#17555)
* Fix `{splitTest.requiredCohortSize && (...)}` can display `0`

* Get `paywall-cta` assignment in ProjectController.js

* CTA change: "Get Dropbox Sync"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286026

* CTA change: "Get GitHub Sync"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736

* CTA change: "Get Git integration"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286283

* CTA change: "Add more collaborators"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763884855

* CTA change: "Get track changes"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764030761

* Update wording and position: "Already subscribed? Try refreshing the page."

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764366969

* Casing update: "Upgrade to track changes"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764209961

* CTA changes: "Get Mendeley integration" + "Get Zotero integration"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547424

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547269

* CTA change: "Get full project history"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762005

* Casing update: "full project history"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762280

* CTA change: "Get more compile time" in timeout-upgrade-prompt-new.tsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563

* CTA change: "Get more compile time" in compile-timeout-warning.tsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762726

* CTA change: "Get advanced reference search"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969087

* Update casing and wording: "advanced reference search"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969412

* CTA change: "Get Symbol Palette"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765128906

* Update title: "Subscribe to find the symbols you need faster"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765289664

* Revert use of `satisfies`: it doesn't work with our version of prettier (https://github.com/prettier/prettier/issues/13516)

* CTA change: "Get more compile time" in compile-timeout-changing-soon.tsx

⚠️ not in miro

* Rename `paywallCtaAssignment`, remove useless export and comment

Addressing Fahru's review

* Add alternative texts in `/registration/try-premium` page

* CTA change: "Get more compile time" in timeout-upgrade-prompt.jsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563

* CTA change: "Get GitHub Sync" in import-project-from-github-modal-content.tsx

Not in Miro, but related to: https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736

* CTA change: "Get more compile time" in compile-time-warning.tsx

Not in Miro, but related to others

* Fix compile-time-warning style (spacings, overflows out of window)

* `npm run format:fix`

GitOrigin-RevId: 0d8d1808b5901c2761d35494c49713d26721bcfd
2024-04-03 08:04:16 +00:00
Alf Eaton e0e8a2ffaa Merge pull request #17525 from overleaf/ae-upgrade-prettier
Upgrade Prettier to v3

GitOrigin-RevId: 6f1338f196408f3edb4892d5220ad3665ff1a5bc
2024-03-26 09:04:05 +00:00
Jakob Ackermann fcf27574f1 Merge pull request #17353 from overleaf/jdt-wf-oauth-tutorial
Writefull Oauth banner

GitOrigin-RevId: cdd8d27b70c9c0f5be326f6861a7c997ca81616e
2024-03-06 17:27:46 +00:00
Jakob Ackermann 60b412cf3e Merge pull request #17167 from overleaf/jpa-hide-writefull-anon
[web] hide Writefull promotion for non-logged-in users

GitOrigin-RevId: 945b0f3da4b3bbd64e71e10f40ab6f8320efb1cd
2024-02-19 09:04:06 +00:00
Alf Eaton ecd9230cb3 Add compile-log-events assignment (#16655)
GitOrigin-RevId: 11a7986796e6970783c391c18101b0bfdd82a67d
2024-01-29 09:03:16 +00:00
Alexandre Bourdin 922ae77b45 Merge pull request #16307 from overleaf/ab-split-tests-never-throw
[web] Guarantee split test assignments can never throw and cleanup boilterplate error handling

GitOrigin-RevId: ab50abde6e0632c5a9625b5c3d3e98f3383cc56c
2024-01-19 09:05:14 +00:00
Mathias Jakobsen 2a78b68c78 Merge pull request #16186 from overleaf/mj-mongo-object-id
[web] Use constructor for ObjectId

GitOrigin-RevId: 9eb8b377ea599605b72af237d1ab12f4d8287162
2023-12-19 09:04:02 +00:00
Jimmy Domagala-Tang ab0ae4aba8 Merge pull request #16007 from overleaf/jdt-writeful-user-settings
Add Writeful to user settings

GitOrigin-RevId: 15b3dd47b96cdc8bf8002afe3ddc570b03a6065f
2023-12-08 09:04:45 +00:00
Eric Mc Sween ef5a50cb53 Merge pull request #16073 from overleaf/em-postpone-tutorials
Support postponing tutorials

GitOrigin-RevId: fe662086c87cc1909d6d9eeac07f85e306d64418
2023-12-06 09:04:58 +00:00
Jakob Ackermann eebd05bf74 Merge pull request #16001 from overleaf/jpa-web-real-time-auto-join-only
[web] drop support for legacy real-time connection

GitOrigin-RevId: d03aae6392a8d920239647ab198d66d6c75f61a0
2023-11-30 09:03:49 +00:00
Eric Mc Sween bce98eb937 Merge pull request #15958 from overleaf/em-writefull-script-local
Load the Writefull script when given a query param

GitOrigin-RevId: 57ce26b8692b43b7754ee77de67e9734d4a196dc
2023-11-30 09:03:29 +00:00
Alf Eaton de0f55f95c Remove Angular/Pug review panel code (#15935)
GitOrigin-RevId: de782d4b47d987f6434a34bea487568b269e8d85
2023-11-29 09:04:13 +00:00
Alf Eaton 5da684cace Remove Ace (#14299)
GitOrigin-RevId: ec8788fdbc8aea73ca33ec2810f4e588fe9476b5
2023-11-29 09:04:08 +00:00
Mathias Jakobsen a0f818120e Merge pull request #15781 from overleaf/ds-react-history-split-test-tear-down
History View React - Split test tear down

GitOrigin-RevId: 6095ea94a74fc96c7031a4d1bbefdc6211cc934c
2023-11-24 09:04:14 +00:00
Alf Eaton 0091b82db5 Upgrade PDF.js (#15157)
GitOrigin-RevId: a0a241da08c06a7e345a710559cb47fb59685e5a
2023-11-15 09:03:09 +00:00
Miguel Serrano f118cae32c [SP] Prevent rendering of sync section in SP when git disabled (#15647)
GitOrigin-RevId: 0f4c43eeb0182e7288566eff1ceed861bb9c4338
2023-11-07 12:35:08 +00:00
Alf Eaton bda9190d02 Show the git sync modal to read-only users (#15301)
GitOrigin-RevId: e002815fa7c18d497260e6344a4e8de95d7bacef
2023-11-07 12:35:04 +00:00
Alf Eaton f55688f0d5 Merge pull request #15214 from overleaf/ae-legacy-source-editor
Remove legacy source editor option from Server CE/Pro

GitOrigin-RevId: 32a7bf9b54c0082f3ab3ffb5fa11f5b4f2a3bf64
2023-10-20 08:03:51 +00:00
Alf Eaton d512c8f614 Add optional personal access tokens for git bridge (#15209)
GitOrigin-RevId: 50d4c0e11728e014e81172c062a3b22fefa6286c
2023-10-20 08:03:27 +00:00
Tim Down aef6393980 Merge pull request #15262 from overleaf/td-ide-page-feature-flag
Add IDE page split test handling

GitOrigin-RevId: 911e6d842ad473fcdb99d9715aeea18f02907a99
2023-10-19 08:02:59 +00:00
Eric Mc Sween 9ad4ec2350 Merge pull request #15001 from overleaf/em-invite-audit-logs
Project audit logs for invite operations

GitOrigin-RevId: c2db4bc719f508c5bf33be2c59eddfb63fcdae25
2023-10-11 08:03:41 +00:00
Alf Eaton 1b27d1b60f Remove editor split tests (#14985)
* Remove source-editor-toolbar split test
* Remove editor-left-menu split test
* Remove paste-html split test
* Remove figure-modal split test
* Remove rich-text split test
* Remove table-generator split test

GitOrigin-RevId: e3fe415b81ff0135d8764cd3f3c91b1dd4a77cf0
2023-10-04 08:04:34 +00:00
Tim Down 969f5fe8dc React IDE page shell (#14988)
* React IDE page shell

* Set the maximum height of the symbol palette to 336px

* Tidy export

* Remove unnecessary destructuring

* Update comment

* Optimize toggle

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>

* Change snap-to-collapse threshold to 5%

* Synchronize left column width between history and editor views and remove duplication in ide-page

* Replace resizer dots with SVG

* Rermove unnecessary import and comment the remaining ones

* Use block prepend to avoid duplication

* Improve vertical content divider styling

* Implement fixed width during container resize on left column

* Change IDE page file extension

* Refactor fixed-size panel into a hook and use for chat panel

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: aa881e48a2838a192b6f8f9e16e561f5cd706bd3
2023-10-03 08:04:04 +00:00
Alf Eaton c375bd820a Copy tags when cloning a project (#14987)
GitOrigin-RevId: 4cdca0ef2f26bf6bba02b675b0ef02ba8da881e2
2023-09-29 08:04:14 +00:00
Mathias Jakobsen 2f8156701b Merge pull request #14663 from overleaf/mj-table-generator-promo
[cm6] Add promotion popover for table generator and pasting formatted text

GitOrigin-RevId: 9096b36ac4f07d1fc862ecc3bd5df033348950ab
2023-09-28 08:04:21 +00:00
Jimmy Domagala-Tang 4183d0d1ab Merge pull request #14866 from overleaf/jdt-hist-rename-test
fix: rename the history view split test so we can reroll it
GitOrigin-RevId: fd42fab5b6fd715b89688b401596962453b1d002
2023-09-19 08:04:10 +00:00
Jakob Ackermann 17d5a73d99 Merge pull request #14803 from overleaf/jpa-split-test-cache-alpha-beta
[web] invalidate split test cache when alpha/beta program status changes

GitOrigin-RevId: 3023d2adf8466b48490c51497f5c80e7b0a1fe3d
2023-09-14 08:04:12 +00:00
Jimmy Domagala-Tang 1ddd192d4a Merge pull request #14380 from overleaf/jdt-history-onboarding-saves
save onboarding completion on user

GitOrigin-RevId: bcb4d9d1909aa11e5cfcf283e04fe1057460bf7b
2023-08-30 08:05:17 +00:00
Rebeka bc125a9265 revert documentation-on-editor split test implementation
GitOrigin-RevId: dacdd0eca50a14525366d55f1c4cc12f7b54c0de
2023-08-30 08:04:10 +00:00
Alf Eaton b5261d4b2d [cm6] Remove Galileo code (#14336)
GitOrigin-RevId: 878faff8eea90f508aa94e4471990c31d5d3f0e5
2023-08-18 12:11:28 +00:00
Alf Eaton 91476f9ce5 Remove CM5 Rich Text module (#11776)
GitOrigin-RevId: 812d3b5f1df7e769c8be732ccb31653e8e9a8aa3
2023-08-16 08:03:35 +00:00
Alf Eaton 0ba978ece0 [visual] Convert pasted HTML to LaTeX (#12094)
GitOrigin-RevId: a2fd4411ab8655eea834d321025efb9644081252
2023-08-14 08:05:05 +00:00
Mathias Jakobsen de8c11c435 Merge pull request #14105 from overleaf/mj-table-generator
[visual] Initial table generator

GitOrigin-RevId: 5c1a9cad898c988d21390358872a6c2eaf1c32fc
2023-08-09 08:04:15 +00:00
ilkin-overleaf e65a36fcba Merge pull request #13767 from overleaf/ii-review-panel-migration-in-editor-widgets
[web] Create in editor widgets

GitOrigin-RevId: 53dfb9935ee59bbdedc353aad5e5b19f389a513c
2023-07-17 11:07:06 +00:00
Alf Eaton fd6de507a6 Merge pull request #13623 from overleaf/ae-symbol-palette-toolbar
[cm6] Only show symbol palette toolbar button when available

GitOrigin-RevId: 34e2c4e8ac1077a4da15277188ea0456db26e0af
2023-07-17 10:55:45 +00:00
Miguel Serrano d5b2ab23dc Merge pull request #13485 from overleaf/msm-share-modal-fetch-tokens
[web] Fetch share tokens instead of sending via websocket

GitOrigin-RevId: f97bb91ca3ceb410fe860bf1c7802d8157d9f8b4
2023-07-17 10:48:10 +00:00
Domagoj Kriskovic dac01b459f [cm6] Add toolbar to Source Mode for Beta users (#13429)
* [cm6] toolbar for source mode

* top:0 for new toolbar

* empty div for extensions

* fix legacy css top pos

* show source toolbar split test

* prettier

* show beta icon in source editor

* dropdown toolbar wip

* fix wrong conflict resolve

* math dropdown, chrome extension fixes

* math dropdown cleanup

* sort en.json

* fix sort en.json

* using isVisual

* getMeta in component, pug update

* using flex grow

* toolbar beta badge

* remove extra whitespace

* has-legacy-toolbar class

* Increase container size

* fix tests

* prettier

* styling fixes, using SplitTestBadge

* only show source toolbar if flag is set

* fix typo

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: 34b01a9421f4a0d6defc40925c5092901575946e
2023-07-17 10:46:26 +00:00
Alf Eaton a911139deb Merge pull request #13525 from overleaf/jpa-teardown-compile-domain-test
[web] start tear down of split test for new compile domain

GitOrigin-RevId: 405bba924a37f56614b0744f47914306f420a028
2023-07-17 10:43:01 +00:00
Domagoj Kriskovic dba1bfdcc1 [cm6] rename to Code Editor | Visual Editor (#13513)
* [cm6] rename to Code Editor | Visual Editor

* showLegacySourceEditor change

* show info badge

* remove info badge

* display info badge

* use "Visual Editor" in example project

GitOrigin-RevId: 549e25aa4bcfe58522eadc70e35ca35f822317b1
2023-07-17 10:39:10 +00:00
M Fahru 4c302c754f Teardown onboarding video tour test (#13351)
GitOrigin-RevId: 215c26fe047ec037f8d1d878eac406c36dbb656b
2023-07-17 10:32:51 +00:00
Miguel Serrano 6ae44e3747 Merge pull request #13327 from overleaf/msm-web-track-changes-cleanup
[web] Cleanup track-changes from web

GitOrigin-RevId: 8cef709ec5e91e4ffe8cd06826038ed84f36ef67
2023-07-17 10:28:12 +00:00
ilkin-overleaf ba0af20678 Merge pull request #13343 from overleaf/ii-review-panel-migration-create-feature-flag
[web] Create feature flag for review panel

GitOrigin-RevId: e7e83729a536dce1824f604fb66afe1785f4be25
2023-07-17 10:26:04 +00:00