Eric Mc Sween
2584586ba2
Decaf cleanup: camel-case variables
2020-09-03 15:13:04 -04:00
Eric Mc Sween
c52d7d8f02
Decaf cleanup: simplify null checks
2020-09-03 15:13:04 -04:00
Eric Mc Sween
ee4c08868c
Decaf cleanup: remove default callbacks
2020-09-03 15:13:04 -04:00
Eric Mc Sween
32f0bbe266
Decaf cleanup: remove IIFEs
2020-09-03 15:13:04 -04:00
dependabot[bot]
cc3ccc2713
Bump bl from 2.2.0 to 2.2.1
...
Bumps [bl](https://github.com/rvagg/bl ) from 2.2.0 to 2.2.1.
- [Release notes](https://github.com/rvagg/bl/releases )
- [Commits](https://github.com/rvagg/bl/compare/v2.2.0...v2.2.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2020-09-03 19:03:30 +00:00
Eric Mc Sween
f650da8675
Decaf cleanup: remove __guard__
2020-09-02 17:06:35 -04:00
Eric Mc Sween
99648341e2
Decaf cleanup: remove unnecessary returns
2020-09-02 16:58:41 -04:00
Eric Mc Sween
08be54a43e
Decaf cleanup: remove unnecessary Array.from()
2020-09-02 16:45:49 -04:00
dependabot[bot]
6b93bbfe09
Bump bl from 4.0.1 to 4.0.3
...
Bumps [bl](https://github.com/rvagg/bl ) from 4.0.1 to 4.0.3.
- [Release notes](https://github.com/rvagg/bl/releases )
- [Commits](https://github.com/rvagg/bl/compare/v4.0.1...v4.0.3 )
Signed-off-by: dependabot[bot] <support@github.com >
2020-09-02 16:50:44 +00:00
Jakob Ackermann
a2f5bf463e
Merge pull request #190 from overleaf/jpa-socket-io-logger
...
[misc] socket.io: use a custom logger
2020-09-02 10:46:23 +02:00
Jakob Ackermann
c6f2a3b387
Merge pull request #189 from overleaf/jpa-relevel-log
...
[misc] re-level expected error log messages
2020-09-02 10:46:08 +02:00
Jakob Ackermann
54c0853aa5
Merge pull request #188 from overleaf/jpa-drop-duplicate-log
...
[misc] drop duplicate logs
2020-09-02 10:45:57 +02:00
Shane Kilkelly
d284caf1db
Merge pull request #82 from overleaf/sk-add-error-to-log
...
When logging IOException for put, include error
2020-09-02 09:30:36 +01:00
Shane Kilkelly
bb7831012b
When logging IOException for put, include error
2020-09-01 13:28:35 +01:00
Jakob Ackermann
72282a07df
[misc] socket.io: use a custom logger
...
- forward the previously enabled log messages to our logger-module
- stub the previously disabled logger methods
- drop the log-level config for socket.io
2020-09-01 09:30:11 +01:00
Jakob Ackermann
1d57706d44
[misc] migrate acceptance tests to the native mongo driver, drop mongojs
2020-08-28 17:06:25 +01:00
Jakob Ackermann
f80a92ce46
[misc] migrate the app to the native mongo driver
...
acceptance tests to follow in a separate commit
2020-08-28 15:12:30 +01:00
Jakob Ackermann
4960bdd6fe
[misc] re-level log: 404 from web -> WARN and emit 'project not found'
...
A stale browser tab tried to join a deleted project.
Emitting 'project not found'/'ProjectNotFound' will trigger a page
reload in the frontend, upon web can render a 404.
See frontend: ConnectionManager.joinProject callback
2020-08-27 11:51:57 +01:00
Jakob Ackermann
55d938ba14
[misc] add tests for web replying with a 404 for joinProject
2020-08-27 11:51:56 +01:00
Jakob Ackermann
884b340c75
[misc] re-level log: 403 from web goes to WARN and emit 'not authorized'
...
Users will get redirected to the login page and will see a 'restricted'
page after logging in again.
See frontend: ConnectionManager.reportConnectionError
2020-08-27 11:51:56 +01:00
Jakob Ackermann
d2a2b9d46e
[misc] add tests for web replying with a 403 for joinProject
2020-08-27 11:51:56 +01:00
Jakob Ackermann
1ff9c1e71b
[misc] add the rpc-method into the log context in Router._handleError
2020-08-27 11:51:55 +01:00
Jakob Ackermann
0647abf433
[misc] drop info-log in WebApiManager for joinProject being rate-limited
...
The CodedError is logged at warn-level in Router._handleError.
2020-08-27 11:51:09 +01:00
Jakob Ackermann
2ce7b36c95
[misc] drop duplicate log line for unauthorized applyOtUpdate calls
...
The violation is logged in Router._handleError.
2020-08-27 10:22:31 +01:00
Jakob Ackermann
dee4749e6d
[misc] re-level log: properly silence unauthorized updateClientPosition
2020-08-27 10:11:40 +01:00
Simon Detheridge
38cc0488b1
Merge pull request #65 from overleaf/spd-migration-script
...
Add script to migrate data from S3
2020-08-26 12:58:50 +01:00
Simon Detheridge
f9862081b7
Add script to migrate data from S3
2020-08-26 11:46:40 +01:00
Jakob Ackermann
425052ff91
Merge pull request #187 from overleaf/jpa-o-error-tagging
...
[misc] migrate to OError tagging/wrapping
2020-08-25 11:46:28 +02:00
Jakob Ackermann
64e659bf43
Merge pull request #186 from overleaf/jpa-fix-join-project-error-context
...
[misc] fix join project error context
2020-08-25 11:46:18 +02:00
Jakob Ackermann
849a1cf416
Merge pull request #185 from overleaf/jpa-doc-id-in-error-context
...
[misc] add/bring back doc_id in error context
2020-08-25 11:42:41 +02:00
Jakob Ackermann
735027a2b7
Merge pull request #184 from overleaf/jpa-custom-errors
...
[misc] migrate to custom OErrors
2020-08-25 11:42:19 +02:00
Jakob Ackermann
6df23a9712
Merge pull request #183 from overleaf/jpa-increase-unit-test-timeout
...
[misc] increase the timeout for unit tests -- CI boxes are too slow
2020-08-25 11:41:53 +02:00
Jakob Ackermann
ed0426478c
Merge pull request #66 from overleaf/jpa-mongodb-native
...
[misc] migrate to the native mongo driver
2020-08-25 11:00:34 +02:00
Jakob Ackermann
2fa09928ee
[misc] migrate acceptance tests to the native mongo driver, drop mongojs
2020-08-25 09:41:23 +01:00
Jakob Ackermann
df0747ec48
[misc] migrate the app to the native mongo driver
...
acceptance tests to follow in a separate commit
2020-08-25 09:40:59 +01:00
Jakob Ackermann
b5e770daff
Merge pull request #56 from overleaf/jpa-wait-for-db
...
[misc] simplify the naming around waiting for a mongo connection
2020-08-25 10:20:37 +02:00
39ea30355e
[misc] simplify the naming around waiting for a mongo connection
...
Co-Authored-By: Eric Mc Sween <eric.mcsween@overleaf.com >
Co-Authored-By: Miguel Serrano <mserranom@gmail.com >
Co-Authored-By: Simon Detheridge <s@sd.ai >
2020-08-24 17:41:03 +01:00
Jakob Ackermann
ee3d3b09ed
[misc] wrap redis errors as tagging does not work with them
...
ioredis may reuse the error instance for multiple callbacks. E.g. when
the connection to redis fails, the queue is flushed with the same
MaxRetriesPerRequestError instance.
2020-08-24 10:12:20 +01:00
Jakob Ackermann
537e97be73
[misc] OError.tag all the errors in async contexts
...
See the docs of OError.tag:
https://github.com/overleaf/o-error#long-stack-traces-with-oerrortag
(currently at 221dd902e7bfa0ee92de1ea5a3cbf3152c3ceeb4)
I am tagging all errors at each async hop. Most of the controller code
will only ever see already tagged errors -- or new errors created in
our app code. They should have enough info that we do not need to tag
them again.
2020-08-24 10:12:06 +01:00
Jakob Ackermann
8e31cc5c23
[Router] _handleError: joinProject error-context may not have project_id
...
The ol_context patch changed the priority of client context and rpc
context.
This lead to the (possibly missing) project_id of the client context
overwriting the project_id of the rpc context.
REF: f1d55c0a5437a518e9f4617473caed9ba928e648
2020-08-21 13:29:28 +01:00
Jakob Ackermann
f935b1881a
[Router] leaveDoc: pass the doc_id into the error-context
2020-08-21 12:47:42 +01:00
Jakob Ackermann
fd88819eec
[Router] _handleError: ol_context.doc_id does not exist, drop overwrite
2020-08-21 12:47:42 +01:00
Jakob Ackermann
880056d397
[Router] use a new UnexpectedArgumentsError
2020-08-21 12:47:08 +01:00
Jakob Ackermann
50140f785a
[WebsocketController] use a new JoinLeaveEpochMismatchError
2020-08-21 12:47:08 +01:00
Jakob Ackermann
0462e3e437
[WebsocketController] use a new NotJoinedError
2020-08-21 12:47:07 +01:00
Jakob Ackermann
4cb8cc4a85
[DocumentUpdaterManager] use a new ClientRequestedMissingOpsError
2020-08-21 12:47:07 +01:00
Jakob Ackermann
8abfdb87ff
[DocumentUpdaterManager] use a new DocumentUpdaterRequestFailedError
2020-08-21 12:47:07 +01:00
Jakob Ackermann
02a2382264
[WebApiManager] use a new CorruptedJoinProjectResponseError
2020-08-21 12:47:07 +01:00
Jakob Ackermann
68bc9d0d23
[WebApiManager] use a new WebApiRequestFailedError
2020-08-21 12:47:06 +01:00
Jakob Ackermann
59c4c884a5
[WebsocketController] use the new NotAuthorizedError
2020-08-21 12:47:06 +01:00