Antoine Clausse
af44f478b9
[web] Add admin permission modify-group-manager ( #27642 )
...
* Add capacity `modify-group-manager`
* Check `modify-group-manager` (backend)
* Check `modify-group-manager` (frontend)
* Update tests
* Rename AdminPermissions to mjs
* Add `ol-adminCapabilities` in frontend tests
* Allow modifying group managers if `adminRolesEnabled` is false
* Add `adminPrivilegeAvailable` check
* Update: set `ol-canModify` boolean instead of `ol-adminCapabilities`
* Mock `hasAnyAccess`
* Use `hasAdminCapability` helper
* Add `ol-canModify` to types
* Remove `isAdminMiddleware` as we don't want to relax the permissions for now
* Fix: pass `res` to `hasAnyAccess` (!!)
* * Check `hasWriteAccess` (`hasAdminCapability('modify-group-manager')` or `staffAccess.groupManagement`) in the Pug file
* Fix: Check `hasWriteAccess` in the publisher and institution pug files (!)
* Revert `hasAnyAccess` changes
* Rename `ol-canModify` to `ol-hasWriteAccess` for consistency with other variables
* Remove redundant file AdminPermissions.mjs
* Update unit test
* Revert changes to UserMembershipController.test.mjs
* Rename to `requireGroupManagersWriteAccess`
GitOrigin-RevId: f3f0b1b17abd1d2f0c363688e87d9063de886e3c
2025-08-21 08:05:07 +00:00
Antoine Clausse
40772ef819
[web] Add admin permissions modify-group-member and modify-managed-group-member ( #27665 )
...
* Add capability `modify-managed-group-member` & `modify-group-member`
* Check `modify-managed-group-member` & `modify-group-member` (backend)
* Check `modify-managed-group-member` & `modify-group-member` (frontend)
* Update tests
* Update with `ol-hasWriteAccess` flag
* Update tests
* Move functions to AdminAuthorizationHelper.js
* Update import to fix build error
* Add `ol-hasWriteAccess` to types
* Use `hasAdminAccess()` instead of `req?.user?.isAdmin`
* Add tests on `/manage/groups/:id/invites` depending on admin roles
* Reuse `UserMembershipAuthorization.hasAdminCapability`
* Fix: Add entityAccess check
* Update unit test
* Rename `hasAdminGroupMemberCapability` to `hasModifyGroupMemberCapability`
* Remove useless and redundant `hasWriteAccess` check
* Restore stub in afterEach
GitOrigin-RevId: 4b6d83751121b43d4c19d0dbd82a4833cf7a6f24
2025-08-15 08:05:57 +00:00
Andrew Rumble
160e82a732
Combine implementations of hasAdminCapability
...
GitOrigin-RevId: a847c9182c018524c96726fe30e501763904b82e
2025-08-13 08:06:58 +00:00
Andrew Rumble
cce55cf3d8
Add authorization helper for admin capabilities
...
GitOrigin-RevId: fbf28c89500481e379db6c49512876d867478eb7
2025-08-13 08:06:39 +00:00
Jessica Lawshe
1768bef22a
Merge pull request #26366 from overleaf/jel-group-csv
...
[web] Include in group members CSV if user is managed and/or linked to the group's SSO
GitOrigin-RevId: 449974917d98cf121ea46eaa58be4b3666d88268
2025-07-15 08:06:14 +00:00
ilkin-overleaf
da0967e902
Merge pull request #27015 from overleaf/ii-groups-pagination-2-revert
...
[web] Revert "Group members page pagination"
GitOrigin-RevId: 83c377e319c32110bdaa22970cc378f2aa89be7c
2025-07-11 08:05:44 +00:00
Eric Mc Sween
ebf810e836
Merge pull request #26968 from overleaf/em-revert-jul8
...
Revert bad deploy
GitOrigin-RevId: fd6227cf4fde7fd8053b47365154d59d15fa115e
2025-07-09 08:07:12 +00:00
ilkin-overleaf
cb945472c7
Merge pull request #26610 from overleaf/ii-groups-pagination-2
...
[web] Group members page pagination
GitOrigin-RevId: 9c7635bf24bed0af6d7d1a9626cae310f524b3e0
2025-07-09 08:06:26 +00:00
Andrew Rumble
e76a8ff267
Convert return new Promise to await new Promise
...
GitOrigin-RevId: 49404748cc90cb7bdef0460f7e9837196f81cae8
2025-06-25 08:06:59 +00:00
ilkin-overleaf
cfc6ff0759
Merge pull request #25983 from overleaf/ii-managed-users-make-unmanaged-roles-access
...
[web] Prevent managers from removing/deleting themselves
GitOrigin-RevId: 9287dc06bab8024bf03fecff678a4118a9456919
2025-06-13 08:05:46 +00:00
Andrew Rumble
c0b7efea10
Change imports that use chai to use vitest
...
GitOrigin-RevId: 59d780f754adbb5160a2de8e5eca1def6968584b
2025-06-10 08:05:18 +00:00
Andrew Rumble
873068a187
Update test files with vitest compat changes
...
GitOrigin-RevId: 494f906089d250268a5ff8c8a2150ff2692c37e2
2025-05-29 08:05:06 +00:00
Andrew Rumble
51dcc88f27
Rename test files for vitest
...
GitOrigin-RevId: f8792c0ce5eeb4843a534d3ff83e011d25fb65e0
2025-05-29 08:05:00 +00:00
ilkin-overleaf
bebc32b11d
Merge pull request #23547 from overleaf/ii-flexible-group-licensing-error-assist-2
...
[web] Hide flexible licensing buttons for pending plans (fix)
GitOrigin-RevId: ce5b4ce4138ed7a029b840a87c5498227e3204f4
2025-02-13 09:04:57 +00:00
Eric Mc Sween
761c184c8f
Merge pull request #23540 from overleaf/revert-23483-ii-flexible-group-licensing-error-assist
...
Revert "[web] Hide flexible licensing buttons for pending plans"
GitOrigin-RevId: 6e19c2ae2663fc0cf3335e9517e80a1eee9e2659
2025-02-12 09:05:46 +00:00
ilkin-overleaf
58ece71c7a
Merge pull request #23483 from overleaf/ii-flexible-group-licensing-error-assist
...
[web] Hide flexible licensing buttons for pending plans
GitOrigin-RevId: 8e9b65ae9b68cdd838442e8b45f3bd8f22e72349
2025-02-12 09:05:11 +00:00
Liangjun Song
d66c11e786
Merge pull request #23435 from overleaf/ii-flexible-group-licensing-add-seats-links
...
[web] Add seats links handling
GitOrigin-RevId: d53264277c24ec64b6ff7744b4d7e10a4234ac86
2025-02-07 09:05:24 +00:00
Andrew Rumble
2bfb55a305
Update tests
...
GitOrigin-RevId: 9272720e0f6865c54257c43bd98d8e6003251aa2
2024-10-17 08:06:17 +00:00
andrew rumble
4e2bfd58a1
Handle removal of mongoose callback API for UserMemberships
...
GitOrigin-RevId: 0bdfaf4bfb357d75ee05513cf524540eef7fcec4
2024-08-21 08:04:42 +00:00
andrew rumble
032deaf05c
Switch to mongodb-legacy
...
GitOrigin-RevId: 11e09528c153de6b7766d18c3c90d94962190371
2024-08-21 08:04:24 +00:00
Miguel Serrano
d2cfa26807
Merge pull request #17418 from overleaf/msm-expressify-usermembershipctlr
...
[web] expressify UserMembershipController
GitOrigin-RevId: 54f8d718bffb52609f055490f2a996f6c007f472
2024-03-12 09:03:20 +00:00
David
0e9ceb1ffd
Merge pull request #16788 from overleaf/dp-mongoose-callback-user-membership-handler
...
Promisify UserMembershipHandler and UserMembershipHandlerTests
GitOrigin-RevId: bb33110ee750364754db53fb075a5700be003ecc
2024-02-06 09:03:08 +00:00
Mathias Jakobsen
c371732e6e
Merge pull request #16186 from overleaf/mj-mongo-object-id
...
[web] Use constructor for ObjectId
GitOrigin-RevId: 9eb8b377ea599605b72af237d1ab12f4d8287162
2023-12-19 09:04:02 +00:00
Alexandre Bourdin
c4bea21ee2
Merge pull request #15669 from overleaf/ab-fix-sso-linking-status
...
[web] Fix SSO status in group members table
GitOrigin-RevId: e54e7b0c9640f0b96d9692c0208357e3bac2de91
2023-11-10 09:04:15 +00:00
Alexandre Bourdin
e322f4a31f
Merge pull request #15418 from overleaf/ds-managedUsersEnabled
...
Managed users - Adding a managedUsersEnabled flag on subscription model
GitOrigin-RevId: a03dd169ba71255dd1bec5f7bee8ce9609d95a2f
2023-11-03 09:00:26 +00:00
Miguel Serrano
220998839b
Merge pull request #15504 from overleaf/msm-fix-import-sp
...
[web] Replace module import breaking Server Pro
GitOrigin-RevId: 23f65b06d14019d1878c61abdf71b6b556192dc4
2023-11-01 09:03:25 +00:00
Davinder Singh
3b48b32754
Revert "Revert "Group SSO - Adding a bug fix for sending emails"" ( #15307 )
...
* Revert "Revert "Group SSO - Adding a bug fix for sending emails""
* adding conditional rendering of columns and styling fixes for each render mode with some cypress test
GitOrigin-RevId: 168011503ffacff61c8f37bee4c4bfb012909c1f
2023-10-20 08:04:08 +00:00
Miguel Serrano
0bb5e27dff
Merge pull request #14432 from overleaf/msm-repurpose-managed-users-flag
...
[web] Repurpose `managedUsers.enabled` flag
GitOrigin-RevId: b968048a51feba887aaed798908779612e8c8c96
2023-08-24 08:03:37 +00:00
June Kelly
a14e2aecfb
Merge pull request #13483 from overleaf/jk-managed-users-group-management-ui
...
[web] Managed Users: Update Group Member Management UI
GitOrigin-RevId: 6896951927f0e3220db59dda208d7cfe9c6c309e
2023-07-17 10:46:16 +00:00
Alexandre Bourdin
150cf21710
Merge pull request #13311 from overleaf/ab-tear-down-subscription-pages-react
...
[web] Tear down subscription-pages-react test and remove Angular code
GitOrigin-RevId: 3cf906e476ffa52a058ccb4e4acbb89a657bd021
2023-07-17 10:22:45 +00:00
Alexandre Bourdin
ed40a87cdc
[web] Migrate group management to React ( #11293 )
...
* Rename manage group entry point
* Migrate group management root page to React
* Add cypress tests for the group management react page
* Fix linting
* Add checkbox labels for screen-readers + remove unused classes
* Await on add/remove members calls
* Display the export CSV link for a full group
* Display error message when group is full
* Sort locales
* Handle the managers management page in React version
* Fix missing type in GroupMemberRow
* Split members and managers React pages
* Build API paths on frontend side + add cypress tests for each page
* Fix linting
* Update unit tests
* Review improvements
* Type API errors
GitOrigin-RevId: d124a9d24cbf33de8aacc5d69e9d46e7bcda93c5
2023-02-07 09:04:18 +00:00
ilkin-overleaf
7e68b4f0d5
Merge pull request #11147 from overleaf/ii-subscriptions-pages-react-split-test
...
[web] React subscription split test
GitOrigin-RevId: 6656b3895030bc677483a3e30d5e998f5f7d1458
2023-01-13 09:04:52 +00:00
Alf Eaton
451c910fe3
Merge pull request #8837 from overleaf/mj-fix-default-group-account-translation
...
Rephrase "Group Account" to "Group Subscription" on subscription management page
GitOrigin-RevId: 899a6f27fbe7533b93345b7c27a4d427d40c5e1a
2022-07-18 08:04:23 +00:00
Jakob Ackermann
f0bd6dda23
Merge pull request #7986 from overleaf/jpa-eslint-8
...
[misc] upgrade eslint packages to the latest version everywhere
GitOrigin-RevId: f1480d4a171acef82fb26c4aa54be3a6088b0ab3
2022-05-17 08:05:59 +00:00
Timothée Alby
c0fae79ad7
Merge pull request #6693 from overleaf/jpa-error-is-manager
...
[web] refactor error handling for rejected manager removal
GitOrigin-RevId: 48be3bf254de74c2799d1368aee329fd9038dfa6
2022-02-16 11:34:25 +00:00
Jakob Ackermann
d720d6affa
Merge pull request #6317 from overleaf/jpa-send-explicit-content-type
...
[web] send explicit content type in responses
GitOrigin-RevId: d5aeaba57a7d2fc053fbf5adc2299fb46e435341
2022-01-18 09:03:18 +00:00
Timothée Alby
00e792b022
Merge pull request #6093 from overleaf/jpa-last-user-activity
...
[web] add a last active date for denoting account activity in groups mgt
GitOrigin-RevId: 32a9e5c1e8f63e794bf6d379685b6dda7e6d4d22
2021-12-15 09:05:34 +00:00
Alexandre Bourdin
9468e5cb4f
Merge pull request #4338 from overleaf/ab-session-manager
...
Extract functions from AuthenticationController to SessionManager
GitOrigin-RevId: 86870ce03a762e1a837dcf493759e8851e759883
2021-07-28 12:36:22 +00:00
Alf Eaton
1be43911b4
Merge pull request #3942 from overleaf/prettier-trailing-comma
...
Set Prettier's "trailingComma" setting to "es5"
GitOrigin-RevId: 9f14150511929a855b27467ad17be6ab262fe5d5
2021-04-28 02:10:01 +00:00
Alf Eaton
1ebc8a79cb
Merge pull request #3495 from overleaf/ae-prettier-2
...
Upgrade Prettier to v2
GitOrigin-RevId: 85aa3fa1acb6332c4f58c46165a43d1a51471f33
2021-04-15 02:05:22 +00:00
Eric Mc Sween
9ddaa8c9f6
Merge pull request #3830 from overleaf/em-upgrade-node-12
...
Upgrade to Node 12
GitOrigin-RevId: 19870922884b7c98e7e5f2c94df21829672d2db5
2021-04-01 02:05:52 +00:00
Alasdair Smith
7cbf2cdd9e
Merge pull request #3496 from overleaf/ae-eslint-dot-notation
...
Enable the eslint dot-notation rule
GitOrigin-RevId: e11cbad3e8a77a4a60590d3674fbf34feccc5bc9
2020-12-17 03:07:31 +00:00
Alf Eaton
2ff1cf43d6
Merge pull request #3470 from overleaf/eslint
...
Upgrade and configure ESLint
GitOrigin-RevId: ad5aeaf85e72c847a125ff3a9db99a12855e38aa
2020-12-16 03:08:28 +00:00
Jakob Ackermann
6eeb7857e3
Merge pull request #3390 from overleaf/jpa-faster-unit-tests
...
[perf] faster unit tests
GitOrigin-RevId: 188b8f3752638fde7a27a8d83b416bb9a6e3c95e
2020-11-28 03:04:01 +00:00
Jakob Ackermann
87634be542
Merge pull request #3351 from overleaf/revert-3348-revert-3298-jpa-re-land-mongoose-latest
...
[misc] re-land: remove mongojs and bump mongoose
GitOrigin-RevId: eba9f80fbd58dbb8aed131fead3ec0b928a555aa
2020-11-04 03:04:21 +00:00
Jakob Ackermann
e249a2e5be
Merge pull request #3348 from overleaf/revert-3298-jpa-re-land-mongoose-latest
...
Revert "[misc] re-land: remove mongojs and bump mongoose"
GitOrigin-RevId: 45a284435c88898d96769ab258651fb8d6d20ff5
2020-11-03 03:05:09 +00:00
Jakob Ackermann
28fe397f38
Merge pull request #3298 from overleaf/jpa-re-land-mongoose-latest
...
[misc] re-land: remove mongojs and bump mongoose
GitOrigin-RevId: 02f78d52ffc2d373c8c0bc4860d3b2326a46f5c9
2020-11-03 03:04:52 +00:00
Simon Detheridge
c257b9695a
Merge pull request #3277 from overleaf/revert-3257-jpa-mongoose-latest
...
Revert "[misc] upgrade mongoose to the latest version"
GitOrigin-RevId: d5957fca68be65a08a687476742ffbb9c3cb86e8
2020-10-13 02:04:31 +00:00
Simon Detheridge
dba5127856
Merge pull request #3257 from overleaf/jpa-mongoose-latest
...
[misc] upgrade mongoose to the latest version
GitOrigin-RevId: cc612312e1661a92907dd8d42a32aeccb8cdb62d
2020-10-13 02:04:26 +00:00
Jakob Ackermann
79bdc60743
Merge pull request #3262 from overleaf/jpa-global-query-normalize-helper
...
[misc] add a helper for normalizing queries and detecting ObjectIds
GitOrigin-RevId: 4f0ac53219ab5853b5499447334724c6c39c6303
2020-10-07 02:04:24 +00:00