Commit Graph

65 Commits

Author SHA1 Message Date
Jessica Lawshe 8ddbd8e99d Merge pull request #18717 from overleaf/jel-isSplitTestActive
[web] Add helper for checking if test is active

GitOrigin-RevId: 1e8987517915e3947812086863da11fad252daf1
2024-06-06 08:05:01 +00:00
Alexandre Bourdin 68c3eb7fcd Merge pull request #18000 from overleaf/ab-dev-enable-toolbar-default
[web] Enable the dev-toolbar by default in the dev environment

GitOrigin-RevId: 170e59e9b82268e621fe99ffcc82b7d68467e1b3
2024-05-27 10:23:56 +00:00
Eric Mc Sween 01e2a29766 Merge pull request #18225 from overleaf/em-typescript-eslint
Add typescript-eslint rule: no-floating-promises

GitOrigin-RevId: 8c3decdff537c885f5bfeb5250b7805480bc6602
2024-05-27 10:22:20 +00:00
Antoine Clausse 2b302a8acc Reintroduce compile sampling for analysis (#18217)
* Revert "Merge pull request #14143 from overleaf/jlm-unsampled-compiles"

This reverts commit 2457977d61756be52db506d7c84531b22a26abe0, reversing
changes made to 3c452b3943c453707aac90d38e7b5b2ea9df0df4.

* Re-add export of `getPercentile` in SplitTestHandler.js

Was previously removed in https://github.com/overleaf/internal/commit/aa8c0aadec90b23ead60a4baeb33d6c3c6a2e536

GitOrigin-RevId: 42c48829e7246a6bdb9dbb2d075638c1eafdf2f0
2024-05-06 08:04:45 +00:00
Alexandre Bourdin 5c9db1d378 Merge pull request #18058 from overleaf/ab-split-test-convert-race-cond-fix
[web] Prevent failure due to race condition where converting anon assignments

GitOrigin-RevId: 81eb16689724b9ddc2ec7e23df2c3ea55837b83c
2024-04-23 08:05:54 +00:00
Alexandre Bourdin fc44fc2a38 Merge pull request #18017 from overleaf/ab-convert-assigned-at-date
[web] Transform assignedAt back to date for conversion

GitOrigin-RevId: bd0213b337f765d8512386f9f5d3fc6d03572e33
2024-04-23 08:04:52 +00:00
Alexandre Bourdin 4addbc84d8 Merge pull request #18022 from overleaf/revert-18018-revert-17906-ab-split-test-assignments-optim-pt2
Revert "Revert "[web] Store anonymous users split test assignments in new format in session""

GitOrigin-RevId: bd48a21c17df91eda1536378d8d999a1933e83a2
2024-04-23 08:04:47 +00:00
Alexandre Bourdin 23da3d55e6 Merge pull request #18018 from overleaf/revert-17906-ab-split-test-assignments-optim-pt2
Revert "[web] Store anonymous users split test assignments in new format in session"

GitOrigin-RevId: 2c1a95031a9d1d99b9dfef54eb4b80264a32ba0d
2024-04-19 08:04:27 +00:00
Alexandre Bourdin f929d8d8a8 Merge pull request #17906 from overleaf/ab-split-test-assignments-optim-pt2
[web] Store anonymous users split test assignments in new format in session

GitOrigin-RevId: a5f71f7dcad7e7b11fc6a391bd5182525b3bdf03
2024-04-19 08:04:23 +00:00
Alexandre Bourdin 8259df0392 Merge pull request #18008 from overleaf/ab-fix-anon-assignment-append
[web] Fix anonymous assignment append to session

GitOrigin-RevId: 402cd94ec6250e15f0e35cb69af3977c78ec5a7d
2024-04-19 08:04:19 +00:00
Alexandre Bourdin 86b3f99c9b Merge pull request #17957 from overleaf/ab-archive-test-slack-notif-date
[web] Send correct date for Slack notification when archiving a split test

GitOrigin-RevId: acf39915e3362f90b431b6c973e1191428acd9c9
2024-04-19 08:04:15 +00:00
Alexandre Bourdin e075611632 Merge pull request #17907 from overleaf/ab-split-test-assignments-optim-pt1
[web] Read anonymous split test assignments in session from both old&new fields

GitOrigin-RevId: 5235bb3e7d72d5ff9e89c6543b70fb80e9f1213c
2024-04-19 08:04:11 +00:00
Jessica Lawshe 1fb9d76c39 Merge pull request #17436 from overleaf/ab-split-test-export-cleanup
[web] Fix the split test export format and prune unwanted info

GitOrigin-RevId: 2a8ecbd738338c16fee4bf1d286e724cc25c0008
2024-03-14 09:04:59 +00:00
Jessica Lawshe 39b0378ec1 Merge pull request #17434 from overleaf/ab-allow-analytics-inactive-test
[web] Allow analytics to be enabled for inactive tests

GitOrigin-RevId: f854fd6532357c4291f2785b950eac2478cfbae0
2024-03-14 09:04:54 +00:00
Alexandre Bourdin 922ae77b45 Merge pull request #16307 from overleaf/ab-split-tests-never-throw
[web] Guarantee split test assignments can never throw and cleanup boilterplate error handling

GitOrigin-RevId: ab50abde6e0632c5a9625b5c3d3e98f3383cc56c
2024-01-19 09:05:14 +00:00
Alexandre Bourdin acdb819af6 Merge pull request #14951 from overleaf/ab-split-test-calculator
[web] Split test calculator

GitOrigin-RevId: 53a84a64d69c47d692f215dee351af635a5dcceb
2024-01-15 09:04:22 +00:00
Davinder Singh c45c283ed4 Making getAnalyticsIdFromMongoUser private to UserAnalyticsIdCache (#16125)
* Making getAnalyticsIdFromMongoUser private to UserAnalyticsIdCache

* renaming userAnalyticsIdCache to UserAnalyticsIdCache

* deleting function _getAnalyticsIdFromMongoUser

* renaming userAnalyticsIdCache to UserAnalyticsIdCache part 2

* format:fix

* adding upperCamelCase

* capital case first letter

GitOrigin-RevId: 2e9c18c544b8cffb53838aed56e1ef16979606a5
2024-01-08 09:05:31 +00:00
Alexandre Bourdin c2e7510650 Merge pull request #15808 from overleaf/ab-split-test-dev-toolbar
[web] Split Test Dev Toolbar

GitOrigin-RevId: 630116049a94aceb39d5afc9425b8ec6ee95b944
2023-11-24 09:04:40 +00:00
Alexandre Bourdin d69c1e9518 Merge pull request #14836 from overleaf/ab-split-test-cache-refactoring
[web] Fetch all active split test into cache at once

GitOrigin-RevId: b477b88bf281349433af2cf692a0e9ea5b036588
2023-10-17 08:03:17 +00:00
Jakob Ackermann f2dd3f64ef Merge pull request #14913 from overleaf/jpa-no-cache-for-anon
[web] purge split test cache for anonymous users

GitOrigin-RevId: e268b30ac03d4cab0f7976657089c58bc3c84210
2023-09-25 08:04:30 +00:00
Jakob Ackermann 17d5a73d99 Merge pull request #14803 from overleaf/jpa-split-test-cache-alpha-beta
[web] invalidate split test cache when alpha/beta program status changes

GitOrigin-RevId: 3023d2adf8466b48490c51497f5c80e7b0a1fe3d
2023-09-14 08:04:12 +00:00
Jakob Ackermann 31d9e98ef0 Merge pull request #14736 from overleaf/jpa-split-test-optimizations
[web] split test optimizations

GitOrigin-RevId: 97aa6c5aaad7f2dbb2f2fe9da33812857982996a
2023-09-13 08:03:50 +00:00
Jakob Ackermann 1e83c454bd Merge pull request #14732 from overleaf/jpa-split-test-metrics
[web] collect metrics for split test system

GitOrigin-RevId: 6440b9b9d9900cb8eac9a82ab2f62ae93d7e502a
2023-09-11 08:05:22 +00:00
Jimmy Domagala-Tang b14597aa8d Merge pull request #13272 from overleaf/jdt-hackathon-merge-ff
Allow merge/ replace of local feature flags

GitOrigin-RevId: 531c2b9e73da8b8ca90ec0ed334a21c584cebe59
2023-08-04 08:04:25 +00:00
Jimmy Domagala-Tang 37ccb0aae4 Merge pull request #13809 from overleaf/jdt-front-panel-improvements
Front panel improvements

GitOrigin-RevId: 6d295453819ba2931dc8b6e1c3d947e09ea4eff8
2023-08-01 08:03:52 +00:00
Miguel Serrano 286455247a Merge pull request #13244 from overleaf/msm-fix-split-test-client
[web] Fix split test assignments not sent via LocalsHelper in Server Pro

GitOrigin-RevId: 3a69fda3a4a0e66ecde3772d918d9c6d46e89ecf
2023-06-01 08:04:39 +00:00
Alexandre Bourdin 11a6d49498 [web] Split test slack notifications (#13186)
* first test of notification

* add notification in all methods

* Format variants, store modification author

* Move webhook URLs to saas settings

* Add split test admin URL in notification payload

* Display modifications author in split test admin

* Extract modals from split test edit page

* Confirmation modal for reverting a test, add/show comments, show version badge

* Update integration tests and populate authors on save

* Show version history button even with 1 version

* Fix linting

* Set slack webhook URLs for staging and prod

* Update conditions to display split test admin modals

* Extract the split test creation modal into a separate component

* Extract split test slack notification management into a separate module

---------

Co-authored-by: Lucie Germain <lucie.germain@overleaf.com>
GitOrigin-RevId: 8b69b4b2318b87312fbdd4c02e13c1a6f920a8e9
2023-05-31 08:04:31 +00:00
June Kelly 3daef438b8 Merge pull request #12473 from overleaf/ab-server-pro-split-test-overrides
[web] Add split test overrides through settings for non-SaaS env

GitOrigin-RevId: 82cb6a573a992e730107f6287e7804cfe0f04aa5
2023-04-12 08:04:37 +00:00
Alexandre Bourdin 557a8fb9fc Merge pull request #10973 from overleaf/ab-split-test-dash-graphs-fix
[web] Include archived tests in split test dashboard stats

GitOrigin-RevId: 570b6b5431dce3060a756752d45535a681ae9087
2022-12-22 09:04:48 +00:00
Alexandre Bourdin e9bf52c67c Merge pull request #10933 from overleaf/ab-hackathon-split-tests-fancy-dash
[web/analytics] Split test dashboard improvements

GitOrigin-RevId: 7711060111c043a3002f30381c292249a84c320e
2022-12-21 09:05:50 +00:00
Jakob Ackermann 60a2bf63e3 [web] drop rate of compile-result-backend events to 1%
GitOrigin-RevId: af3e4b56812f014ad7c40d1a98ee6db16798890b
2022-11-04 09:06:03 +00:00
Jakob Ackermann 301d007d1f Merge pull request #10266 from overleaf/ab-split-test-no-serialization
[web] Skip mongoose object transformations for the split test cache

GitOrigin-RevId: 8fb5420f6f938c0ab7cfe1ca82c107c7ce3522ca
2022-11-03 09:03:44 +00:00
Timothée Alby c56ad54646 Merge pull request #9009 from overleaf/ab-split-tests-saas-check
[web] Skip split test assignment logic when not in SaaS mode

GitOrigin-RevId: 4c370bbc78c5a6828207f3336dfa6af9f4d71e17
2022-07-29 08:04:03 +00:00
Alexandre Bourdin 1e53682afc Merge pull request #8957 from overleaf/ab-split-test-controls-badge
[web] SplitTestBadge based on split test phase and badge config

GitOrigin-RevId: e178ca864fd6619ff61a2a84fc1ccb5d54e0a814
2022-07-26 08:04:28 +00:00
Alex Bourdin 4a7c0da351 Fix resolution of user assignments for active split tests for admin
GitOrigin-RevId: c664d1e2b195313c0f9893cf000c670f22929788
2022-07-06 08:03:09 +00:00
Jakob Ackermann 8d3caa251c Merge pull request #8396 from overleaf/jpa-split-test-mongo-user
[web] implement split test assignment based on mongo user

GitOrigin-RevId: d3e2dff6a5e925cfd0426e9ebfeb7b64dc803f42
2022-06-16 08:03:20 +00:00
Alexandre Bourdin c5758fb556 Merge pull request #8389 from overleaf/ab-fix-analytics-enabled-flag
Skip persisting assignment when analyticsEnabled is turned off

GitOrigin-RevId: e22b2cc29a5741ad90743ebaf5eb2c91cca0a2f5
2022-06-14 08:02:35 +00:00
Alexandre Bourdin aaffbe3d10 Merge pull request #8232 from overleaf/ab-fix-anonymous-users-assignment
Fix the condition to assign anonymous users to default for alpha/beta phases

GitOrigin-RevId: 4ffaf2cceeadbfc76120c874ee2c86f747034e9f
2022-06-01 08:03:22 +00:00
Alexandre Bourdin 78ca20b1e1 Split test archiving (#8197)
* Support archiving of split tests

* Do not create variant stripe when rollout percent is 0

* Add acceptance tests for split test archiving

* Review improvements

GitOrigin-RevId: 3c9dd3d88b81b20cacf29966123fcde1c2b0e1a9
2022-05-31 08:04:53 +00:00
Tim Down b4d78ddfb6 Merge pull request #7545 from overleaf/td-split-test-data-sentry
Record split-test state in Sentry metadata from web clients

GitOrigin-RevId: 66dd195c546bd9fb0aedac52844200846c5012ca
2022-04-25 08:04:45 +00:00
Jakob Ackermann ad951a71f1 Merge pull request #7547 from overleaf/jpa-fix-split-test-anonymous-users
[web] bring back split test assignments for anonymous users

GitOrigin-RevId: 4759de31e097fee1493f90a3290339e38de5b3c8
2022-04-13 08:03:45 +00:00
Timothée Alby 0a1c6f6a1a Merge pull request #6934 from overleaf/ab-sso-user-assignment
Fix assignment by user ID for SSO test

GitOrigin-RevId: a487bf45444507246899ea918ffe02ad67e514d4
2022-03-02 09:02:31 +00:00
Eric Mc Sween 854d798d66 Merge pull request #6785 from overleaf/em-split-tests-analytics-enabled
Add "analytics enabled" setting to split tests

GitOrigin-RevId: 9ddfda9e246cac7a13361b2d3df6884212583000
2022-03-01 09:04:15 +00:00
Alexandre Bourdin 8e76a9e2fc Merge pull request #6587 from overleaf/ab-split-test-create-edit
Split tests admin - create/edit

GitOrigin-RevId: a256bf6fe8350214b1ef01ff5e6fa68a812a59be
2022-02-16 11:35:39 +00:00
Alexandre Bourdin a587598447 Split Tests Admin UI - test list (#6411)
* Admin page to list split tests

Admin page to list split tests

Update split test model

Display optional split test fields + Only display link in admin menu in SaaS mode

Add a separate endpoint to update split test info (to avoid creating a new version)

Fix split test tests after rebase

Add name and activeOnly filtering to split test list

Sort split tests by descending order of last modification

Fix lint build error

Add buttons to copy variant assignment as query string

* Move react components to follow our file structure guidelines

* Cleanup and improvements from review

* Small change of report URLs display

* Improve filters display for small screens

GitOrigin-RevId: 498531a1f080419de017883e33d6afed05a3f5c9
2022-01-31 09:03:42 +00:00
Eric Mc Sween b1038e2a4f Merge pull request #6442 from overleaf/em-split-tests-user-admin
Show split test assignments in user admin

GitOrigin-RevId: 4563a4899d5278a0ef84188ae25cb5dfd3d5cb57
2022-01-27 09:04:06 +00:00
Alexandre Bourdin fe2bcf461f Assignment by id for recurly webhook (#6465)
* Allow split test assignment by ID for recurly webhook

* Small refactoring of assignment logic

* Add tests for getAssignmentForUser

* Cleanup following review comments

* Provide default value for sync option in split test handler

GitOrigin-RevId: 828cad3a1f3a0f3efd25f427d00a3c530ae2f087
2022-01-25 09:04:05 +00:00
Alexandre Bourdin 08b46bc6f3 Merge pull request #6332 from overleaf/ab-split-test-param-overrides
Split tests query param overrides

GitOrigin-RevId: 8112710d057ddc22cebf37a619dfc969be57b6cc
2022-01-25 09:03:04 +00:00
Alf Eaton 01042eb030 [web] Upgrade Prettier to match version in monorepo root (#6231)
GitOrigin-RevId: 02f97af1b9704782eee77a0b7dfc477ada23e34d
2022-01-11 09:03:23 +00:00
Miguel Serrano 6de9ac4e95 Override split test locals (#5960)
GitOrigin-RevId: 9a5372f2c4c6d79e6d77a2f72f6dc6a86437f577
2021-12-03 09:03:24 +00:00