Jessica Lawshe
a6028da1eb
Merge pull request #19662 from overleaf/jel-light-touch-tabs
...
[web] Update plan tab buttons for light touch redesign
GitOrigin-RevId: 0ee3e7a9c277097abd32dcae2cc49a1a4b01e6f0
2024-08-01 08:05:37 +00:00
Jessica Lawshe
d24e8102c8
Merge pull request #19638 from overleaf/jel-light-touch-payment-methods
...
[web] Update payment method section on the plans light touch redesign
GitOrigin-RevId: aa55b888b0d02e39cd907de4a675d61836d6aa01
2024-08-01 08:05:33 +00:00
andrew rumble
48e9954686
Upper-case for all methods
...
This is required by the fetch-api.
GitOrigin-RevId: 641c63ad2fe6b9d01c48c28faf669051de8f3271
2024-08-01 08:05:11 +00:00
andrew rumble
d3561ec3cd
Upper case PUT for consistency
...
GitOrigin-RevId: e3ce6b652ee9cee8a719b56d0dddda2faf575968
2024-08-01 08:05:06 +00:00
andrew rumble
7ed9196420
Fix typos
...
GitOrigin-RevId: 69477e3d95db2862f745f43d97a6f98430a1973c
2024-08-01 08:05:01 +00:00
andrew rumble
9e3895ca0f
Separate qs out from url
...
GitOrigin-RevId: 8a1c45d3d71240e63f78f2f1920b324577eb7e6d
2024-08-01 08:04:56 +00:00
andrew rumble
63cb44a4e7
Switch request out for fetch
...
GitOrigin-RevId: b011976084d113c250b002c1bae23f6b38a3281c
2024-08-01 08:04:52 +00:00
andrew rumble
ffe6d63c22
Switch to using status over statusCode
...
This is a difference in the request/fetch APIs.
GitOrigin-RevId: bde9adcf4de2ceaabfd9baae7a93bf2b0b5e5a1e
2024-08-01 08:04:47 +00:00
andrew rumble
08a08c0905
Fix typo in name of method
...
GitOrigin-RevId: fe8a2bcf5e577c001c4508b7bb010e1738ccc903
2024-08-01 08:04:42 +00:00
M Fahru
012ab36d9d
Merge pull request #19648 from overleaf/mf-remove-strike-plans-page
...
Convert `strike` to `s` because `strike` was already deprecated
GitOrigin-RevId: 48dc9fe1a20c1b354c0935d313b1fc5f515cd1fa
2024-07-31 08:05:33 +00:00
Jessica Lawshe
b005d5974e
Merge pull request #19618 from overleaf/jel-light-touch-btns
...
[web] Light touch plans redesign CTAs
GitOrigin-RevId: 7b9be331420044fda08eac563567f1cce4c0c1c2
2024-07-31 08:05:29 +00:00
Jessica Lawshe
ffa3ce00f5
Merge pull request #19616 from overleaf/jel-light-touch-educational
...
[web] Light touch plans redesign license picker and `?` icon
GitOrigin-RevId: 071842c37e2129cf62981317f7a23b8cd5410dba
2024-07-31 08:05:24 +00:00
Antoine Clausse
4a9cb89afc
[web] Merge authentication error handling (V1LoginController & AuthenticationController) ( #19457 )
...
* Promisify `AuthenticationController.doPassportLogin`
* Update tests `AuthenticationController.doPassportLogin`
* Add test on error handling for `AuthenticationController.doPassportLogin`
* Add test on error handling for `V1LoginController.doLogin`
* Extract error handling to `getErrorObject` function
* Simplify code
* Add `Metrics` calls
* Add `password is too long` in AuthenticationController
* Make `info` object consistent with the rest of the codebase
* Move error handling to `AuthenticationManager.handleAuthenticateErrors`
* Move `handleAuthenticateErrors` to other file
I moved this solely because I didn't manage to test it otherwise
* Update tests
* Remove `preDoPassportLogin` hook call
* Remove test on `preDoPassportLogin`
* Use try/catch block instead of `.catch()`
* Revert "Use try/catch block instead of `.catch()`"
This reverts commit 3475afa93ce4af7ad55c91bfc1d7ad3317600ea5.
* Replace `.catch` by `try/catch`
GitOrigin-RevId: 3fba65c30a2c5fc6e5abcd5b83c52801852ed462
2024-07-31 08:05:07 +00:00
Jimmy Domagala-Tang
7f08c95ece
Merge pull request #19448 from overleaf/jdt-experiments-max-subscribers
...
Enforce a maximum participant cap on experiments
GitOrigin-RevId: 1d9263cd34a3d0c831c0ed43867bb4e6430eb06c
2024-07-30 08:05:34 +00:00
Alexandre Bourdin
a80c9afef6
Merge pull request #19562 from overleaf/ab-modules-dependencies
...
[web] Modules dependencies
GitOrigin-RevId: d8bbb25a754f2ed58b1b1e924aa760b87d3135c6
2024-07-30 08:04:36 +00:00
Antoine Clausse
9b31a51c21
[web] Make rate-limit on login consistent, prevent "trim/case bypass" ( #19555 )
...
* Replace `LoginRateLimiter.processLoginRequest` call by use of `RateLimiterMiddleware`
* Lowercase the email to avoid rate-limit bypass
* Remove unit test "when the users rate limit"
* Use `EmailHelper.parseEmail` to normalize email in `processLoginRequest`
This should address the `trim()` bypass
* Use `.trim().toLowerCase()` instead of `EmailHelper.parseEmail`
We can't use `EmailHelper.parseEmail`, else it breaks the test (and feature): "with username that does not look like an email"
* Add acceptance test for rate limit
* Add comment on rate limits
* Rename `rateLimiter` to `rateLimiterLoginEmail` for clarity
* Make the login rate limits configurable from the settings
GitOrigin-RevId: cf1c3a416745f2b007c85014a5084570d4a049a7
2024-07-30 08:04:26 +00:00
Antoine Clausse
348fdc6007
[web] Fix: sendConfirmationEmail promise (!!!) ( #19629 )
...
* Fix `sendConfirmationEmail` promise (!!!)
* Fix: No nested promises, and `sendConfirmationEmail`->`sendReconfirmationEmail`
* Add integration test on `/user/emails/send-reconfirmation`
* Update integration test: use the previously generated token
GitOrigin-RevId: f6386abeb06888351eec22fbcb1d3c614ff5c5c5
2024-07-29 08:04:41 +00:00
Antoine Clausse
62e1177800
[web] Remove overleaf-integration overrides for /user/emails/delete & /user/emails/resend_confirmation ( #19438 )
...
* Use hooks to call `clearSamlSession`
* Promisify `UserEmailsController.remove`
* Use hook for `userDeleteEmailMiddleware`
* Remove `/user/emails/delete` override
* Remove "removeRoute of `/user/emails/resend-secondary-confirmation`"
That route isn't defined elsewhere
* Promisify `UserEmailsController.resendConfirmation`
* Promisify `UserEmailsController.sendReconfirmation`
* Use hook for `resendConfirmationEmailMiddleware`
* Remove `/user/emails/resend_confirmation` override
* Promisify `tryDeleteUser`
* Proxy `clearSamlSession` through `SAMLHelper`
* Revert "Use hook for `resendConfirmationEmailMiddleware`"
This reverts commit f028d9c8
* Inject `SAMLMiddleware.resendConfirmationEmailMiddleware` in `/user/emails/resend_confirmation`
* Update `middleware` syntax and grammar
* Update tests
* Use Module middleware instead of hook for `userDeleteEmailMiddleware`
* Remove "promises" export of tryDeleteUser
GitOrigin-RevId: 211e194fc1ef82dc452ee4e837dcddd9b23690a0
2024-07-29 08:04:24 +00:00
Jessica Lawshe
456fb3f229
Merge pull request #19594 from overleaf/jel-light-touch-table-checkmark
...
[web] Add new green checkmark to plans light touch redesign
GitOrigin-RevId: f6c38e819fdd784ccf39ab09109a33fcd58f23d8
2024-07-26 08:05:02 +00:00
Jessica Lawshe
1f835f152f
Merge pull request #19447 from overleaf/jel-light-touch-table-final-bits
...
[web] Updates for the light touch redesign of the plans table
GitOrigin-RevId: 44ba4fde9b192f3792bf295557fa1018c83a2119
2024-07-26 08:04:53 +00:00
Jessica Lawshe
a227e6f780
Merge pull request #19446 from overleaf/jel-light-touch-file-reorg
...
[web] File reorganization of light touch redesign
GitOrigin-RevId: 6ea13a5d0053bdfd71f9d29d417f73f06a492d49
2024-07-26 08:04:48 +00:00
Jessica Lawshe
4660620dd1
Merge pull request #19415 from overleaf/jel-highlighted-col
...
[web] Update highlighted column for plans page light touch redesign
GitOrigin-RevId: 98a0d6c34762bb7f4530da9cd6d954c2ae1aae56
2024-07-26 08:04:44 +00:00
Jimmy Domagala-Tang
3ab2cd787a
Merge pull request #19301 from overleaf/jdt-collaborator-ai-usage
...
Prevent AI usage on projects where collaborators have a blocking policy
GitOrigin-RevId: 93bdd9c5accff51a14f0585249e13ed7f1fa4e53
2024-07-26 08:04:35 +00:00
David
9e1cd51230
Merge pull request #19400 from overleaf/dp-duplicate-file-folder-name
...
Improvements to handling of file/folder upload conflicts
GitOrigin-RevId: 526edf30dfbaec7ee1e03ffd156365f09be25e86
2024-07-25 08:05:08 +00:00
David
218e81cb7f
Merge pull request #19528 from overleaf/dp-equation-preview
...
Equation Preview
GitOrigin-RevId: 98e71e5d2c1a83d6c9fa685eeee1f4b93a5a3da1
2024-07-25 08:05:04 +00:00
M Fahru
3f8c3ed89c
Merge pull request #19509 from overleaf/mf-contact-support-faq
...
Implement contact support link below FAQ section
GitOrigin-RevId: 5c22c9807522b3ba88169b759520feb165f3f499
2024-07-25 08:04:51 +00:00
Alf Eaton
a73853711d
Promisify Metadata feature ( #19361 )
...
GitOrigin-RevId: 962aa9dbbc41a49c2c3120af9a1254a4db85387b
2024-07-24 08:05:19 +00:00
Alexandre Bourdin
751e842e67
Merge pull request #19465 from overleaf/ab-modules-middlewares
...
[web] Support injecting middlewares from modules
GitOrigin-RevId: efbf68d885f839b92f2e601553c7ce54b9d4b6d3
2024-07-24 08:05:09 +00:00
Mathias Jakobsen
35e9cf77b6
Merge pull request #19418 from overleaf/mj-write-and-cite-custom-render
...
[web] Write & Cite autocomplete prototype
GitOrigin-RevId: f51edb9b1ab9cc2ac8f18277cb291ee87650c213
2024-07-24 08:05:04 +00:00
Rebeka Dekany
cb8693db19
Merge pull request #19472 from overleaf/rd-stylelint-ci
...
[web] Add Stylelint formatting to the CI
GitOrigin-RevId: f31139f9f6f70aa96214b59db37ad1f79cd1e733
2024-07-23 08:04:09 +00:00
David
40ddbcc34d
Merge pull request #19390 from overleaf/dp-pdf-tools-teardown
...
Remove `pdf-controls` feature flag and old controls
GitOrigin-RevId: 807ee0aa6384df354809f4d59b10d00dadef898c
2024-07-22 08:04:22 +00:00
roo hutton
56be1482de
Merge pull request #19398 from overleaf/rh-rm-ieee-notification
...
[web] Remove IEEE Collabratec notification
GitOrigin-RevId: 14ec3e50ed4913b815620f5215df59b17fc03054
2024-07-18 08:04:41 +00:00
Jimmy Domagala-Tang
3eedc884f2
Merge pull request #19328 from overleaf/jdt-global-metrics
...
Allow for site wide metrics and counters
GitOrigin-RevId: e788488bdd673aef4ba0e45a9e39832d6203c44c
2024-07-18 08:04:27 +00:00
andrew rumble
af8b691a59
Remove special code for handling RequestFailedErrors
...
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com >
GitOrigin-RevId: 821826fa56b89176b615e026f11db0b7fcfcbd30
2024-07-17 08:05:05 +00:00
andrew rumble
74127bcc0f
Remove unneeded/confusing assignment
...
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com >
GitOrigin-RevId: 2aa48249cf216bc8cca7e95153695095923c0b86
2024-07-17 08:05:01 +00:00
andrew rumble
53b7d46975
Replace request with fetch-utils in ExpressLocals
...
GitOrigin-RevId: 85c112a2124aeca128753e40c70869517c7026f6
2024-07-17 08:04:57 +00:00
Jessica Lawshe
acf5b643c9
Merge pull request #19414 from overleaf/jel-light-touch-col-headers
...
[web] Update column header styling for light touch redesign of plans table
GitOrigin-RevId: d6b24f1c355256a5dcb2c75255eec610e064fd03
2024-07-16 08:05:15 +00:00
Jessica Lawshe
93c59d553c
Merge pull request #19379 from overleaf/jel-light-touch-separate-rows
...
[web] Separate column header sections into new rows
GitOrigin-RevId: cffe39933f877eaf07a9e772fd76b8e18dd95d3e
2024-07-16 08:05:10 +00:00
Jessica Lawshe
b9951460ec
Merge pull request #19395 from overleaf/jel-light-touch-restructure-mixins
...
[web] Restructure column header mixins for light touch design
GitOrigin-RevId: b8f6d9084b7a0190a0ba421d1e3ba819358c7fa2
2024-07-16 08:05:05 +00:00
Jessica Lawshe
c20fb1cb79
Merge pull request #19376 from overleaf/jel-light-touch-remove-unused
...
[web] Remove unused code for light touch plans page redesign
GitOrigin-RevId: 9e160ed59eec5f8a700b88c0591fb0200c2dc403
2024-07-16 08:05:01 +00:00
Jessica Lawshe
686f71324c
Merge pull request #19332 from overleaf/jel-light-touch-plans-border
...
[web] Update border style for light touch redesign of plans page
GitOrigin-RevId: ba3df408ce626f4b2a3eb634de93d8879f3e9611
2024-07-16 08:04:56 +00:00
Jessica Lawshe
58968b742b
Merge pull request #19331 from overleaf/jel-light-touch-rename-css
...
[web] Rename CSS variables for light touch redesign
GitOrigin-RevId: 8a56c56e2a743e935d70bd585d8c62a93faba0eb
2024-07-16 08:04:51 +00:00
Liangjun Song
7e09d76643
bypass linking sharing admin redirect for internal projects ( #19314 )
...
* disable linking sharing admin redirect
* address comments
* remove ignoreSiteAdmin
* load admin domains from settings
* add acceptance test
* more tests
* fix tests and restore admin domain
* use adminDomains as array
GitOrigin-RevId: 5acb62e1b6ada0aaeceab6db6a6635f82e30833f
2024-07-16 08:04:35 +00:00
Alf Eaton
29ae659a26
Add translated messages for more connection error states ( #19392 )
...
GitOrigin-RevId: 981de624f3964ebe3ff1f0c751fcef9158864d5e
2024-07-15 09:32:55 +00:00
ilkin-overleaf
90e5c2886d
Merge pull request #19249 from overleaf/ii-invite-token-response
...
[web] Fix share modal resend status code
GitOrigin-RevId: 303f7b6c49d9522df6317789bb7c3c69d774715f
2024-07-15 09:05:02 +00:00
M Fahru
ee4dd17f77
Merge pull request #18962 from overleaf/mf-interstitial-payment-new-plans-page-config
...
[web] Implement website-redesign-plans split test config on interstitial payment page
GitOrigin-RevId: 6ea51d5f89ac6b633b5ce6dfbb81c258d668ce13
2024-07-15 09:04:53 +00:00
Jimmy Domagala-Tang
a8935c4235
Merge pull request #19317 from overleaf/jdt-fake-foor-test
...
AI error assistant fake door test
GitOrigin-RevId: 9ba5480a50d9881fa0ce2f3632f94ffe57d7a152
2024-07-15 09:04:48 +00:00
Thomas
4dbccace28
Merge pull request #19348 from overleaf/tm-link-sharing-changes-events-fixes
...
Link sharing changes events fixes for collaborator sharing-updates prompt and project open event
GitOrigin-RevId: 45449f0dd27e07de189a9c2620b0aa9a8849dc41
2024-07-15 09:04:44 +00:00
David
123da51699
Merge pull request #19346 from overleaf/dp-review-panel-empty-state
...
Add empty state to review panel
GitOrigin-RevId: 47d7b676e9868942567fc02db234b0827ac86ba3
2024-07-15 09:04:27 +00:00
Mathias Jakobsen
e897baee48
Merge pull request #19373 from overleaf/mj-comment-regex-fix
...
[web] Fix regex in comment matching
GitOrigin-RevId: e341f13a9ccbe2fbc1ec6c6c1d8a7a11c4dd4e37
2024-07-15 09:04:07 +00:00