andrew rumble
4960569648
Remove unused full arguments
...
As distinct from removing destructured props.
GitOrigin-RevId: d02ad8d36fb532559ed2899268d7b699f2f2fa37
2025-06-11 08:05:46 +00:00
Eric Mc Sween
6d202432ff
Merge pull request #26209 from overleaf/em-multiple-edit-ops
...
Support multiple ops in the history OT ShareJS type
GitOrigin-RevId: fad1e9081ed1978de414c5130692d3b23fcd13d8
2025-06-10 08:06:13 +00:00
Mathias Jakobsen
d3a9b4943a
Merge pull request #26257 from overleaf/mj-ide-breadcrumbs-crash
...
[web] Avoid editor crash when breadcrumbs can't find open entity
GitOrigin-RevId: 7c7f198c82e102ee9f8e2a59ca1755c3550bdf37
2025-06-10 08:05:46 +00:00
Mathias Jakobsen
e0f6ee8b20
Merge pull request #26133 from overleaf/mj-ide-keyboard-shortcuts
...
[web] Editor redesign: Add keyboard shortcuts to menu bar
GitOrigin-RevId: 8fe844389de70a919ba836d03f0390f585532bb1
2025-06-10 08:05:42 +00:00
Eric Mc Sween
e5d828673e
Merge pull request #26128 from overleaf/em-no-tracked-deletes-in-cm
...
History OT: Remove tracked deletes from CodeMirror
GitOrigin-RevId: 4e7f30cf2ed90b0c261eaa4ba51a2f54fe6e3cef
2025-06-06 08:06:34 +00:00
Eric Mc Sween
7a556cf1fd
Merge pull request #26041 from overleaf/em-history-ot-type-serialize
...
History OT type: operate on parsed EditOperations
GitOrigin-RevId: dbb35789736958d4ef398e566400d6e9a0e49e8b
2025-06-04 08:07:54 +00:00
Eric Mc Sween
f11ea06c1a
Merge pull request #25910 from overleaf/em-track-changes-sharejs
...
Track changes in the history OT sharejs doc
GitOrigin-RevId: 17365219f24a25790eac611dbde9681eb73d0961
2025-06-04 08:07:50 +00:00
Eric Mc Sween
c6f4229147
Merge pull request #25952 from overleaf/em-split-editor-facade
...
Split EditorFacade functionality for history OT (2nd attempt)
GitOrigin-RevId: 2bc6d6c54a9f336fd4a69f0eb548dd06b9f06f5f
2025-06-02 08:05:30 +00:00
Mathias Jakobsen
97f8149a2b
Merge pull request #25955 from overleaf/mj-ide-editing-session
...
[analytics+web] Add editor redesign status to editing session segmentation
GitOrigin-RevId: 8f2a05a6851d41712a592952c18b845b77115f47
2025-05-30 08:05:35 +00:00
Eric Mc Sween
25adb7e303
Merge pull request #25949 from overleaf/revert-25869-em-split-editor-facade
...
Revert "Split EditorFacade functionality for history OT"
GitOrigin-RevId: a55328e08776fa0f59071fca955ba73ef130984d
2025-05-28 08:05:30 +00:00
Eric Mc Sween
13fa735da0
Merge pull request #25869 from overleaf/em-split-editor-facade
...
Split EditorFacade functionality for history OT
GitOrigin-RevId: 1e415e1d058c0de0b27271a9a5d7208b4a8a689b
2025-05-28 08:05:26 +00:00
Eric Mc Sween
f69b9f857e
Merge pull request #25825 from overleaf/em-accept-edit-operations
...
Accept all EditOperations in history-ot type
GitOrigin-RevId: b3bc710c92c4aa31dfeec16d422e42f0a6bb8cdb
2025-05-23 08:05:46 +00:00
Jakob Ackermann
1e6b13f9d5
[history-ot] rename remaining history-v1-ot references to history-ot ( #25428 )
...
* [history-ot] rename remaining history-v1-ot references to history-ot
* [web] rename History-v1 OT -> History OT in admin panel
* [web] rename OT Migration -> History OT Migration in admin panel
GitOrigin-RevId: 103ce816d5320d6379d51009cdc08b8a71aa48e6
2025-05-20 08:06:46 +00:00
Tim Down
11d964649c
Merge pull request #25502 from overleaf/td-chat-open-bug
...
Prevent chat opening by default for new user
GitOrigin-RevId: 260050c26f6b9dee7ea52284dadb7ed00ce9eddb
2025-05-13 08:08:11 +00:00
Jimmy Domagala-Tang
82e5b2c5d7
Merge pull request #25151 from overleaf/dk-use-user-features
...
UserFeaturesContext with cross-tab syncing via BroadcastChannel
GitOrigin-RevId: 4262719f5018f5717211851ce28b3255af65461a
2025-05-13 08:07:57 +00:00
Jakob Ackermann
e8b5ee2ff9
[history-ot] initial implementation of using doc-level history-ot ( #25054 )
...
* [history-v1-ot] initial implementation of using doc-level history-v1-ot
* [web] fix advancing of the otMigrationStage
Use 'nextStage' for the user provided, desired stage when advancing.
Co-authored-by: Brian Gough <brian.gough@overleaf.com >
* [document-updater] document size check in editor-core
* [history-ot] rename history-v1-ot to history-ot and add types
* [history-ot] apply review feedback
- remove extra !!
- merge variable assignment when processing diff-match-match output
- add helper function for getting docstore lines view of StringFileData
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com >
* Revert "[document-updater] add safe rollback point for history-ot (#25283 )"
This reverts commit d7230dd14a379a27d2c6ab03a006463a18979d06
Signed-off-by: Jakob Ackermann <jakob.ackermann@overleaf.com >
---------
Signed-off-by: Jakob Ackermann <jakob.ackermann@overleaf.com >
Co-authored-by: Brian Gough <brian.gough@overleaf.com >
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com >
GitOrigin-RevId: 89c497782adb0427635d50d02263d6f535b12481
2025-05-08 08:05:44 +00:00
David
79f9957b68
Merge pull request #25164 from overleaf/dp-editor-survey
...
Create Editor Survey
GitOrigin-RevId: dc11ef16c0a00aa846ac7a664dd88e9531e832f2
2025-05-02 08:05:47 +00:00
Tim Down
7abafb01ea
Merge pull request #23940 from overleaf/td-react-18
...
Upgrade to React 18
GitOrigin-RevId: 9b81936e6eea2bccd97fe5c2c5841f0b946371b8
2025-05-02 08:05:29 +00:00
Tim Down
5d78229e1e
Merge pull request #25093 from overleaf/td-upgrade-react-error-boundary-second-attempt
...
Upgrade react-error-boundary to version 5, second attempt
GitOrigin-RevId: 2b88334b66f0ace383211c147279ff88e9f956bb
2025-04-29 08:06:23 +00:00
Alf Eaton
c732a02b38
Use toast notifications for SyncTeX errors and handle missing file errors ( #24579 )
...
GitOrigin-RevId: 88c6658ff0d11fdb43cef19c48b542a3b2206666
2025-04-28 08:05:42 +00:00
Jakob Ackermann
fe1129c2cf
[web] avoid accessing the sharejs snapshot directly ( #25037 )
...
* [web] avoid accessing the sharejs snapshot directly
* [web] limit API interface for sharejs types
GitOrigin-RevId: faece372128e4580376e32fa93aa8fedf1e02957
2025-04-24 08:05:15 +00:00
Domagoj Kriskovic
1f7bfb4737
"default-visual-for-beginners" split test tear down ( #24759 )
...
GitOrigin-RevId: cdd6c8d3ffb60b9ae3e972f2267f1838cf720c83
2025-04-16 08:05:47 +00:00
David
846ccd3aac
Merge pull request #24859 from overleaf/dp-history-file-tree
...
Always show file tree in history view in new editor
GitOrigin-RevId: e993aae4c1625ef7fb0a716ae5bff8edb0e8d0d0
2025-04-16 08:04:52 +00:00
Mathias Jakobsen
767ac1632e
Merge pull request #24427 from overleaf/mj-command-registry
...
[web] Editor redesign: Add command registry
GitOrigin-RevId: c3d78d052f7e6e067de3247da8fe04329d8822ff
2025-04-07 08:04:40 +00:00
Alf Eaton
b14490d6aa
Avoid setting pendingOpCreatedAt for remote changes ( #24542 )
...
GitOrigin-RevId: 5d1684a743825cac23d486678b8f249cf0d152d8
2025-03-27 09:06:02 +00:00
Jakob Ackermann
dda94cdfbc
[web] ensure that only a single socket.io transport is connected ( #24422 )
...
GitOrigin-RevId: 9397b0c85f0a889385d4761945e976ada7aa537b
2025-03-27 09:05:14 +00:00
Alf Eaton
e754ee9cb4
Remove unused flush-changes listener ( #24449 )
...
GitOrigin-RevId: e22a6677617e1d20f9cd4fce38653d126714a553
2025-03-27 09:05:06 +00:00
Miguel Serrano
d59afb21be
Merge pull request #24327 from overleaf/msm-update-max-reconnect-gracefully-interval
...
[web] Make `maxReconnectGracefullyIntervalMs` configurable
GitOrigin-RevId: 18846b050e76ec86d00bc0dd7e07ab09d552bed7
2025-03-26 09:04:56 +00:00
Alf Eaton
bdcf1d3a83
Convert GitHub Sync tests to Cypress ( #24228 )
...
* Use OError
* Remove setTimeout stub
* Convert GitHub Sync tests to Cypress
* Use setIgnoringExternalUpdates directly
* Migrate remaining GitHub Sync components to TypeScript
GitOrigin-RevId: 7c8b875b9a7bbf6353d87a5f93c2267d1d4bc65d
2025-03-24 10:51:00 +00:00
Alf Eaton
e827540a6d
Record an event when the "unsaved doc" alert is displayed ( #24431 )
...
GitOrigin-RevId: 87ccdf5a15173afa7548532d72fb1d3e32f255fe
2025-03-24 10:50:56 +00:00
Domagoj Kriskovic
7f67df2468
Disable track changes for reviewers in free projects ( #24368 )
...
* Disable track changes for reviewers in free projects
* cleanup_unused_locales
GitOrigin-RevId: 806ee20c0aed5ef61352041782af620cec72ed70
2025-03-24 10:49:20 +00:00
Alf Eaton
b8d74c6ae0
Remove 'review-panel-redesign' split test and old code ( #24235 )
...
GitOrigin-RevId: 1f3d4a9a51429591a82391a9bee3cfdf226bc9c8
2025-03-24 10:48:15 +00:00
David
dcabf55882
Merge pull request #24137 from overleaf/mj-ide-permissions-utils
...
[web] Add switcher for editor redesign
GitOrigin-RevId: 806a1f567027df53f879b564a50aaae9166c8480
2025-03-18 09:05:40 +00:00
Alf Eaton
ecc2f1f544
Merge pull request #24196 from overleaf/ae-fetch-data-access
...
Avoid fetching unavailable project data
GitOrigin-RevId: 58fd58f098af5e3eb000e31f22b403d3e28ef691
2025-03-12 09:05:18 +00:00
Alf Eaton
2147f1d53d
Remove Bootstrap 3 code from IDE page components ( #23061 )
...
GitOrigin-RevId: b41aff10672bf96e892de0be396a69eb25e2443b
2025-03-07 09:05:45 +00:00
Jakob Ackermann
6916e22b09
[real-time] log transport and clientId in both directions of serverPing ( #24084 )
...
GitOrigin-RevId: dabd8db6949498ef1a6252864cef94cd4329e3c0
2025-03-07 09:04:40 +00:00
Domagoj Kriskovic
408f6dfee3
Open overleaf assist paywall via event listener ( #23958 )
...
* Add overleaf assist paywall modal component in storybook
* update img alt
* remove data-action
* rename assistant -> assist
* use css var for blue color
* Open Overleaf assist paywall if in "overleaf-assist-bundle" split-test
* dont use optional planCode
* Open overleaf assist paywal via event listener
* rename to mainEditorLayoutModals
* call setAssistantUpgraded when modal is shown
* fix merge mistake
* fix lint error
* fix merge differences
GitOrigin-RevId: 0b3162a5c241d4dbe2773ae773c3e35f02c5c492
2025-03-04 09:04:37 +00:00
Alf Eaton
18c2b4108d
Tidy up global scope values ( #20379 )
...
* Remove crypto from window
* Remove ui.loadingStyleSheet
* Remove onlineUsers scope
* Remove addNewComment
GitOrigin-RevId: 5e62ed7f265cdd530b5ca85488477093b0be775a
2025-02-28 09:05:15 +00:00
Jakob Ackermann
04c42f03e1
[web] editor connection tweaks for connection attempts when offline ( #23864 )
...
* [web] only flag errors originating from WebSocket connect as ws failure
* [web] slow down reconnecting when potentially offline
GitOrigin-RevId: 7c587d52dfe8092c45e2152f929e05e814db98f4
2025-02-26 09:04:47 +00:00
Jakob Ackermann
8138c76c1d
[web] restrict external heartbeat/server ping to websocket transport ( #23830 )
...
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com >
GitOrigin-RevId: c03a78e2c05cd380b705bd14652060980682cb39
2025-02-25 09:05:02 +00:00
Jakob Ackermann
4d857b7937
[web] editor connection fixes ( #23807 )
...
* [haproxy] add support for xhr-polling in real-time
* [web] try 3 WebSockets then fallback to xhr-polling when (re-)connecting
* [web] ensure old socket.io transport has been closed when reconnecting
* [web] close xhr-polling transport before leaving the page
This will de-register the client, leave the project and clean up the
connected clients tracking ASAP.
* [web] rename constant to avoid confusion
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com >
---------
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com >
GitOrigin-RevId: 55e500c341145947e5589875438fc796394b6ae4
2025-02-25 09:04:58 +00:00
Alf Eaton
a7e00e19e2
Only dispatch doc:changed event for insert or delete operations ( #23779 )
...
GitOrigin-RevId: b3425d4edffb045b2a15e5fc5cb69210d9e97203
2025-02-24 09:05:02 +00:00
Alf Eaton
6688b81ece
Ensure that the Chat pane is disabled for read-only link collaborators ( #23785 )
...
GitOrigin-RevId: 56e1b1d6b08ec7537386cab0b251e325d681e117
2025-02-24 09:04:58 +00:00
Alf Eaton
8ca5360454
Reapply "Increase the length of unsaved doc time before the editor is locked" ( #23723 )
...
* Reapply "Increase the length of unsaved doc time before the editor is locked (#23431 )"
This reverts commit d0efca398e59ca488c530ee9ec5ca76f29843679.
* Use pendingOpCreatedAt if inflightOpCreatedAt isn't set
GitOrigin-RevId: b3301d7cc1554215a4ba569537bd47beeefde20f
2025-02-20 09:06:31 +00:00
Alf Eaton
432bbe0db8
Merge pull request #23714 from overleaf/ae-revert-unsaved-docs
...
Revert "Increase the length of unsaved doc time before the editor is locked"
GitOrigin-RevId: 0f2d257a55ebc3353ded2b10d505bfdb2e85f402
2025-02-20 09:05:53 +00:00
Eric Mc Sween
483c97a484
Merge pull request #23691 from overleaf/em-resolve-comments-permissions
...
Add resolveAllComments and resolveOwnComments permissions
GitOrigin-RevId: 1fca9391dc3ff6e890532054582c49f11731e987
2025-02-20 09:05:45 +00:00
Eric Mc Sween
ae491f910b
Merge pull request #23692 from overleaf/em-history-errors
...
Move error boundary inside history container
GitOrigin-RevId: cd4c911cef18b50cd4187f655e818c9ab851cfe0
2025-02-20 09:05:40 +00:00
Alf Eaton
f40118e58b
Increase the length of unsaved doc time before the editor is locked ( #23431 )
...
* Use opInflightSince to measure unsaved doc time
* Use performance.now() for lastAcked timestamp
* Use inflightOpCreatedAt
* Increase MAX_UNSAVED_ALERT_SECONDS to 15
* Increase MAX_UNSAVED_SECONDS to 30
* Increase FATAL_OP_TIMEOUT to 45000
* Convert "Connection lost" modal to a notification
GitOrigin-RevId: 2d4233723620fd03ce6d6c5795c48c33c0b2f92c
2025-02-20 09:05:20 +00:00
Alf Eaton
04a2e24a89
Use refs and timeout for editor heartbeat events ( #23340 )
...
GitOrigin-RevId: 4eb7697fb40c9aaf523765c256c870a21afb0844
2025-02-20 09:05:15 +00:00
Eric Mc Sween
4152d3d796
Merge pull request #23667 from overleaf/em-read-only-label-version
...
Prevent read-only users from labelling a version
GitOrigin-RevId: 472e70f3860553b131f20afe3dfd01aa00bd48fa
2025-02-19 09:05:26 +00:00