Commit Graph

38 Commits

Author SHA1 Message Date
Andrew Rumble ccfeb59c59 Move hasAdminCapability middleware into helpers
This is so that we can test it more easily than embedding it would allow

GitOrigin-RevId: be23d945bc7c816d32b18b4990ecd9e0a6592eb5
2025-08-08 08:05:42 +00:00
Andrew Rumble 192aacbecd Add hasAdminCapabilities function to ExpressLocals
This will be available in pug to allow admin capabilities to be used.

GitOrigin-RevId: 6bc4e38385b421aa44ee9385e28f3c59b09e3ade
2025-08-08 08:05:37 +00:00
David 2d66b9751a Merge pull request #25784 from overleaf/dp-backend-reviewer-role-cleanup
Remove references to `reviewer-role` feature flag in the backend

GitOrigin-RevId: 4d2088e4c2815d3221817a182a0a66b5a60b3532
2025-05-23 08:05:54 +00:00
Jakob Ackermann e94473a1ce [web] add support for regex based allow-list for skipping captcha (#24266)
* [web] double down on validating email addresses

* [web] normalize emails in captcha middleware

* [web] add support for regex based allow-list for skipping captcha

* [web] skip captcha for trusted users on all actions

GitOrigin-RevId: a994ebf6b74e80f462d2dab1fe5113bbffa676a9
2025-03-24 10:45:53 +00:00
Domagoj Kriskovic 61d300de6a Use owner's reviewer role assigment (#22735)
GitOrigin-RevId: f632ea8c23b5a1f9ac6985922c53f1b6d49e9494
2025-01-10 09:04:46 +00:00
Domagoj Kriskovic 71a0b48a68 Set track changes state permissions for reviewer role (#22345) (#22436)
* Support for adding reviewer role

* added collaboratorsGetter tests

* emit toggle-track-changes when reviewer is added

* Add reviewer in change privilege level handler

GitOrigin-RevId: 88ec39f2b760b5d1ca6dc3a363df31c087268972
2024-12-12 09:04:46 +00:00
Domagoj Kriskovic a038f451d4 Revert "Set track changes state permissions for reviewer role (#22345)" (#22431)
This reverts commit 6a03d2355b3fb7d7b755ed1d3ab1a080126cd2dc.

GitOrigin-RevId: 4e962bd9a547a9d6205460c9a8e9a0e835442be4
2024-12-10 13:09:42 +00:00
Domagoj Kriskovic 53dc5fbafe Set track changes state permissions for reviewer role (#22345)
* Support for adding reviewer role

* added collaboratorsGetter tests

* emit toggle-track-changes when reviewer is added

* Add reviewer in change privilege level handler

GitOrigin-RevId: 6a03d2355b3fb7d7b755ed1d3ab1a080126cd2dc
2024-12-10 13:09:14 +00:00
Domagoj Kriskovic 511fe60a9c Revert "Support for adding reviewer role (#22137)" (#22293)
This reverts commit 54064a7f961fe06f188ab449cd469cdaaf01b20a.

GitOrigin-RevId: 1dabc635756aff465d2fe9aa0d18121b081df3b0
2024-12-04 09:05:12 +00:00
Domagoj Kriskovic f676eca2b8 Support for adding reviewer role (#22137)
* Support for adding reviewer role

* show reviewer in track changes user list

* added "review" in assertClientCanViewProject

* test if reviewer can read project

* added collaboratorsGetter tests

* eit toggle-track-changes when track changes changes

* Support for changing privilege to reviewers for invited users (#22159)

* Add reviewer in change privilege level handler

* added reviewer translation

* added acceptance tests

* fix tests

* Set track changes state permissions for reviewer role (#22167)

* Add reviewer in change privilege level handler

* added reviewer translation

* added acceptance tests

* fix tests

* Set track changes state permissions for reviewer role

* added authorization helper tests

* added ensureUserCanReviewProjectContent middleware

* allow changing track changes only with write permissions

* removed canUserReviewProjectContent

* List projects where user is added as a reviewer (#22249)

* List projects where user is added as reviewer

* list projects in /user/projects

* fix tests

GitOrigin-RevId: 54064a7f961fe06f188ab449cd469cdaaf01b20a
2024-12-04 09:05:00 +00:00
M Fahru 6c83f85d5d Merge pull request #21232 from overleaf/mf-remove-use-advanced-search
[web] Remove advance gallery search

GitOrigin-RevId: af39f63ac0483fe2540ba737f0239d0b503f87fe
2024-10-25 08:06:58 +00:00
Jakob Ackermann a540754f6e Merge pull request #18116 from overleaf/jpa-bulk-replace-localhost
[misc] bulk replace localhost with 127.0.0.1

GitOrigin-RevId: d238f3635302e8ff5500d611108c4d1bef216726
2024-04-26 08:04:39 +00:00
June Kelly c4ecded316 Merge pull request #11508 from overleaf/jk-password-disallow-substring
[web] Metric for passwords too similar to email

GitOrigin-RevId: cf8320fc3c9561b4dc6d54a3e97db96400ece2a9
2023-02-02 18:22:17 +00:00
Alf Eaton 62b727fb61 Merge pull request #11008 from overleaf/msm-fix-email-helper-group
[web] Prevent NPE parsing RFC5322 email groups

GitOrigin-RevId: 57fa7dc523b94c44afdd45a790ff6c3e62e45214
2023-01-11 09:04:49 +00:00
Alf Eaton 80f6662957 Add option for parsing valid RFC5322 email addresses (#8065)
GitOrigin-RevId: 6af8ae850bd8075e6bf0ebcafd2731177cdf49ad
2022-05-24 08:03:52 +00:00
Jakob Ackermann c881829e04 Merge pull request #6729 from overleaf/jpa-cleanup-staff-access
[web] admin privilege does not imply staffAccess

GitOrigin-RevId: 89760c7a9a8f0b0c82ebee40ca3236e9894ab9fa
2022-04-05 12:18:33 +00:00
Jakob Ackermann e82a053c85 Merge pull request #6614 from overleaf/jpa-msm-separate-admin-app
[misc] move admin capability from www. to admin. subdomain

GitOrigin-RevId: e0daeacf3c06b856ffb9fd35dce76e71f14e8459
2022-04-05 12:18:24 +00:00
Eric Mc Sween 8e4b85c6f3 Merge pull request #6731 from overleaf/em-logs-ui-split-test
Move new logs UI to a split test

GitOrigin-RevId: 2ebd5afbbda273e7c3092416c64754a56e628b05
2022-02-16 11:38:42 +00:00
Eric Mc Sween 46d2b84103 Merge pull request #6727 from overleaf/em-revert-logs-ui-split-test
Revert "Move new logs UI toggle to a split test"

GitOrigin-RevId: 5f2aecb53d2df21c89da594b0a64c8cf8ca04bc6
2022-02-16 11:36:26 +00:00
Eric Mc Sween 4df657db4b Merge pull request #6640 from overleaf/em-alpha-beta-split-tests
Move alpha/beta feature toggles to split tests

GitOrigin-RevId: e64387d9bde2db9c4e96ea7f5992c877ad16b9a9
2022-02-16 11:36:20 +00:00
Miguel Serrano b7e9f0b67f Prepare React Pdf Preview Rollout with Split Test (#5746)
Prepare React Pdf Preview Rollout with Split Test and disabled new Logs UI

GitOrigin-RevId: 995b7ca3ed542e58596b9f9715adc93a64da597e
2021-11-12 09:02:42 +00:00
Miguel Serrano 739ac96195 Revert "Prepare new Pdf Preview rollout (#5664)" (#5745)
This reverts commit 047a3c636e09e9786c2a9b93514fef5bc46b0da9.

GitOrigin-RevId: 91b3c024cd364c1fd55d5e4fc6a2c592b784bc2a
2021-11-11 09:03:01 +00:00
Miguel Serrano 19eef0acca Prepare new Pdf Preview rollout (#5664)
* Prepare new pdf preview rollout
* skip new_logs_ui variant tests

GitOrigin-RevId: 047a3c636e09e9786c2a9b93514fef5bc46b0da9
2021-11-11 09:02:57 +00:00
Jakob Ackermann 5e773ce950 Merge pull request #4101 from overleaf/ae-settings-module
Migrate from `settings-sharelatex` to `@overleaf/settings`

GitOrigin-RevId: 9a298ba26382180c1351683c5fddc9004418c1e6
2021-07-08 02:08:28 +00:00
Paulo Jorge Reis 966013f58a Revert "Revert "Extend the new compile UI rollout, respecting existing allocations""
This reverts commit d0ffcb9a13e9597cebf95961c0c50ef8f950dd7a.

GitOrigin-RevId: 46c52ee8df8de4028b3262cb0f3202118014814c
2021-07-07 02:05:44 +00:00
Paulo Jorge Reis 1e43dd3495 Revert "Extend the new compile UI rollout, respecting existing allocations"
This reverts commit 61bfba3a05780ec0b3a3461bba50cca6474a1274.

GitOrigin-RevId: d0ffcb9a13e9597cebf95961c0c50ef8f950dd7a
2021-06-29 02:05:49 +00:00
Paulo Reis d6f9f70d06 Extend the new compile UI rollout, respecting existing allocations
GitOrigin-RevId: 61bfba3a05780ec0b3a3461bba50cca6474a1274
2021-06-25 02:06:24 +00:00
Jessica Lawshe fefa4ec391 Merge pull request #4136 from overleaf/jel-add-gallery-bundle
Add JS bundle for gallery and begin Algolia/React gallery search migration

GitOrigin-RevId: ddce48df9108b4880b39e522c30617fd1a7c0a87
2021-06-10 02:05:24 +00:00
Alf Eaton 1be43911b4 Merge pull request #3942 from overleaf/prettier-trailing-comma
Set Prettier's "trailingComma" setting to "es5"

GitOrigin-RevId: 9f14150511929a855b27467ad17be6ab262fe5d5
2021-04-28 02:10:01 +00:00
Alf Eaton 1ebc8a79cb Merge pull request #3495 from overleaf/ae-prettier-2
Upgrade Prettier to v2

GitOrigin-RevId: 85aa3fa1acb6332c4f58c46165a43d1a51471f33
2021-04-15 02:05:22 +00:00
Eric Mc Sween 9ddaa8c9f6 Merge pull request #3830 from overleaf/em-upgrade-node-12
Upgrade to Node 12

GitOrigin-RevId: 19870922884b7c98e7e5f2c94df21829672d2db5
2021-04-01 02:05:52 +00:00
Paulo Jorge Reis 3f0e897e32 Logs UI variant without popup (#3794)
* Add logs UI without pop-up variant

* Implement frontend for logs UI without pop-up

* Add logs UI variants to admin panel and front user info

* Fix existing UI subvariant window global

GitOrigin-RevId: 075db56032354d782e489b5235925f55b1a67e0b
2021-03-24 03:04:41 +00:00
Paulo Jorge Reis 2051caf28e New compile UI admin panel (#3666)
* Extract new logs UI feature check to a helper function

* Add new logs UI per-user availability to the admin panel

* Stub NewLogsUIHelper in the unit tests

GitOrigin-RevId: b5344448d507c7cd7422b342286ada2b839b1785
2021-02-18 03:05:20 +00:00
Jakob Ackermann 6eeb7857e3 Merge pull request #3390 from overleaf/jpa-faster-unit-tests
[perf] faster unit tests

GitOrigin-RevId: 188b8f3752638fde7a27a8d83b416bb9a6e3c95e
2020-11-28 03:04:01 +00:00
Miguel Serrano 120df0bfa2 Merge pull request #3314 from overleaf/jpa-i18n-safe-html-substitute
[misc] i18n: safe html substitute

GitOrigin-RevId: be74605d24084b419324509a403933cf71ed1c8a
2020-10-28 03:04:27 +00:00
Timothée Alby 35ef98781f Merge pull request #2692 from overleaf/ta-authorization-helper
Add Authorizationhelper

GitOrigin-RevId: 35fa8d8fc005c9eb171621c872010e6c831ba8f6
2020-04-02 03:19:40 +00:00
Simon Detheridge 6c005da303 Merge pull request #2201 from overleaf/hb-relative-path-fix
Handle double slash case of safe redirect paths

GitOrigin-RevId: fb6e8ea9d736a65df61f07d563235262b8aaf0f3
2019-10-04 14:21:52 +00:00
Simon Detheridge 8ec2f1a896 Merge pull request #2157 from overleaf/jel-saml-logout-redirect
Redirect handling after logging out

GitOrigin-RevId: 01562dbe71ff4f3571fb0d433b96ccca34aad24e
2019-09-25 14:48:19 +00:00