Commit Graph

35 Commits

Author SHA1 Message Date
Simon Detheridge 56dcbefb5b Check for safe paths in all ProjectEntityHandler methods
Some import mechanisms (for example, Github project import) call methods such as 'upsert*' directly, bypassing existing filename checks.

Added checks to all methods in ProjectEntityHandler that can create or rename a file.

bug: overleaf/sharelatex#908
Signed-off-by: Simon Detheridge <s@sd.ai>
2018-10-08 15:31:04 +01:00
James Allen ef11161ddb Revert "Record and show last modified by user for projects" 2018-09-13 14:00:30 +01:00
James Allen ab10336110 Record last update time and user from project-history 2018-09-13 10:38:52 +01:00
Shane Kilkelly 5abb745e05 Copy linkedFileData when cloning a project 2018-06-22 10:00:39 +01:00
Brian Gough c4f3a12ce5 add missing locking to copyFileFromExistingProject 2018-05-31 14:51:32 +01:00
Brian Gough 2bb2d9615f added comment about using a project entity iterator 2018-05-08 13:37:33 +01:00
Brian Gough f34ce5b12b rename _updateProjectStructure to _updateProjectStructureWithDeletedEntity 2018-05-08 13:37:33 +01:00
Brian Gough 1278e2da45 fix project structure version when deleting folder 2018-05-08 13:37:33 +01:00
Alasdair Smith ad1df3532f Merge pull request #490 from sharelatex/hof-deleted-project-history
Pass project history id with updates
2018-04-23 10:05:07 +01:00
James Allen 9e525702c1 Merge branch 'master' into ja-restore-files 2018-04-16 16:14:31 +01:00
Hayden Faulds 9ef40902ca send projectHistoryId with resync requests 2018-04-13 13:45:03 +01:00
Hayden Faulds 3006d018d9 send projectHistoryId with project structure updates 2018-04-13 13:45:03 +01:00
Brian Gough 882b555433 create new file on replace 2018-04-09 12:05:08 +01:00
Brian Gough 1a68f768d4 rename internal method uploadFile to _uploadFile 2018-04-09 12:05:08 +01:00
Brian Gough 38dab1c82c clean up whitespace 2018-04-09 12:05:08 +01:00
Brian Gough e29c657c8a preserve original callback signature for addFile 2018-04-09 12:05:08 +01:00
Brian Gough b551f3c7e9 fix indentation 2018-04-09 12:05:08 +01:00
Brian Gough 61b192fb2c fix indentation of comment 2018-04-09 12:05:07 +01:00
Brian Gough fe8897d757 refactor addFile and addFileWithOutUpdatingHistory 2018-04-09 12:05:07 +01:00
Brian Gough d949338ed4 separate out file uploads 2018-04-09 12:05:07 +01:00
Brian Gough cdfa2de68d add comment about upsert and locking 2018-04-09 12:05:07 +01:00
Brian Gough baec4eb195 move uploads outside the lock 2018-04-09 12:05:07 +01:00
James Allen 1e8439a2c6 Fix restore of docs from old deleted docs 2018-04-06 10:30:13 +01:00
Hayden Faulds 57de597e60 404 when resyncing deleting projects 2018-03-16 15:26:19 +00:00
Hayden Faulds 482d140716 add overleaf to projection 2018-03-16 13:29:22 +00:00
Hayden Faulds d22d8324af disable history resync when project-history is not enabled 2018-03-15 16:57:39 +00:00
Hayden Faulds 5b2e7d981a resyncProject -> resyncProjectHistory 2018-03-09 11:11:06 +00:00
Hayden Faulds 926f91dd3b wrap project resync in project structure lock 2018-03-09 11:11:06 +00:00
James Allen 85f25b810c First pass at URL based linked files 2018-03-05 10:37:00 +00:00
Hayden Faulds e50c3837bc add extra metrics around locking 2018-02-19 12:15:02 +00:00
Hayden Faulds 693c8e8c60 move where lock keys are defined 2018-02-16 14:44:21 +00:00
Hayden Faulds 95b82a3c9d use ProjectGetter in ProjectLocator.findElementByPath 2018-02-16 14:44:21 +00:00
Hayden Faulds cbc6fb232d add mongo transaction lock when getting or updating projects 2018-02-16 14:44:21 +00:00
Hayden Faulds e9b218fe5f allow the updating of doc lines for deleted docs 2018-02-13 14:39:38 +00:00
Hayden Faulds 458bbc7cfd refactor ProjectEntityHandler
- moves project locking into ProjectEntityHandler
- splits ProjectEntityHandler into ProjectEntityHandler,
  ProjectEntityUpdateHandler and ProjectEntityMongoUpdateHandler
- adds upsertDoc/upsertFile and upsertDocWithPath/upsertFileWithPath to
  EditorController and ProjectEntiyUpdateHandler
2018-02-12 13:33:59 +00:00