mirror of
https://github.com/yu-i-i/overleaf-cep.git
synced 2026-11-12 21:23:45 +01:00
John Lees-MillerandClaude Opus 5
1ecdd122d0
* upsert: migrate US/CA PayPal without a payment method when flagged getPaymentMethod no longer throws for a PayPal billing agreement destined for Stripe US/CA when the account is flagged ignore_payment_method; instead it returns null so the customer is migrated without a default payment method (the send_invoice paymentMethodPending flow). Unflagged accounts still throw. * finalize: expect the plan-code remap for legacy-plan subscriptions When a subscription carries legacy_remap=1 metadata, compare the Stripe product's planCode against the recorded target plan code instead of the raw Recurly plan code, so the intentional remap is not misread as drift (the price is preserved, so the amount comparison is unchanged). Clear the legacy_remap metadata during post-migration cleanup. * finalize: expect the assistant add-on reprice When a subscription carries assist_addon_repriced=1 metadata, compare the assistant item against the recorded target amount (Stripe minor units) instead of the raw Recurly amount, so the intended reprice is not misread as drift. Clear the reprice metadata during post-migration cleanup. * create_coupons: create migration coupons by name with amount_off, currency and product scope Create the pipeline's per-region coupon_specs_<region>.csv coupons by name (idempotent, auto-paginated), supporting amount_off + currency (fixed) or percent_off, duration, and applies_to.products, with no promotion code. Region comes from the existing --region flag. The existing name-based percent-off + promotion-code path is unchanged. * finalize: schedule the pending change as a phase 2 For a subscription flagged pending_change_scheduled, compare drift against the current Recurly state (not the pending change), then in Step 7 release the toolkit schedule and create a fresh two-phase subscription schedule (current until renewal; pending state from renewal with proration disabled and end_behavior release), clearing the scheduling metadata once the schedule exists. * finalize: flag address-pending migrations and push the needs_to_update_address trait When a migrated subscription carries metadata.addressPending, append -address-pending to the finalization status and push needs_to_update_address to customer.io (alongside the existing tax-info-pending handling), so the customer can be driven to add a billing address. The flag stays on the subscription so the customer.updated webhook can enable automatic_tax and clear it once the address resolves. * webhook: heal address-pending migrations when the tax location resolves On customer.updated (address/tax change), for a customer whose location is no longer unrecognized_location, enable automatic_tax on their migrated subscriptions still flagged metadata.addressPending and clear the flag. Enabling automatic_tax is rejected by Stripe while the location is still invalid, so the update is a safe idempotent no-op until the address is fixed; the cancellation state is never touched. * cron: cancel unresolved address-pending subscriptions before they renew untaxed Backstop for the address-pending cohort: searches the address-pending subscriptions in a region and, for any about to renew (within a configurable lead window) whose customer location is still unrecognized_location, cancels it at period end so it never renews untaxed. Skips subscriptions that are already cancelling and those whose location has resolved (healed by the webhook). Dry-run unless --commit. * upsert: set tax.validate_location=auto on customer update Conform PAN-copied customers to the account's default tax-location validation. Uses 'auto' rather than 'immediately' (which throws for country-only addresses and would break the address-pending migration flow). * finalize-migration: send payment method info to customer.io Add payment_method (card/paypal/none) and needs_to_add_payment_method traits to the stripe_migration customer.io payload so the migration email campaign can personalise per payment method without enumerating the full cross-join. The payment method is read from the already-fetched customer/subscription (default_payment_method now expanded on that fetch), so no extra Stripe request is made. Also report a -payment-method-pending status suffix in the CSV output. * upsert: flag customers whose address Stripe cannot resolve After pushing the Recurly address, read customer.tax.automatic_tax; when it is 'unrecognized_location', record address_unrecognized in the output so the subscription is migrated untaxed (address-pending) instead of failing at the billing-migration toolkit. This is the authoritative, region-agnostic detector (covers US/CA country-only and broken non-US addresses, e.g. India with a postal but no state/city). Adds isCustomerAddressUnrecognized helper + unit tests. * Close reactivation-without-valid-address loophole * webhook: detect newly-set address/tax with !== undefined Review follow-up: the address-pending heal guard used a truthy check, which would miss an address newly set from empty. Harmonise with _billingChanges, which already uses !== undefined. * upsert: set tax.validate_location via customerParams Review follow-up: move the tax.validate_location='auto' directive into the assembled customerParams instead of overriding it inline at the update call, so it also appears in the dry-run output. * create_coupons: guard migration coupons against ambiguous discount specs Review follow-up: throw a clear per-coupon error if a migration coupon spec has neither or both of amount_off/percent_off, catching data-processing issues instead of silently sending percent_off=NaN. * Rely on presence of customer.tax * webhook: cover the address-pending heal path in unit tests The customer.updated fixtures carried no `tax` hash and the mocked region client had no `stripe` property, so the one test that reached the heal branch threw and was swallowed by the caller's error handler. The heal logic had no real coverage as a result. Add the missing fixture fields and tests covering the heal itself, the still-unrecognized early return, the skip rules for unflagged and cancelled subscriptions, the Stripe rejection path that leaves the flag set, and the missing-tax guard. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com> GitOrigin-RevId: 8162e3e0f01e136d3aa560c22e98f43e36da4eb5