mirror of
https://github.com/yu-i-i/overleaf-cep.git
synced 2026-11-12 21:23:45 +01:00
Jakob Ackermann
f6bb5ce1bd
* [editor-core] extend coverage of zod schemas * [real-time] adopt strict zod types and extend test coverage * [project-history] make type check happy * [web] make type check happy GitOrigin-RevId: e1a65b9b3560b31ad2af817067a4b549865a5bb1
110 lines
3.4 KiB
JavaScript
110 lines
3.4 KiB
JavaScript
// TODO: This file was created by bulk-decaffeinate.
|
|
// Fix any style issues and re-enable lint.
|
|
/*
|
|
* decaffeinate suggestions:
|
|
* DS102: Remove unnecessary code created because of implicit returns
|
|
* Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md
|
|
*/
|
|
import async from 'async'
|
|
import {
|
|
fetchJson,
|
|
fetchNothing,
|
|
RequestFailedError,
|
|
} from '@overleaf/fetch-utils'
|
|
import { expect } from 'chai'
|
|
import RealTimeClient from './helpers/RealTimeClient.js'
|
|
import FixturesManager from './helpers/FixturesManager.js'
|
|
|
|
describe('HttpControllerTests', function () {
|
|
describe('without a user', function () {
|
|
it('should return 404 for the client view', async function () {
|
|
const clientId = 'not-existing'
|
|
try {
|
|
await fetchNothing(`http://127.0.0.1:3026/clients/${clientId}`)
|
|
expect.fail('request should have failed')
|
|
} catch (error) {
|
|
expect(error).to.be.instanceof(RequestFailedError)
|
|
expect(error.response.status).to.equal(404)
|
|
}
|
|
})
|
|
|
|
it('should return a schema-validation 404 for a __proto__-shaped client id', async function () {
|
|
const clientId = '__proto__'
|
|
try {
|
|
await fetchNothing(`http://127.0.0.1:3026/clients/${clientId}`)
|
|
expect.fail('request should have failed')
|
|
} catch (error) {
|
|
expect(error).to.be.instanceof(RequestFailedError)
|
|
expect(error.response.status).to.equal(404)
|
|
// The domain-level 404 (`res.sendStatus(404)` for an id that parses
|
|
// but has no matching client) has no JSON body. Asserting a JSON
|
|
// body with a statusCode/error here proves this request was
|
|
// rejected by the client_id schema (InvalidParamsError via
|
|
// handleValidationError), not by the "client not found" check.
|
|
const body = JSON.parse(error.body)
|
|
expect(body).to.have.property('statusCode', 404)
|
|
expect(body.error).to.be.a('string')
|
|
}
|
|
})
|
|
})
|
|
|
|
describe('with a user and after joining a project', function () {
|
|
before(function (done) {
|
|
async.series(
|
|
[
|
|
cb => {
|
|
FixturesManager.setUpProject(
|
|
{
|
|
privilegeLevel: 'owner',
|
|
},
|
|
(error, { project_id: projectId, user_id: userId }) => {
|
|
this.project_id = projectId
|
|
this.user_id = userId
|
|
cb(error)
|
|
}
|
|
)
|
|
},
|
|
|
|
cb => {
|
|
FixturesManager.setUpDoc(
|
|
this.project_id,
|
|
{},
|
|
(error, { doc_id: docId }) => {
|
|
this.doc_id = docId
|
|
cb(error)
|
|
}
|
|
)
|
|
},
|
|
|
|
cb => {
|
|
this.client = RealTimeClient.connect(this.project_id, cb)
|
|
},
|
|
|
|
cb => {
|
|
this.client.emit('joinDoc', this.doc_id, cb)
|
|
},
|
|
],
|
|
done
|
|
)
|
|
})
|
|
|
|
it('should send a client view', async function () {
|
|
const data = await fetchJson(
|
|
`http://127.0.0.1:3026/clients/${this.client.socket.sessionid}`
|
|
)
|
|
expect(data.connected_time).to.exist
|
|
delete data.connected_time
|
|
// .email is not set in the session
|
|
delete data.email
|
|
expect(data).to.deep.equal({
|
|
client_id: this.client.socket.sessionid,
|
|
first_name: 'Joe',
|
|
last_name: 'Bloggs',
|
|
project_id: this.project_id,
|
|
user_id: this.user_id,
|
|
rooms: [this.project_id],
|
|
})
|
|
})
|
|
})
|
|
})
|