Files
overleaf-cep/services/web/app/src/Features/SplitTests/SplitTestHandler.js
Jimmy Domagala-Tang ffd259c233 Merge pull request #19053 from overleaf/ab-split-tests-first-time-assignments
[web] Return isFirstTimeAssignment flag with split test assignments

GitOrigin-RevId: 70954470fbd9430749d83d8d1e08a3969d4a09e6
2024-06-25 08:04:37 +00:00

613 lines
18 KiB
JavaScript

const Metrics = require('@overleaf/metrics')
const UserUpdater = require('../User/UserUpdater')
const AnalyticsManager = require('../Analytics/AnalyticsManager')
const LocalsHelper = require('./LocalsHelper')
const crypto = require('crypto')
const _ = require('lodash')
const { callbackify } = require('util')
const SplitTestCache = require('./SplitTestCache')
const { SplitTest } = require('../../models/SplitTest')
const UserAnalyticsIdCache = require('../Analytics/UserAnalyticsIdCache')
const Features = require('../../infrastructure/Features')
const SplitTestUtils = require('./SplitTestUtils')
const Settings = require('@overleaf/settings')
const SessionManager = require('../Authentication/SessionManager')
const logger = require('@overleaf/logger')
const SplitTestSessionHandler = require('./SplitTestSessionHandler')
const SplitTestUserGetter = require('./SplitTestUserGetter')
/**
* @typedef {import("./types").Assignment} Assignment
*/
const DEFAULT_VARIANT = 'default'
const ALPHA_PHASE = 'alpha'
const BETA_PHASE = 'beta'
const RELEASE_PHASE = 'release'
const DEFAULT_ASSIGNMENT = {
variant: DEFAULT_VARIANT,
metadata: {},
}
/**
* Get the assignment of a user to a split test and store it in the response locals context
*
* @example
* // Assign user and record an event
*
* const assignment = await SplitTestHandler.getAssignment(req, res, 'example-project')
* if (assignment.variant === 'awesome-new-version') {
* // execute my awesome change
* }
* else {
* // execute the default behaviour (control group)
* }
*
* @param req the request
* @param res the Express response object
* @param splitTestName the unique name of the split test
* @param options {Object<sync: boolean>} - for test purposes only, to force the synchronous update of the user's profile
* @returns {Promise<Assignment>}
*/
async function getAssignment(req, res, splitTestName, { sync = false } = {}) {
const query = req.query || {}
let assignment
try {
if (!Features.hasFeature('saas')) {
assignment = _getNonSaasAssignment(splitTestName)
} else {
await _loadSplitTestInfoInLocals(res.locals, splitTestName, req.session)
// Check the query string for an override, ignoring an invalid value
const queryVariant = query[splitTestName]
if (queryVariant) {
const variants = await _getVariantNames(splitTestName)
if (variants.includes(queryVariant)) {
assignment = {
variant: queryVariant,
metadata: {},
}
}
}
if (!assignment) {
const { userId, analyticsId } = AnalyticsManager.getIdsFromSession(
req.session
)
assignment = await _getAssignment(splitTestName, {
analyticsId,
userId,
session: req.session,
sync,
})
SplitTestSessionHandler.collectSessionStats(req.session)
}
}
} catch (error) {
logger.error({ err: error }, 'Failed to get split test assignment')
assignment = DEFAULT_ASSIGNMENT
}
LocalsHelper.setSplitTestVariant(
res.locals,
splitTestName,
assignment.variant
)
return assignment
}
/**
* Get the assignment of a user to a split test by their user ID.
*
* Warning: this does not support query parameters override, nor makes the assignment and split test info available to
* the frontend through locals. Wherever possible, `getAssignment` should be used instead.
*
* @param userId the user ID
* @param splitTestName the unique name of the split test
* @param options {Object<sync: boolean>} - for test purposes only, to force the synchronous update of the user's profile
* @returns {Promise<Assignment>}
*/
async function getAssignmentForUser(
userId,
splitTestName,
{ sync = false } = {}
) {
try {
if (!Features.hasFeature('saas')) {
return _getNonSaasAssignment(splitTestName)
}
const analyticsId = await UserAnalyticsIdCache.get(userId)
return _getAssignment(splitTestName, { analyticsId, userId, sync })
} catch (error) {
logger.error({ err: error }, 'Failed to get split test assignment for user')
return DEFAULT_ASSIGNMENT
}
}
/**
* Get the assignment of a user to a split test by their pre-fetched mongo doc.
*
* Warning: this does not support query parameters override, nor makes the assignment and split test info available to
* the frontend through locals. Wherever possible, `getAssignment` should be used instead.
*
* @param user the user
* @param splitTestName the unique name of the split test
* @param options {Object<sync: boolean>} - for test purposes only, to force the synchronous update of the user's profile
* @returns {Promise<Assignment>}
*/
async function getAssignmentForMongoUser(
user,
splitTestName,
{ sync = false } = {}
) {
try {
if (!Features.hasFeature('saas')) {
return _getNonSaasAssignment(splitTestName)
}
return _getAssignment(splitTestName, {
analyticsId: await UserAnalyticsIdCache.get(user._id),
sync,
user,
userId: user._id.toString(),
})
} catch (error) {
logger.error(
{ err: error },
'Failed to get split test assignment for mongo user'
)
return DEFAULT_ASSIGNMENT
}
}
/**
* Get a mapping of the active split test assignments for the given user
*/
async function getActiveAssignmentsForUser(userId, removeArchived = false) {
if (!Features.hasFeature('saas')) {
return {}
}
const user = await SplitTestUserGetter.promises.getUser(userId)
if (user == null) {
return {}
}
const splitTests = await SplitTest.find({
$where: 'this.versions[this.versions.length - 1].active',
...(removeArchived && { archived: { $ne: true } }),
}).exec()
const assignments = {}
for (const splitTest of splitTests) {
const { activeForUser, selectedVariantName, phase, versionNumber } =
await _getAssignmentMetadata(user.analyticsId, user, splitTest)
if (activeForUser) {
const assignment = {
variantName: selectedVariantName,
versionNumber,
phase,
}
const userAssignments = user.splitTests?.[splitTest.name]
if (Array.isArray(userAssignments)) {
const userAssignment = userAssignments.find(
x => x.versionNumber === versionNumber
)
if (userAssignment) {
assignment.assignedAt = userAssignment.assignedAt
}
}
assignments[splitTest.name] = assignment
}
}
return assignments
}
/**
* Performs a one-time assignment that is not recorded nor reproducible.
* To be used only in cases where we need random assignments that are independent of a user or session.
* If the test is in alpha or beta phase, always returns the default variant.
* @param splitTestName
* @returns {Promise<Assignment>}
*/
async function getOneTimeAssignment(splitTestName) {
try {
if (!Features.hasFeature('saas')) {
return _getNonSaasAssignment(splitTestName)
}
const splitTest = await _getSplitTest(splitTestName)
if (!splitTest) {
return DEFAULT_ASSIGNMENT
}
const currentVersion = SplitTestUtils.getCurrentVersion(splitTest)
if (currentVersion.phase !== RELEASE_PHASE) {
return DEFAULT_ASSIGNMENT
}
const randomUUID = crypto.randomUUID()
const { selectedVariantName } = await _getAssignmentMetadata(
randomUUID,
undefined,
splitTest
)
return _makeAssignment({
variant: selectedVariantName,
currentVersion,
isFirstNonDefaultAssignment:
selectedVariantName !== DEFAULT_VARIANT &&
currentVersion.analyticsEnabled,
})
} catch (error) {
logger.error({ err: error }, 'Failed to get one time split test assignment')
return DEFAULT_ASSIGNMENT
}
}
/**
* Returns an array of valid variant names for the given split test, including default
*
* @param splitTestName
* @returns {Promise<string[]>}
* @private
*/
async function _getVariantNames(splitTestName) {
const splitTest = await _getSplitTest(splitTestName)
const currentVersion = SplitTestUtils.getCurrentVersion(splitTest)
if (currentVersion?.active) {
return currentVersion.variants.map(v => v.name).concat([DEFAULT_VARIANT])
} else {
return [DEFAULT_VARIANT]
}
}
async function _getAssignment(
splitTestName,
{ analyticsId, user, userId, session, sync }
) {
if (!analyticsId && !userId) {
return DEFAULT_ASSIGNMENT
}
const splitTest = await _getSplitTest(splitTestName)
const currentVersion = SplitTestUtils.getCurrentVersion(splitTest)
if (Settings.devToolbar.enabled) {
const override = session?.splitTestOverrides?.[splitTestName]
if (override) {
return _makeAssignment({ variant: override, currentVersion })
}
}
if (!currentVersion?.active) {
return DEFAULT_ASSIGNMENT
}
// Do not cache assignments for anonymous users. All the context for their assignments is in the session:
// They cannot be part of the alpha or beta program, and they will use their analyticsId for assignments.
const canUseSessionCache = session && SessionManager.isUserLoggedIn(session)
if (session && !canUseSessionCache) {
// Purge the existing cache
delete session.cachedSplitTestAssignments
}
if (canUseSessionCache) {
const cachedVariant = SplitTestSessionHandler.getCachedVariant(
session,
splitTest.name,
currentVersion
)
if (cachedVariant) {
Metrics.inc('split_test_get_assignment_source', 1, { status: 'cache' })
if (
cachedVariant ===
SplitTestSessionHandler.CACHE_TOMBSTONE_SPLIT_TEST_NOT_ACTIVE_FOR_USER
) {
return DEFAULT_ASSIGNMENT
} else {
return _makeAssignment({
variant: cachedVariant,
currentVersion,
isFirstNonDefaultAssignment: false,
})
}
}
}
if (user) {
Metrics.inc('split_test_get_assignment_source', 1, { status: 'provided' })
} else if (userId) {
Metrics.inc('split_test_get_assignment_source', 1, { status: 'mongo' })
} else {
Metrics.inc('split_test_get_assignment_source', 1, { status: 'none' })
}
user =
user ||
(userId &&
(await SplitTestUserGetter.promises.getUser(userId, splitTestName)))
const metadata = await _getAssignmentMetadata(analyticsId, user, splitTest)
const { activeForUser, selectedVariantName, phase, versionNumber } = metadata
if (canUseSessionCache) {
SplitTestSessionHandler.setVariantInCache({
session,
splitTestName,
currentVersion,
selectedVariantName,
activeForUser,
})
}
if (activeForUser) {
if (currentVersion.analyticsEnabled) {
// if the user is logged in, persist the assignment
if (userId) {
const assignmentData = {
user,
userId,
splitTestName,
phase,
versionNumber,
variantName: selectedVariantName,
}
if (sync === true) {
await _recordAssignment(assignmentData)
} else {
_recordAssignment(assignmentData).catch(err => {
logger.warn(
{
err,
userId,
splitTestName,
phase,
versionNumber,
variantName: selectedVariantName,
},
'failed to record split test assignment'
)
})
}
}
// otherwise this is an anonymous user, we store assignments in session to persist them on registration
else {
await SplitTestSessionHandler.promises.appendAssignment(session, {
splitTestId: splitTest._id,
splitTestName,
phase,
versionNumber,
variantName: selectedVariantName,
assignedAt: new Date(),
})
}
const effectiveAnalyticsId = user?.analyticsId || analyticsId || userId
AnalyticsManager.setUserPropertyForAnalyticsId(
effectiveAnalyticsId,
`split-test-${splitTestName}-${versionNumber}`,
selectedVariantName
).catch(err => {
logger.warn(
{
err,
analyticsId: effectiveAnalyticsId,
splitTest: splitTestName,
versionNumber,
variant: selectedVariantName,
},
'failed to set user property for analytics id'
)
})
}
let isFirstNonDefaultAssignment
if (userId) {
isFirstNonDefaultAssignment = metadata.isFirstNonDefaultAssignment
} else {
const assignments =
await SplitTestSessionHandler.promises.getAssignments(session)
isFirstNonDefaultAssignment = !assignments?.[splitTestName]
}
return _makeAssignment({
variant: selectedVariantName,
currentVersion,
isFirstNonDefaultAssignment,
})
}
return DEFAULT_ASSIGNMENT
}
async function _getAssignmentMetadata(analyticsId, user, splitTest) {
const currentVersion = SplitTestUtils.getCurrentVersion(splitTest)
const phase = currentVersion.phase
if (
(phase === ALPHA_PHASE && !user?.alphaProgram) ||
(phase === BETA_PHASE && !user?.betaProgram)
) {
return {
activeForUser: false,
}
}
const userId = user?._id.toString()
const percentile = getPercentile(analyticsId || userId, splitTest.name, phase)
const selectedVariantName =
_getVariantFromPercentile(currentVersion.variants, percentile) ||
DEFAULT_VARIANT
return {
activeForUser: true,
selectedVariantName,
phase,
versionNumber: currentVersion.versionNumber,
isFirstNonDefaultAssignment:
selectedVariantName !== DEFAULT_VARIANT &&
currentVersion.analyticsEnabled &&
(!Array.isArray(user?.splitTests?.[splitTest.name]) ||
!user?.splitTests?.[splitTest.name]?.some(
assignment => assignment.variantName !== DEFAULT_VARIANT
)),
}
}
function getPercentile(analyticsId, splitTestName, splitTestPhase) {
const hash = crypto
.createHash('md5')
.update(analyticsId + splitTestName + splitTestPhase)
.digest('hex')
const hashPrefix = hash.substr(0, 8)
return Math.floor(
((parseInt(hashPrefix, 16) % 0xffffffff) / 0xffffffff) * 100
)
}
function setOverrideInSession(session, splitTestName, variantName) {
if (!Settings.devToolbar.enabled) {
return
}
if (!session.splitTestOverrides) {
session.splitTestOverrides = {}
}
session.splitTestOverrides[splitTestName] = variantName
}
function clearOverridesInSession(session) {
delete session.splitTestOverrides
}
function _getVariantFromPercentile(variants, percentile) {
for (const variant of variants) {
for (const stripe of variant.rolloutStripes) {
if (percentile >= stripe.start && percentile < stripe.end) {
return variant.name
}
}
}
}
async function _recordAssignment({
user,
userId,
splitTestName,
phase,
versionNumber,
variantName,
}) {
const persistedAssignment = {
variantName,
versionNumber,
phase,
assignedAt: new Date(),
}
user =
user || (await SplitTestUserGetter.promises.getUser(userId, splitTestName))
if (user) {
const assignedSplitTests = user.splitTests || []
const assignmentLog = assignedSplitTests[splitTestName] || []
const existingAssignment = _.find(assignmentLog, { versionNumber })
if (!existingAssignment) {
await UserUpdater.promises.updateUser(userId, {
$addToSet: {
[`splitTests.${splitTestName}`]: persistedAssignment,
},
})
}
}
}
function _makeAssignment({
variant,
currentVersion,
isFirstNonDefaultAssignment,
}) {
return {
variant,
metadata: {
phase: currentVersion.phase,
versionNumber: currentVersion.versionNumber,
isFirstNonDefaultAssignment,
},
}
}
async function _loadSplitTestInfoInLocals(locals, splitTestName, session) {
const splitTest = await _getSplitTest(splitTestName)
if (splitTest) {
const override = session?.splitTestOverrides?.[splitTestName]
const currentVersion = SplitTestUtils.getCurrentVersion(splitTest)
if (!currentVersion.active && !Settings.devToolbar.enabled) {
return
}
const phase = currentVersion.phase
const info = {
phase,
badgeInfo: splitTest.badgeInfo?.[phase],
}
if (Settings.devToolbar.enabled) {
info.active = currentVersion.active
info.variants = currentVersion.variants.map(variant => ({
name: variant.name,
rolloutPercent: variant.rolloutPercent,
}))
info.hasOverride = !!override
}
LocalsHelper.setSplitTestInfo(locals, splitTestName, info)
} else if (Settings.devToolbar.enabled) {
LocalsHelper.setSplitTestInfo(locals, splitTestName, {
missing: true,
})
}
}
function _getNonSaasAssignment(splitTestName) {
if (Settings.splitTestOverrides?.[splitTestName]) {
return {
variant: Settings.splitTestOverrides?.[splitTestName],
metadata: {},
}
}
return DEFAULT_ASSIGNMENT
}
async function _getSplitTest(name) {
const splitTests = await SplitTestCache.get('')
const splitTest = splitTests?.get(name)
if (splitTest && !splitTest.archived) {
return splitTest
}
}
async function isSplitTestActive(splitTestName) {
try {
const splitTest = await _getSplitTest(splitTestName)
const currentVersion = SplitTestUtils.getCurrentVersion(splitTest)
return currentVersion?.active
} catch (e) {
logger.log('unable to check if split test is active ', splitTestName)
}
}
module.exports = {
getPercentile,
getAssignment: callbackify(getAssignment),
getAssignmentForMongoUser: callbackify(getAssignmentForMongoUser),
getAssignmentForUser: callbackify(getAssignmentForUser),
getOneTimeAssignment: callbackify(getOneTimeAssignment),
getActiveAssignmentsForUser: callbackify(getActiveAssignmentsForUser),
setOverrideInSession,
clearOverridesInSession,
promises: {
getAssignment,
getAssignmentForMongoUser,
getAssignmentForUser,
getOneTimeAssignment,
getActiveAssignmentsForUser,
isSplitTestActive,
},
}