From 076ca4ebbb7fd227ea4679f2146e329109fc3e6a Mon Sep 17 00:00:00 2001 From: DEV-bot Date: Sun, 15 Mar 2026 13:27:25 +0000 Subject: [PATCH] test(gameplay): lock canonical reveal payload across scoreboard --- frontend/tests/angular-api-client.test.ts | 77 +++++++++++++++++++++++ lobby/tests.py | 37 +++++++++++ 2 files changed, 114 insertions(+) diff --git a/frontend/tests/angular-api-client.test.ts b/frontend/tests/angular-api-client.test.ts index c0b9eb5..d0f2aef 100644 --- a/frontend/tests/angular-api-client.test.ts +++ b/frontend/tests/angular-api-client.test.ts @@ -206,6 +206,83 @@ describe('createAngularApiClient', () => { } }); + it('keeps canonical reveal payload stable when session detail is already in scoreboard phase', async () => { + const get = vi.fn(async (url: string) => { + if (url === '/lobby/sessions/ABCD12') { + return { + session: { code: 'ABCD12', status: 'scoreboard', host_id: 1, current_round: 1, players_count: 2 }, + players: [ + { id: 2, nickname: 'Maja', score: 10, is_connected: true }, + { id: 3, nickname: 'Bo', score: 7, is_connected: true } + ], + round_question: { + id: 77, + round_number: 1, + prompt: 'Q?', + shown_at: '2026-03-01T18:00:00Z', + answers: [{ text: 'A' }, { text: 'B' }] + }, + reveal: { + round_question_id: 77, + round_number: 1, + prompt: 'Q?', + correct_answer: 'A', + lies: [{ player_id: 2, nickname: 'Maja', text: 'B', created_at: '2026-03-01T18:00:05Z' }], + guesses: [ + { + player_id: 3, + nickname: 'Bo', + selected_text: 'B', + is_correct: false, + fooled_player_id: 2, + fooled_player_nickname: 'Maja', + created_at: '2026-03-01T18:00:15Z' + } + ] + }, + phase_view_model: { + status: 'scoreboard', + round_number: 1, + players_count: 2, + constraints: { + min_players_to_start: 2, + max_players_mvp: 8, + min_players_reached: true, + max_players_allowed: true + }, + host: { + can_start_round: false, + can_show_question: false, + can_mix_answers: false, + can_calculate_scores: false, + can_reveal_scoreboard: false, + can_start_next_round: true, + can_finish_game: true + }, + player: { + can_join: true, + can_submit_lie: false, + can_submit_guess: false, + can_view_final_result: false + } + } + } as T; + } + throw { status: 404, error: { error: 'Not found' } }; + }); + + const client = createAngularApiClient({ get, post: vi.fn() } as unknown as AngularHttpClientLike); + const session = await client.getSession('abcd12'); + + expect(session.ok).toBe(true); + if (session.ok) { + expect(session.data.session.status).toBe('scoreboard'); + expect(session.data.reveal?.guesses[0].fooled_player_nickname).toBe('Maja'); + expect(session.data.phase_view_model.host.can_start_next_round).toBe(true); + expect(session.data.phase_view_model.host.can_finish_game).toBe(true); + } + }); + it('maps host/player gameplay endpoints through typed response mappers', async () => { const get = vi.fn(async (url: string) => { if (url === '/lobby/sessions/ABCD12/scoreboard') { diff --git a/lobby/tests.py b/lobby/tests.py index d69562f..15deaca 100644 --- a/lobby/tests.py +++ b/lobby/tests.py @@ -1463,11 +1463,48 @@ class SessionDetailRoundQuestionTests(TestCase): self.assertEqual(payload["reveal"]["round_question_id"], round_question.id) self.assertEqual(payload["reveal"]["correct_answer"], "Edison") self.assertEqual(payload["reveal"]["lies"][0]["player_id"], liar.id) + self.assertEqual(payload["reveal"]["lies"][0]["nickname"], "Løgnhals") + self.assertEqual(payload["reveal"]["lies"][0]["text"], "Tesla") self.assertEqual(payload["reveal"]["guesses"][0]["player_id"], guesser.id) + self.assertEqual(payload["reveal"]["guesses"][0]["selected_text"], "Tesla") self.assertEqual(payload["reveal"]["guesses"][0]["fooled_player_id"], liar.id) self.assertEqual(payload["reveal"]["guesses"][0]["fooled_player_nickname"], "Løgnhals") self.assertTrue(payload["reveal"]["guesses"][1]["is_correct"]) + self.assertEqual(payload["reveal"]["guesses"][1]["selected_text"], "Edison") self.assertIsNone(payload["reveal"]["guesses"][1]["fooled_player_id"]) + self.assertIsNone(payload["reveal"]["guesses"][1].get("fooled_player_nickname")) + + def test_session_detail_preserves_canonical_reveal_payload_across_reveal_and_scoreboard(self): + round_question = RoundQuestion.objects.create( + session=self.session, + round_number=1, + question=self.question, + correct_answer=self.question.correct_answer, + ) + liar = Player.objects.create(session=self.session, nickname="Løgnhals") + guesser = Player.objects.create(session=self.session, nickname="Detektiv") + LieAnswer.objects.create(round_question=round_question, player=liar, text="Tesla") + Guess.objects.create( + round_question=round_question, + player=guesser, + selected_text="Tesla", + is_correct=False, + fooled_player=liar, + ) + + self.session.status = GameSession.Status.REVEAL + self.session.save(update_fields=["status"]) + reveal_payload = self.client.get(reverse("lobby:session_detail", kwargs={"code": self.session.code})).json() + + self.session.status = GameSession.Status.SCOREBOARD + self.session.save(update_fields=["status"]) + scoreboard_payload = self.client.get(reverse("lobby:session_detail", kwargs={"code": self.session.code})).json() + + self.assertEqual(reveal_payload["reveal"], scoreboard_payload["reveal"]) + self.assertTrue(reveal_payload["phase_view_model"]["host"]["can_reveal_scoreboard"]) + self.assertFalse(scoreboard_payload["phase_view_model"]["host"]["can_reveal_scoreboard"]) + self.assertFalse(reveal_payload["phase_view_model"]["host"]["can_start_next_round"]) + self.assertTrue(scoreboard_payload["phase_view_model"]["host"]["can_start_next_round"]) class SessionDetailPhaseViewModelTests(TestCase):