From 6cff55257271e4995cb0fa154818f1bb2d0c1961 Mon Sep 17 00:00:00 2001 From: DEV-bot Date: Sun, 1 Mar 2026 18:13:55 +0000 Subject: [PATCH] test(spa): expand angular API contract smoke for host/player endpoints (#199) --- .../src/app/api-contract-smoke.spec.ts | 195 +++++++++++++++--- 1 file changed, 166 insertions(+), 29 deletions(-) diff --git a/frontend/angular/src/app/api-contract-smoke.spec.ts b/frontend/angular/src/app/api-contract-smoke.spec.ts index 0d1010d..7be1d6a 100644 --- a/frontend/angular/src/app/api-contract-smoke.spec.ts +++ b/frontend/angular/src/app/api-contract-smoke.spec.ts @@ -3,7 +3,7 @@ import { describe, expect, it, vi } from 'vitest'; import { createAngularApiClient, type AngularHttpClientLike } from '../../../src/api/angular-client'; describe('SPA Angular API contract smoke (host/player foundation)', () => { - it('smoke-checks session read, join and start-round contracts', async () => { + it('smoke-checks canonical host/player endpoint contracts', async () => { const get = vi.fn(async (url: string) => { if (url === '/lobby/sessions/ABCD12') { return { @@ -12,7 +12,13 @@ describe('SPA Angular API contract smoke (host/player foundation)', () => { { id: 2, nickname: 'Maja', score: 0, is_connected: true }, { id: 3, nickname: 'Bo', score: 0, is_connected: true } ], - round_question: null, + round_question: { + id: 77, + round_number: 1, + prompt: 'Q?', + shown_at: '2026-03-01T18:00:00Z', + answers: [{ text: 'A' }, { text: 'B' }] + }, phase_view_model: { status: 'lobby', round_number: 1, @@ -25,23 +31,33 @@ describe('SPA Angular API contract smoke (host/player foundation)', () => { }, host: { can_start_round: true, - can_show_question: false, - can_mix_answers: false, - can_calculate_scores: false, - can_reveal_scoreboard: false, - can_start_next_round: false, - can_finish_game: false + can_show_question: true, + can_mix_answers: true, + can_calculate_scores: true, + can_reveal_scoreboard: true, + can_start_next_round: true, + can_finish_game: true }, player: { can_join: true, - can_submit_lie: false, - can_submit_guess: false, + can_submit_lie: true, + can_submit_guess: true, can_view_final_result: false } } } as T; } + if (url === '/lobby/sessions/ABCD12/scoreboard') { + return { + session: { code: 'ABCD12', status: 'reveal', current_round: 1 }, + leaderboard: [ + { id: 9, nickname: 'Maja', score: 200 }, + { id: 10, nickname: 'Bo', score: 150 } + ] + } as T; + } + throw { status: 404, error: { error: 'Not found' } }; }); @@ -62,6 +78,89 @@ describe('SPA Angular API contract smoke (host/player foundation)', () => { } as T; } + if (url === '/lobby/sessions/ABCD12/questions/show') { + expect(body).toEqual({}); + return { + round_question: { + id: 77, + prompt: 'Q?', + round_number: 1, + shown_at: '2026-03-01T18:00:00Z', + lie_deadline_at: '2026-03-01T18:00:30Z' + }, + config: { lie_seconds: 30 } + } as T; + } + + if (url === '/lobby/sessions/ABCD12/questions/77/answers/mix') { + expect(body).toEqual({}); + return { + session: { code: 'ABCD12', status: 'guess', current_round: 1 }, + round_question: { id: 77, round_number: 1 }, + answers: [{ text: 'A' }, { text: 'B' }] + } as T; + } + + if (url === '/lobby/sessions/ABCD12/questions/77/scores/calculate') { + expect(body).toEqual({}); + return { + session: { code: 'ABCD12', status: 'reveal', current_round: 1 }, + round_question: { id: 77, round_number: 1 }, + events_created: 2, + leaderboard: [ + { id: 9, nickname: 'Maja', score: 200 }, + { id: 10, nickname: 'Bo', score: 150 } + ] + } as T; + } + + if (url === '/lobby/sessions/ABCD12/rounds/next') { + expect(body).toEqual({}); + return { session: { code: 'ABCD12', status: 'lie', current_round: 2 } } as T; + } + + if (url === '/lobby/sessions/ABCD12/finish') { + expect(body).toEqual({}); + return { + session: { code: 'ABCD12', status: 'finished', current_round: 2 }, + winner: { id: 9, nickname: 'Maja', score: 250 }, + leaderboard: [ + { id: 9, nickname: 'Maja', score: 250 }, + { id: 10, nickname: 'Bo', score: 150 } + ] + } as T; + } + + if (url === '/lobby/sessions/ABCD12/questions/77/lies/submit') { + expect(body).toEqual({ player_id: 9, session_token: 'session-token-1', text: 'my lie' }); + return { + lie: { + id: 501, + player_id: 9, + round_question_id: 77, + text: 'my lie', + created_at: '2026-03-01T18:00:05Z' + }, + window: { lie_deadline_at: '2026-03-01T18:00:30Z' } + } as T; + } + + if (url === '/lobby/sessions/ABCD12/questions/77/guesses/submit') { + expect(body).toEqual({ player_id: 9, session_token: 'session-token-1', selected_text: 'B' }); + return { + guess: { + id: 601, + player_id: 9, + round_question_id: 77, + selected_text: 'B', + is_correct: false, + fooled_player_id: null, + created_at: '2026-03-01T18:00:15Z' + }, + window: { guess_deadline_at: '2026-03-01T18:01:00Z' } + } as T; + } + throw { status: 404, error: { error: 'Not found' } }; }); @@ -71,29 +170,40 @@ describe('SPA Angular API contract smoke (host/player foundation)', () => { expect(session.ok).toBe(true); if (session.ok) { expect(session.data.session.code).toBe('ABCD12'); - expect(session.data.session.host_id).toBe(1); - expect(session.data.phase_view_model.host.can_start_round).toBe(true); - expect(session.data.phase_view_model.player.can_join).toBe(true); - expect(session.data.phase_view_model.constraints.min_players_to_start).toBe(2); + expect(session.data.phase_view_model.host.can_start_next_round).toBe(true); + expect(session.data.phase_view_model.player.can_submit_guess).toBe(true); } - const join = await client.joinSession({ code: ' abcd12 ', nickname: ' Maja ' }); - expect(join.ok).toBe(true); - if (join.ok) { - expect(join.data.player.id).toBe(9); - expect(join.data.player.session_token).toBe('session-token-1'); - expect(join.data.session.code).toBe('ABCD12'); - } + expect((await client.joinSession({ code: ' abcd12 ', nickname: ' Maja ' })).ok).toBe(true); + expect((await client.startRound(' abcd12 ', { category_slug: 'history' })).ok).toBe(true); + expect((await client.showQuestion(' abcd12 ')).ok).toBe(true); + expect((await client.mixAnswers(' abcd12 ', 77)).ok).toBe(true); + expect((await client.calculateScores(' abcd12 ', 77)).ok).toBe(true); + expect((await client.getScoreboard(' abcd12 ')).ok).toBe(true); + expect((await client.startNextRound(' abcd12 ')).ok).toBe(true); + expect((await client.finishGame(' abcd12 ')).ok).toBe(true); + expect( + ( + await client.submitLie(' abcd12 ', 77, { + player_id: 9, + session_token: 'session-token-1', + text: 'my lie' + }) + ).ok + ).toBe(true); + expect( + ( + await client.submitGuess(' abcd12 ', 77, { + player_id: 9, + session_token: 'session-token-1', + selected_text: 'B' + }) + ).ok + ).toBe(true); - const start = await client.startRound(' abcd12 ', { category_slug: 'history' }); - expect(start.ok).toBe(true); - if (start.ok) { - expect(start.data.session.status).toBe('lie'); - expect(start.data.round.number).toBe(1); - expect(start.data.round.category.slug).toBe('history'); - } + expect(get).toHaveBeenNthCalledWith(1, '/lobby/sessions/ABCD12', { withCredentials: true }); + expect(get).toHaveBeenNthCalledWith(2, '/lobby/sessions/ABCD12/scoreboard', { withCredentials: true }); - expect(get).toHaveBeenCalledWith('/lobby/sessions/ABCD12', { withCredentials: true }); expect(post).toHaveBeenNthCalledWith( 1, '/lobby/sessions/join', @@ -106,5 +216,32 @@ describe('SPA Angular API contract smoke (host/player foundation)', () => { { category_slug: 'history' }, { withCredentials: true } ); + expect(post).toHaveBeenNthCalledWith(3, '/lobby/sessions/ABCD12/questions/show', {}, { withCredentials: true }); + expect(post).toHaveBeenNthCalledWith( + 4, + '/lobby/sessions/ABCD12/questions/77/answers/mix', + {}, + { withCredentials: true } + ); + expect(post).toHaveBeenNthCalledWith( + 5, + '/lobby/sessions/ABCD12/questions/77/scores/calculate', + {}, + { withCredentials: true } + ); + expect(post).toHaveBeenNthCalledWith(6, '/lobby/sessions/ABCD12/rounds/next', {}, { withCredentials: true }); + expect(post).toHaveBeenNthCalledWith(7, '/lobby/sessions/ABCD12/finish', {}, { withCredentials: true }); + expect(post).toHaveBeenNthCalledWith( + 8, + '/lobby/sessions/ABCD12/questions/77/lies/submit', + { player_id: 9, session_token: 'session-token-1', text: 'my lie' }, + { withCredentials: true } + ); + expect(post).toHaveBeenNthCalledWith( + 9, + '/lobby/sessions/ABCD12/questions/77/guesses/submit', + { player_id: 9, session_token: 'session-token-1', selected_text: 'B' }, + { withCredentials: true } + ); }); });