agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-05-23 09:09:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix Add Comment observer disconnect (#26565)

Browse Source 
GitOrigin-RevId: bb84aa25d744a9b035a70c877c934156c2675cbd
This commit is contained in:
Alf Eaton
2025-07-02 11:25:06 +01:00
committed by Copybot
parent d8d53f76ca
commit 06153de0aa
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
services/web/frontend/js/features/review-panel-new/components/review-panel-add-comment.tsx
View File

@@ -102,19 +102,25 @@ export const ReviewPanelAddComment = memo<{
}
}, [])
const observerRef = useRef<MutationObserver | null>(null)
const handleElement = useCallback(
(element: HTMLElement | null) => {
if (element) {
element.dispatchEvent(new Event('review-panel:position'))
const observer = new MutationObserver(observerCallback)
observerRef.current = new MutationObserver(observerCallback)
const entryWrapper = element.closest('.review-panel-entry')
if (entryWrapper) {
observer.observe(entryWrapper, {
observerRef.current.observe(entryWrapper, {
attributes: true,
attributeFilter: ['style'],
})
return () => observer.disconnect()
}
} else {
// [TODO React 19] return a cleanup function instead of using null element
if (observerRef.current) {
observerRef.current.disconnect()
}
}
},