agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-11-12 21:23:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #35558 from overleaf/mg-floating-menu-blank-line

Browse Source 
Calculate floating menu position using line block

GitOrigin-RevId: aaf86d7cbdbddf6e77cb58563b16708888d03d7b
This commit is contained in:
Malik Glossop
2026-09-17 11:32:55 +00:00
committed by Copybot
parent a4c55af2e7
commit 1b2da240d5
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/frontend/js/features/editor-floating-menu/editor-floating-menu.tsx
+10 -10
View File
@@ -97,22 +97,22 @@ const EditorFloatingMenuContent = memo(function EditorFloatingMenuContent() {
view.requestMeasure({
key: 'editor-floating-menu-position',
read(view) {
const lineCoords = view.coordsAtPos(
selectionBottomLinePos(view.state)
)
if (!lineCoords) {
return
}
// lineBlockAt returns a position even when the line isn't rendered on screen.
// documentTop shifts it to viewport coordinates.
const block = view.lineBlockAt(selectionBottomLinePos(view.state))
// Anchor to the line's last visual row so a wrapped line pins to its
// bottom, not its middle so that menus do not cover content.
const lineBottomY = view.documentTop + block.bottom
const lineCenterY = lineBottomY - view.defaultLineHeight / 2
const menuHeight =
menuRef.current?.getBoundingClientRect().height ?? 0
const scrollDomRect = view.scrollDOM.getBoundingClientRect()
const contentDomRect = view.contentDOM.getBoundingClientRect()
const lineCenterY = (lineCoords.top + lineCoords.bottom) / 2
// Centre on the line, but keep the menu pinned inside the editor
// viewport so it never scrolls out of view: when the anchored line
// leaves the top or bottom edge the menu rides that edge instead.
// Centre on the bottom row, but keep the menu pinned inside the
// editor viewport so it never scrolls out of view: when the anchored
// line leaves the top or bottom edge the menu rides that edge instead.
const top = Math.min(
Math.max(lineCenterY - menuHeight / 2, scrollDomRect.top),
scrollDomRect.bottom - menuHeight