agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-11-12 13:13:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

Plans Group Size - Removing the 50 size (#23851)

Browse Source 
* removing the group size 50

* removing the if condition for 20/50 groups

* running make cleanup_unused_locales

* removing instances of sizesForHighDenominationCurrencies and the related if conditions

* removing the price related to group size of 50 in different currencies

* fixing the test

* changing the 50 to 20 under faqs

* changing the remaining 50 to 20

* cleaning of variables

* removing extra variable

GitOrigin-RevId: 68f5d7df1eab29360e9c806ad844f1c900341c19
This commit is contained in:
Davinder Singh
2025-02-28 09:04:51 +00:00
committed by Copybot
parent 763e5ba82c
commit 3851ee4eb2
8 changed files with 8 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/app/src/Features/Subscription/SubscriptionController.js
-3
View File
@@ -38,9 +38,6 @@ function formatGroupPlansDataForDash() {
return {
plans: [...groupPlanModalOptions.plan_codes],
sizes: [...groupPlanModalOptions.sizes],
sizesForHighDenominationCurrencies: [
...groupPlanModalOptions.sizesForHighDenominationCurrencies,
],
usages: [...groupPlanModalOptions.usages],
priceByUsageTypeAndSize: JSON.parse(JSON.stringify(GroupPlansData)),
}
services/web/app/views/subscriptions/plans/_plans_faq_tabs.pug
+4 -4
View File
@@ -146,7 +146,7 @@ mixin overleafGroupPlans()
i.material-symbols.material-symbols-outlined(aria-hidden="true") keyboard_arrow_down
.collapse(id="overleafGroupPlansQ2")
.custom-accordion-body
| Our Group subscriptions allow you to purchase access to our premium features for multiple people. They’re easy to manage, help save on paperwork, and allow groups of 5 or more to purchase via purchase order (PO). We also offer discounts on purchases of Group subscriptions for more than 50 users; just get in touch with our
| Our Group subscriptions allow you to purchase access to our premium features for multiple people. They’re easy to manage, help save on paperwork, and allow groups of 5 or more to purchase via purchase order (PO). We also offer discounts on purchases of Group subscriptions for more than 20 users; just get in touch with our
a.inline-green-link(
target="_blank"
href="/for/contact-sales"
@@ -174,7 +174,7 @@ mixin overleafGroupPlans()
.collapse(id="overleafGroupPlansQ4")
.custom-accordion-body
div
| You can add up to 50 licenses using the
| You can add up to 20 licenses using the
a.inline-green-link(
target="_blank"
href="/user/subscription"
@@ -196,7 +196,7 @@ mixin overleafGroupPlans()
span Subscription
| when logged into Overleaf. The cost per license will be prorated at the current per license rate, and will end with your existing renewal date.
div.mt-2
| If you need more than 50 licenses added to your subscription, please
| If you need more than 20 licenses added to your subscription, please
a.inline-green-link(
target="_blank"
href="/for/contact-sales"
@@ -235,4 +235,4 @@ mixin overleafGroupPlans()
.custom-accordion-body
| Yes. To add more users to your subscription you’ll need to
button.btn-link.inline-green-link(data-ol-open-contact-form-modal="general")
span #{translate("contact_us")}
span #{translate("contact_us")}
services/web/frontend/js/features/subscription/components/dashboard/states/active/change-plan/modals/change-to-group-modal.tsx
+2 -8
View File
@@ -155,16 +155,10 @@ export function ChangeToGroupModal() {
!groupPlans ||
!groupPlans.plans ||
!groupPlans.sizes ||
!groupPlans.sizesForHighDenominationCurrencies ||
!groupPlanToChangeToCode
)
return null
const isUsingCOP = personalSubscription.recurly?.currency === 'COP'
const groupPlanSizes = isUsingCOP
? groupPlans.sizesForHighDenominationCurrencies
: groupPlans.sizes
return (
<>
<UserProvider>{contactModal}</UserProvider>
@@ -247,7 +241,7 @@ export function ChangeToGroupModal() {
value={groupPlanToChangeToSize}
onChange={e => setGroupPlanToChangeToSize(e.target.value)}
>
{groupPlanSizes.map(size => (
{groupPlans.sizes.map(size => (
<option key={`size-option-${size}`}>{size}</option>
))}
</OLFormSelect>
@@ -358,7 +352,7 @@ export function ChangeToGroupModal() {
onClick={showContactModal}
>
{t('need_more_than_x_licenses', {
x: isUsingCOP ? 20 : 50,
x: 20,
})}{' '}
{t('please_get_in_touch')}
</OLButton>
services/web/locales/en.json
-1
View File
@@ -1338,7 +1338,6 @@
"navigation": "Navigation",
"nearly_activated": "You’re one step away from activating your __appName__ account!",
"need_20_plus_users_discount": "20+ users? <0>Contact Sales</0> to get the best discounts.",
"need_50_plus_users_discount": "50+ users? <0>Contact Sales</0> to get the best discounts.",
"need_anything_contact_us_at": "If there is anything you ever need please feel free to contact us directly at",
"need_contact_group_admin_to_make_changes": "You’ll need to contact your group admin if you want to make certain changes to your account. <0>Read more about managed users.</0>",
"need_make_changes": "You need to make some changes",
services/web/test/frontend/features/subscription/components/dashboard/states/active/change-plan/change-plan.test.tsx
+1 -1
View File
@@ -387,7 +387,7 @@ describe('<ChangePlanModal />', function () {
within(modal).getByRole('button', { name: 'Upgrade now' })
within(modal).getByRole('button', {
name: 'Need more than 50 licenses? Please get in touch',
name: 'Need more than 20 licenses? Please get in touch',
})
})
services/web/test/frontend/features/subscription/fixtures/plans.ts
+1 -26
View File
@@ -226,8 +226,7 @@ export const groupPlans: GroupPlans = {
code: 'professional',
},
],
sizes: ['2', '3', '4', '5', '10', '20', '50'],
sizesForHighDenominationCurrencies: ['2', '3', '4', '5', '10', '20'],
sizes: ['2', '3', '4', '5', '10', '20'],
}
export const groupPriceByUsageTypeAndSize = {
@@ -252,9 +251,6 @@ export const groupPriceByUsageTypeAndSize = {
'20': {
price_in_cents: 264000,
},
'50': {
price_in_cents: 605000,
},
},
USD: {
'2': {
@@ -275,9 +271,6 @@ export const groupPriceByUsageTypeAndSize = {
'20': {
price_in_cents: 286000,
},
'50': {
price_in_cents: 655000,
},
},
},
collaborator: {
@@ -300,9 +293,6 @@ export const groupPriceByUsageTypeAndSize = {
'20': {
price_in_cents: 128000,
},
'50': {
price_in_cents: 295000,
},
},
USD: {
'2': {
@@ -323,9 +313,6 @@ export const groupPriceByUsageTypeAndSize = {
'20': {
price_in_cents: 142000,
},
'50': {
price_in_cents: 325000,
},
},
},
},
@@ -350,9 +337,6 @@ export const groupPriceByUsageTypeAndSize = {
'20': {
price_in_cents: 442000,
},
'50': {
price_in_cents: 1010000,
},
},
USD: {
'2': {
@@ -373,9 +357,6 @@ export const groupPriceByUsageTypeAndSize = {
'20': {
price_in_cents: 478000,
},
'50': {
price_in_cents: 1095000,
},
},
},
collaborator: {
@@ -398,9 +379,6 @@ export const groupPriceByUsageTypeAndSize = {
'20': {
price_in_cents: 214000,
},
'50': {
price_in_cents: 490000,
},
},
USD: {
'2': {
@@ -421,9 +399,6 @@ export const groupPriceByUsageTypeAndSize = {
'20': {
price_in_cents: 238000,
},
'50': {
price_in_cents: 545000,
},
},
},
},
services/web/test/unit/src/Subscription/SubscriptionControllerTests.js
-1
View File
@@ -99,7 +99,6 @@ describe('SubscriptionController', function () {
},
],
sizes: ['42'],
sizesForHighDenominationCurrencies: ['42'],
usages: [{ code: 'foo', display: 'Foo' }],
},
apis: {
services/web/types/subscription/dashboard/group-plans.ts
-1
View File
@@ -4,5 +4,4 @@ export type GroupPlans = {
code: string
}[]
sizes: string[]
sizesForHighDenominationCurrencies: string[]
}