Merge pull request #5709 from overleaf/ae-fail-prop-types-tests

Format error messages for test failure

GitOrigin-RevId: 74da66d9da31939755162a91f5adf4f8122f06f6

services/web/test/frontend/features/editor-navigation-toolbar/components/toolbar-header.test.js

@@ -18,6 +18,9 @@ describe('<ToolbarHeader />', function () {
     togglePdfView: () => {},
     hasPublishPermissions: true,
     trackChangesVisible: true,
+    handleChangeLayout: () => {},
+    pdfLayout: '',
+    view: '',
   }
 
   describe('cobranding logo', function () {

services/web/test/frontend/features/outline/components/outline-pane.test.js

@@ -76,7 +76,13 @@ describe('<OutlinePane />', function () {
   })
 
   it('expand outline and use local storage', function () {
-    global.localStorage.getItem.returns(false)
+    global.localStorage.getItem.callsFake(key => {
+      if (key.startsWith('file_outline.expanded.')) {
+        return false
+      }
+      return null
+    })
+
     const outline = [
       {
         title: 'Section',

services/web/test/frontend/prop-types.test.js

@@ -1,3 +1,5 @@
+import { format } from 'util'
+
 /**
  * Make tests fail when prop-types are incorrect.
  *
@@ -14,10 +16,12 @@ before(function () {
     // Ensure we still log the error
     originalConsoleError(message, ...args)
 
+    const formattedMessage = format(message, ...args)
+
     // Check if the error is from prop-types
-    if (/Failed (prop|data) type/.test(message)) {
+    if (/Failed (prop|data) type/.test(formattedMessage)) {
       // Throw an error, causing the test to fail
-      throw new Error(message)
+      throw new Error(formattedMessage)
     }
   }
 })