agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-11-15 14:43:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

Do array null check in callback args

Browse Source
This commit is contained in:
James Allen
2016-03-15 14:05:59 +00:00
parent b556d57f40
commit 5781894453
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/app/coffee/Features/Collaborators/CollaboratorsHandler.coffee
+6 -6
View File
@@ -26,9 +26,9 @@ module.exports = CollaboratorsHandler =
return callback null, members.map (m) -> m.id
getMembersWithPrivilegeLevels: (project_id, callback = (error, members) ->) ->
CollaboratorsHandler.getMemberIdsWithPrivilegeLevels project_id, (error, members) ->
CollaboratorsHandler.getMemberIdsWithPrivilegeLevels project_id, (error, members = []) ->
return callback(error) if error?
async.mapLimit (members or []), 3,
async.mapLimit members, 3,
(member, cb) ->
UserGetter.getUser member.id, (error, user) ->
return cb(error) if error?
@@ -38,9 +38,9 @@ module.exports = CollaboratorsHandler =
getMemberIdPrivilegeLevel: (user_id, project_id, callback = (error, privilegeLevel) ->) ->
# In future if the schema changes and getting all member ids is more expensive (multiple documents)
# then optimise this.
CollaboratorsHandler.getMemberIdsWithPrivilegeLevels project_id, (error, members) ->
CollaboratorsHandler.getMemberIdsWithPrivilegeLevels project_id, (error, members = []) ->
return callback(error) if error?
for member in members or []
for member in members
if member.id == user_id?.toString()
return callback null, member.privilegeLevel
return callback null, false
@@ -56,9 +56,9 @@ module.exports = CollaboratorsHandler =
return callback null, count - 1 # Don't count project owner
isUserMemberOfProject: (user_id, project_id, callback = (error, isMember, privilegeLevel) ->) ->
CollaboratorsHandler.getMemberIdsWithPrivilegeLevels project_id, (error, members) ->
CollaboratorsHandler.getMemberIdsWithPrivilegeLevels project_id, (error, members = []) ->
return callback(error) if error?
for member in members or []
for member in members
if member.id.toString() == user_id.toString()
return callback null, true, member.privilegeLevel
return callback null, false, null