mirror of
https://github.com/yu-i-i/overleaf-cep.git
synced 2026-05-23 17:19:37 +02:00
fixed bug where file uploader was calling cb on read stream not write stream, race condition created.
This commit is contained in:
@@ -13,7 +13,7 @@ module.exports =
|
||||
uri: @_buildUrl(project_id, file_id)
|
||||
writeStream = request(opts)
|
||||
readStream.pipe writeStream
|
||||
readStream.on "end", callback
|
||||
writeStream.on "end", callback
|
||||
readStream.on "error", (err)->
|
||||
logger.err err:err, project_id:project_id, file_id:file_id, fsPath:fsPath, "something went wrong on the read stream of uploadFileFromDisk"
|
||||
callback err
|
||||
|
||||
@@ -10,7 +10,11 @@ describe "FileStoreHandler", ->
|
||||
beforeEach ->
|
||||
@fs =
|
||||
createReadStream : sinon.stub()
|
||||
@writeStream = {my:"writeStream", on:->}
|
||||
@writeStream =
|
||||
my:"writeStream"
|
||||
on: (type, cb)->
|
||||
if type == "end"
|
||||
cb()
|
||||
@readStream = {my:"readStream"}
|
||||
@request = sinon.stub()
|
||||
@settings = apis:{filestore:{url:"http//filestore.sharelatex.test"}}
|
||||
|
||||
Reference in New Issue
Block a user