Merge pull request #19192 from overleaf/em-project-history-avoid-crash

Prevent project-history crashes when generating a diff GitOrigin-RevId: 513fb846f0884a68d4550783497ae436e1cba00f
2026-05-23 17:19:37 +02:00 · 2024-06-27 16:24:05 -04:00
parent d7863bec37
commit 67dbf743e1
1 changed files with 12 additions and 1 deletions
--- a/services/project-history/app/js/DiffManager.js
+++ b/services/project-history/app/js/DiffManager.js
@@ -37,7 +37,18 @@ export function getDiff(projectId, pathname, fromVersion, toVersion, callback) {
        if (binary) {
          diff = { binary: true }
        } else {
-          diff = DiffGenerator.buildDiff(initialContent, updates)
+          try {
+            diff = DiffGenerator.buildDiff(initialContent, updates)
+          } catch (err) {
+            return callback(
+              OError.tag(err, 'failed to build diff', {
+                projectId,
+                pathname,
+                fromVersion,
+                toVersion,
+              })
+            )
+          }
        }
        callback(null, diff)
      }