Remove the full-project-search split test (#25444)

GitOrigin-RevId: b36c1c81152694547dcf044cfb2cb0f511bfdc22

services/web/app/src/Features/Project/ProjectController.js

@@ -335,7 +335,6 @@ const _ProjectController = {
     const splitTests = [
       'compile-log-events',
       'external-socket-heartbeat',
-      'full-project-search',
       'null-test-share-modal',
       'populate-clsi-cache',
       'pdf-caching-cached-url-lookup',

services/web/frontend/js/features/source-editor/components/codemirror-search-form.tsx

@@ -29,7 +29,6 @@ import MaterialIcon from '@/shared/components/material-icon'
 import OLButtonGroup from '@/features/ui/components/ol/ol-button-group'
 import OLFormControl from '@/features/ui/components/ol/ol-form-control'
 import OLCloseButton from '@/features/ui/components/ol/ol-close-button'
-import { isSplitTestEnabled } from '@/utils/splitTestUtils'
 import { useTranslation } from 'react-i18next'
 import classnames from 'classnames'
 import { useUserSettingsContext } from '@/shared/context/user-settings-context'
@@ -444,9 +443,7 @@ const CodeMirrorSearchForm: FC<React.PropsWithChildren> = () => {
             </OLButton>
           </OLButtonGroup>
 
-          {!newEditor && isSplitTestEnabled('full-project-search') && (
-            <FullProjectSearchButton query={query} />
-          )}
+          {!newEditor && <FullProjectSearchButton query={query} />}
 
           {position !== null && (
             <div className="ol-cm-search-form-position">

services/web/frontend/js/features/source-editor/components/full-project-search-button.tsx

@@ -80,7 +80,7 @@ export const FullProjectSearchButton = ({ query }: { query: SearchQuery }) => {
         <OLButton variant="secondary" size="sm" ref={ref} onClick={onClick}>
           <MaterialIcon
             type="manage_search"
-            accessibilityLabel={t('search_next')}
+            accessibilityLabel={t('search_all_project_files')}
           />
         </OLButton>
       </OLTooltip>

services/web/frontend/js/shared/context/layout-context.tsx

@@ -18,7 +18,6 @@ import { debugConsole } from '@/utils/debugging'
 import { BinaryFile } from '@/features/file-view/types/binary-file'
 import useScopeEventEmitter from '@/shared/hooks/use-scope-event-emitter'
 import useEventListener from '@/shared/hooks/use-event-listener'
-import { isSplitTestEnabled } from '@/utils/splitTestUtils'
 import { isMac } from '@/shared/utils/os'
 import { sendSearchEvent } from '@/features/event-tracking/search-events'
 import { useRailContext } from '@/features/ide-redesign/contexts/rail-context'
@@ -161,14 +160,12 @@ export const LayoutProvider: FC<React.PropsWithChildren> = ({ children }) => {
         event.shiftKey &&
         event.code === 'KeyF'
       ) {
-        if (isSplitTestEnabled('full-project-search')) {
-          event.preventDefault()
-          sendSearchEvent('search-open', {
-            searchType: 'full-project',
-            method: 'keyboard',
-          })
-          setProjectSearchIsOpen(true)
-        }
+        event.preventDefault()
+        sendSearchEvent('search-open', {
+          searchType: 'full-project',
+          method: 'keyboard',
+        })
+        setProjectSearchIsOpen(true)
       }
     }, [])
   )

services/web/test/frontend/features/source-editor/components/codemirror-editor.spec.tsx

@@ -13,6 +13,8 @@ describe('<CodeMirrorEditor/>', { scrollBehavior: false }, function () {
   beforeEach(function () {
     window.metaAttributesCache.set('ol-preventCompileOnLoad', true)
     cy.interceptEvents()
+    cy.intercept('GET', '/project/*/changes/users', [])
+    cy.intercept('GET', '/project/*/threads', {})
   })
 
   it('deletes selected text on Backspace', function () {
@@ -519,6 +521,9 @@ describe('<CodeMirrorEditor/>', { scrollBehavior: false }, function () {
       cy.findByLabelText('Within selection').as('within-selection-label')
       cy.findByRole('button', { name: 'Replace' }).as('replace')
       cy.findByRole('button', { name: 'Replace All' }).as('replace-all')
+      cy.findByRole('button', { name: 'Search all project files' }).as(
+        'search-project'
+      )
       cy.findByRole('button', { name: 'previous' }).as('find-previous')
       cy.findByRole('button', { name: 'next' }).as('find-next')
       cy.findByRole('button', { name: 'Close' }).as('close')
@@ -532,6 +537,7 @@ describe('<CodeMirrorEditor/>', { scrollBehavior: false }, function () {
       cy.get('@within-selection').should('be.focused').tab()
       cy.get('@find-previous').should('be.focused').tab()
       cy.get('@find-next').should('be.focused').tab()
+      cy.get('@search-project').should('be.focused').tab()
       cy.get('@replace').should('be.focused').tab()
       cy.get('@replace-all').should('be.focused').tab()
 
@@ -539,6 +545,7 @@ describe('<CodeMirrorEditor/>', { scrollBehavior: false }, function () {
       cy.get('@close').should('be.focused').tab({ shift: true })
       cy.get('@replace-all').should('be.focused').tab({ shift: true })
       cy.get('@replace').should('be.focused').tab({ shift: true })
+      cy.get('@search-project').should('be.focused').tab({ shift: true })
       cy.get('@find-next').should('be.focused').tab({ shift: true })
       cy.get('@find-previous').should('be.focused').tab({ shift: true })
       cy.get('@within-selection').should('be.focused').tab({ shift: true })