agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-11-13 21:53:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #22082 from overleaf/mf-remove-is-split-test-active

Browse Source 
[web] Remove `isSplitTestActive` function since it is no longer used

GitOrigin-RevId: 81f3f61f14bb10d403fa72a61dc4a304c191512f
This commit is contained in:
M Fahru
2024-12-18 09:05:55 +00:00
committed by Copybot
parent 659f15d010
commit 6daf2bef45
2 changed files with 0 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/app/src/Features/SplitTests/SplitTestHandler.js
-11
View File
@@ -582,16 +582,6 @@ async function _getSplitTest(name) {
}
}
async function isSplitTestActive(splitTestName) {
try {
const splitTest = await _getSplitTest(splitTestName)
const currentVersion = SplitTestUtils.getCurrentVersion(splitTest)
return currentVersion?.active
} catch (e) {
logger.log('unable to check if split test is active ', splitTestName)
}
}
module.exports = {
getPercentile,
getAssignment: callbackify(getAssignment),
@@ -607,6 +597,5 @@ module.exports = {
getAssignmentForUser,
getOneTimeAssignment,
getActiveAssignmentsForUser,
isSplitTestActive,
},
}
services/web/test/unit/src/SplitTests/SplitTestHandlerTests.js
-26
View File
@@ -311,32 +311,6 @@ describe('SplitTestHandler', function () {
)
})
})
describe('isSplitTestActive', function () {
it('returns false when current version is not active', async function () {
const res =
await this.SplitTestHandler.promises.isSplitTestActive(
'not-active-test'
)
expect(res).to.be.false
})
it('returns undefined false when current version is active', async function () {
const res =
await this.SplitTestHandler.promises.isSplitTestActive('active-test')
expect(res).to.be.true
})
it('returns undefined when there is an error checking', async function () {
this.SplitTestCache.get.rejects(new Error('oops'))
const res =
await this.SplitTestHandler.promises.isSplitTestActive('active-test')
expect(res).to.be.undefined
})
it('returns undefined when there is no test', async function () {
const res =
await this.SplitTestHandler.promises.isSplitTestActive('not-a-test')
expect(res).to.be.undefined
})
})
})
function makeSplitTest(