agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-05-23 17:19:37 +02:00
Code Issues Packages Projects Releases Wiki Activity

Ensure metrics exist before collecting them

Browse Source 
GitOrigin-RevId: 811301ddebb794341dccc0f27954c66dc5c44aa4
This commit is contained in:
Andrew Rumble
2025-03-19 12:23:58 +00:00
committed by Copybot
parent 47d8e59938
commit 800b151024
1 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
services/history-v1/backupVerifier/ProjectVerifier.mjs
View File

@@ -13,11 +13,16 @@ import { setTimeout } from 'node:timers/promises'
const MS_PER_30_DAYS = 30 * 24 * 60 * 60 * 1000
const METRICS = {
backup_project_verification_failed: 'backup_project_verification_failed',
backup_project_verification_succeeded:
'backup_project_verification_succeeded',
}
const failureCounter = new metrics.prom.Counter({
name: 'backup_project_verification_failed',
help: 'Number of projects that failed verification',
labelNames: ['name'],
})
const successCounter = new metrics.prom.Counter({
name: 'backup_project_verification_succeeded',
help: 'Number of projects that succeeded verification',
})
let WRITE_METRICS = false
@@ -42,8 +47,7 @@ function handleVerificationError(error, historyId) {
const name = error instanceof Error ? error.name : 'UnknownError'
logger.error({ historyId, error, name }, 'error verifying project backup')
WRITE_METRICS &&
metrics.inc(METRICS.backup_project_verification_failed, 1, { name })
WRITE_METRICS && failureCounter.inc({ name })
return name
}
@@ -97,8 +101,7 @@ async function verifyProjectsFromCursor(
try {
await verifyProjectWithErrorContext(historyId)
logger.debug({ historyId }, 'verified project backup successfully')
WRITE_METRICS &&
metrics.inc(METRICS.backup_project_verification_succeeded)
WRITE_METRICS && successCounter.inc()
verified++
} catch (error) {
const errorType = handleVerificationError(error, historyId)