Ensure metrics exist before collecting them

GitOrigin-RevId: 811301ddebb794341dccc0f27954c66dc5c44aa4

services/history-v1/backupVerifier/ProjectVerifier.mjs

@@ -13,11 +13,16 @@ import { setTimeout } from 'node:timers/promises'
 
 const MS_PER_30_DAYS = 30 * 24 * 60 * 60 * 1000
 
-const METRICS = {
+const failureCounter = new metrics.prom.Counter({
-  backup_project_verification_failed: 'backup_project_verification_failed',
+  name: 'backup_project_verification_failed',
-  backup_project_verification_succeeded:
+  help: 'Number of projects that failed verification',
-    'backup_project_verification_succeeded',
+  labelNames: ['name'],
-}
+})
+
+const successCounter = new metrics.prom.Counter({
+  name: 'backup_project_verification_succeeded',
+  help: 'Number of projects that succeeded verification',
+})
 
 let WRITE_METRICS = false
 
@@ -42,8 +47,7 @@ function handleVerificationError(error, historyId) {
   const name = error instanceof Error ? error.name : 'UnknownError'
   logger.error({ historyId, error, name }, 'error verifying project backup')
 
-  WRITE_METRICS &&
+  WRITE_METRICS && failureCounter.inc({ name })
-    metrics.inc(METRICS.backup_project_verification_failed, 1, { name })
 
   return name
 }
@@ -97,8 +101,7 @@ async function verifyProjectsFromCursor(
     try {
       await verifyProjectWithErrorContext(historyId)
       logger.debug({ historyId }, 'verified project backup successfully')
-      WRITE_METRICS &&
+      WRITE_METRICS && successCounter.inc()
-        metrics.inc(METRICS.backup_project_verification_succeeded)
       verified++
     } catch (error) {
       const errorType = handleVerificationError(error, historyId)