agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-05-31 21:01:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3646 from overleaf/jpa-narrow-global-watch-dog-scope

Browse Source 
[frontend] aceEditor: narrow down the scope of the global watch dog

GitOrigin-RevId: 610c771eb6e4dc04acfe0a6ba6e5be7796aaeb87
This commit is contained in:
Jakob Ackermann
2021-02-11 09:42:19 +00:00
committed by Copybot
parent 60d32f3e55
commit 93cd752e24
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
services/web/frontend/js/ide/editor/directives/aceEditor.js
View File

@@ -117,10 +117,15 @@ App.directive('aceEditor', function(
const editor = ace.edit(element.find('.ace-editor-body')[0])
editor.$blockScrolling = Infinity
// end-to-end check for edits -> acks, globally on any doc
// This may catch a missing attached ShareJsDoc that in turn bails out
// on missing acks.
ide.globalEditorWatchdogManager.attachToEditor('Ace', editor)
// Besides the main editor, other elements will re-use this directive
// for displaying read-only content -- e.g. the history panes.
const editorAcceptsChanges = attrs.aceEditor === 'editor'
if (editorAcceptsChanges) {
// end-to-end check for edits -> acks, globally on any doc
// This may catch a missing attached ShareJsDoc that in turn bails out
// on missing acks.
ide.globalEditorWatchdogManager.attachToEditor('Ace', editor)
}
// auto-insertion of braces, brackets, dollars
editor.setOption('behavioursEnabled', scope.autoPairDelimiters || false)