agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-06-03 06:09:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #28567 from overleaf/bg-fix-project-locator-root-folder

Browse Source 
respect elementType when matching rootFolder in findElement

GitOrigin-RevId: f4e20ee6441fc16915297b2ac24737ed63398027
This commit is contained in:
Brian Gough
2025-09-19 08:57:32 +01:00
committed by Copybot
parent d75f4b3a7b
commit 9d28e4ab91
2 changed files with 28 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/app/src/Features/Project/ProjectLocator.js
+4 -1
View File
@@ -95,7 +95,10 @@ function findElement(options, _callback) {
const path = { fileSystem: '', mongo: 'rootFolder.0' }
const startSearch = project => {
if (elementId + '' === project.rootFolder[0]._id + '') {
if (
elementId + '' === project.rootFolder[0]._id + '' &&
elementType === 'folders'
) {
callback(null, project.rootFolder[0], path, null)
} else {
search(project.rootFolder[0], path)
services/web/test/unit/src/Project/ProjectLocatorTests.js
+24
View File
@@ -112,6 +112,30 @@ describe('ProjectLocator', function () {
foundElement._id.should.equal(rootFolder._id)
})
it('should not return root folder when searching for docs', async function () {
await expect(
this.locator.promises.findElement({
project_id: project._id,
element_id: rootFolder._id,
type: 'docs',
})
)
.to.eventually.be.rejectedWith(Errors.NotFoundError)
.and.eventually.have.property('message', 'entity not found')
})
it('should not return root folder when searching for files', async function () {
await expect(
this.locator.promises.findElement({
project_id: project._id,
element_id: rootFolder._id,
type: 'files',
})
)
.to.eventually.be.rejectedWith(Errors.NotFoundError)
.and.eventually.have.property('message', 'entity not found')
})
it('when at root', async function () {
const {
element: foundElement,