Merge pull request #24856 from overleaf/bg-history-redis-buffer-tweaks

fix error logging for chunk cache mismatches

GitOrigin-RevId: 85344c4025fdaa6ee916c5438ff38c7c49f4bce3
This commit is contained in:
Brian Gough
2025-04-15 08:46:44 +01:00
committed by Copybot
parent 5fa69ca474
commit c05057f0ac

View File

@@ -172,7 +172,22 @@ function compareChunks(projectId, cachedChunk, currentChunk) {
return false
}
const identical = JSON.stringify(cachedChunk) === JSON.stringify(currentChunk)
logger.error({ projectId }, 'chunk cache mismatch')
if (!identical) {
try {
logger.error(
{
projectId,
cachedChunkStartVersion: cachedChunk.getStartVersion(),
cachedChunkEndVersion: cachedChunk.getEndVersion(),
currentChunkStartVersion: currentChunk.getStartVersion(),
currentChunkEndVersion: currentChunk.getEndVersion(),
},
'chunk cache mismatch'
)
} catch (err) {
// ignore errors while logging
}
}
metrics.inc('chunk_store.redis.compare_chunks', 1, {
status: identical ? 'success' : 'fail',
})